diff options
| author | Ahmad Samir <a.samirh78@gmail.com> | 2023-05-21 22:52:47 +0300 |
|---|---|---|
| committer | Ahmad Samir <a.samirh78@gmail.com> | 2023-06-22 02:20:30 +0300 |
| commit | 475d5266e41a5d95a73478dd770d6a8326a95021 (patch) | |
| tree | 31cc59960dd98e5d0d14835e6be07edc4b60da8b /src/tools/moc/generator.cpp | |
| parent | 17df4bf52847cb38765a6318d411218ecee84c08 (diff) | |
Moc: prevent potential unnecessary detach
Change Generator::generateSignal() to take by const FunctionDef*, so
that it can be called with the return of QList::at().
Change-Id: I5ffb0726a5ded6561e0000a2bea1973ada675152
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/tools/moc/generator.cpp')
| -rw-r--r-- | src/tools/moc/generator.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/moc/generator.cpp b/src/tools/moc/generator.cpp index f295235c1c..75f1ce00ff 100644 --- a/src/tools/moc/generator.cpp +++ b/src/tools/moc/generator.cpp @@ -627,7 +627,7 @@ void Generator::generateCode() // Generate internal signal functions // for (int signalindex = 0; signalindex < int(cdef->signalList.size()); ++signalindex) - generateSignal(&cdef->signalList[signalindex], signalindex); + generateSignal(&cdef->signalList.at(signalindex), signalindex); // // Generate plugin meta data @@ -1408,7 +1408,7 @@ void Generator::generateStaticMetacall() fprintf(out, "}\n"); } -void Generator::generateSignal(FunctionDef *def,int index) +void Generator::generateSignal(const FunctionDef *def, int index) { if (def->wasCloned || def->isAbstract) return; |