path: root/src/widgets
diff options
authorThiago Macieira <>2012-12-28 20:38:19 -0200
committerThe Qt Project <>2012-12-29 22:38:48 +0100
commit8094c8fe184ae10fe8673bc35a16bfe17b7510ff (patch)
tree8ce4a0bc4d7474f61a2c64201b1037ae162d5ba5 /src/widgets
parentfbfe420aeb03f497edc86b38a00b4c5cdc62cd4c (diff)
Remove unused function _q_qgraphicsItemSetFlag
Clang reports: graphicsview/qgraphicsitem.cpp:1779:13: error: function '_q_qgraphicsItemSetFlag' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] static void _q_qgraphicsItemSetFlag(QGraphicsItem *item, QGraphicsItem::GraphicsItemFlag flag, ^ According to the public Git history, in Qt 4.5.1 this function was already unused. The only reason it wasn't caught so far is that it is recursive: it calls itself. So it is used... by itself. Change-Id: I6fc6b33cb314b845525dc9315d0ad742e113d5cd Reviewed-by: Andreas Aardal Hanssen <> Reviewed-by: Olivier Goffart <>
Diffstat (limited to 'src/widgets')
1 files changed, 0 insertions, 18 deletions
diff --git a/src/widgets/graphicsview/qgraphicsitem.cpp b/src/widgets/graphicsview/qgraphicsitem.cpp
index 3ba9b89e34..ec4a1827ef 100644
--- a/src/widgets/graphicsview/qgraphicsitem.cpp
+++ b/src/widgets/graphicsview/qgraphicsitem.cpp
@@ -1772,24 +1772,6 @@ void QGraphicsItem::setFlag(GraphicsItemFlag flag, bool enabled)
- \internal
- Sets the flag \a flag on \a item and all its children, to \a enabled.
-static void _q_qgraphicsItemSetFlag(QGraphicsItem *item, QGraphicsItem::GraphicsItemFlag flag,
- bool enabled)
- if (item->flags() & flag) {
- // If this item already has the correct flag set, we don't have to
- // propagate it.
- return;
- }
- item->setFlag(flag, enabled);
- foreach (QGraphicsItem *child, item->childItems())
- _q_qgraphicsItemSetFlag(child, flag, enabled);
Sets the item flags to \a flags. All flags in \a flags are enabled; all
flags not in \a flags are disabled.