summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@kdab.com>2021-06-16 10:29:01 +0200
committerMarc Mutz <marc.mutz@kdab.com>2021-06-17 01:33:15 +0200
commit259dc8cbe50af7fd48e6ff3e0a1880c26872620a (patch)
treed6026d5b7c3fc65e77aee2d69263473d5d6431fb /src
parent95cb4e226040dc9b739efafb2073fdd6f11800ee (diff)
QTextStream: fix a dead write
Found by Clazy. Change-Id: Iabe4fb23f63ea8df2142dc66cd16b04526b628c2 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/corelib/serialization/qtextstream.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/corelib/serialization/qtextstream.cpp b/src/corelib/serialization/qtextstream.cpp
index 392a6bfeaa..50bb63465f 100644
--- a/src/corelib/serialization/qtextstream.cpp
+++ b/src/corelib/serialization/qtextstream.cpp
@@ -560,7 +560,6 @@ bool QTextStreamPrivate::scan(const QChar **ptr, int *length, int maxlen, TokenD
int startOffset = device ? readBufferOffset : stringOffset;
QChar lastChar;
- bool canStillReadFromDevice = true;
do {
int endOffset;
const QChar *chPtr;
@@ -602,7 +601,7 @@ bool QTextStreamPrivate::scan(const QChar **ptr, int *length, int maxlen, TokenD
}
} while (!foundToken
&& (!maxlen || totalSize < maxlen)
- && (device && (canStillReadFromDevice = fillReadBuffer())));
+ && device && fillReadBuffer());
if (totalSize == 0) {
#if defined (QTEXTSTREAM_DEBUG)