diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2022-08-18 11:10:09 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2022-08-21 08:29:54 +0200 |
| commit | 35cbf52f0c2efb14741fd624138cdeebee563a57 (patch) | |
| tree | 28cd2598bd79dc4dd13660b4a8c9b88d37a51d06 /src | |
| parent | f06c41e729dd0d6f57a161cc75d0872cd7fcc621 (diff) | |
Port QDir to qsizetype [1/3]: indexed to ranged loops
Indexed for loops are prone to int/qsizetype mismatches, so use ranged
for loops where possible.
Pick-to: 6.4 6.3 6.2
Task-number: QTBUG-103525
Change-Id: Ia3e97a6b2924f92d3f7fb1a7ae075b59188006e9
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/corelib/io/qdir.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/corelib/io/qdir.cpp b/src/corelib/io/qdir.cpp index fa2746798a..ee0871b57b 100644 --- a/src/corelib/io/qdir.cpp +++ b/src/corelib/io/qdir.cpp @@ -285,8 +285,8 @@ inline void QDirPrivate::sortFileList(QDir::SortFlags sort, const QFileInfoList if (infos) *infos = l; if (names) { - for (int i = 0; i < n; ++i) - names->append(l.at(i).fileName()); + for (const QFileInfo &fi : l) + names->append(fi.fileName()); } } else { QScopedArrayPointer<QDirSortItem> si(new QDirSortItem[n]); @@ -1057,8 +1057,8 @@ void QDir::setSearchPaths(const QString &prefix, const QStringList &searchPaths) return; } - for (int i = 0; i < prefix.length(); ++i) { - if (!prefix.at(i).isLetterOrNumber()) { + for (QChar ch : prefix) { + if (!ch.isLetterOrNumber()) { qWarning("QDir::setSearchPaths: Prefix can only contain letters or numbers"); return; } |