summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2023-01-10 13:23:12 +0100
committerMarc Mutz <marc.mutz@qt.io>2023-01-13 17:20:56 +0100
commit3b0439379f31aa80bb7a08b2cb17c11311122759 (patch)
tree73926f82cb5b2d7cffda8b42a2ec8f6811764c91 /src
parent595360506d18210c614ad8eacf5a1819ae91704e (diff)
QLocationPermission: make enums have explicit underlying type
They can be smaller than an int, so use quint8. In a world of BC guarantees, pinning the underlying type of enums is best practice. Found during API review. Pick-to: 6.5 Change-Id: I0c31fe4565329982c81173e3a265f73758aad257 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/corelib/kernel/qpermissions.h10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/corelib/kernel/qpermissions.h b/src/corelib/kernel/qpermissions.h
index 361bc868b6..9c47df3eb1 100644
--- a/src/corelib/kernel/qpermissions.h
+++ b/src/corelib/kernel/qpermissions.h
@@ -93,13 +93,19 @@ class QLocationPermission
{
QT_PERMISSION(QLocationPermission)
public:
- enum Accuracy { Approximate, Precise };
+ enum Accuracy : quint8 {
+ Approximate,
+ Precise,
+ };
Q_ENUM(Accuracy)
Q_CORE_EXPORT void setAccuracy(Accuracy accuracy);
Q_CORE_EXPORT Accuracy accuracy() const;
- enum Availability { WhenInUse, Always };
+ enum Availability : quint8 {
+ WhenInUse,
+ Always,
+ };
Q_ENUM(Availability)
Q_CORE_EXPORT void setAvailability(Availability availability);