diff options
author | Sona Kurazyan <sona.kurazyan@qt.io> | 2022-03-22 10:57:35 +0100 |
---|---|---|
committer | Sona Kurazyan <sona.kurazyan@qt.io> | 2022-03-22 17:43:12 +0100 |
commit | 401349af26521d303f422eaf7bbccfc638f6db91 (patch) | |
tree | 5970cfaaf6074ebf76691970f662fcf8ed1343d9 /src | |
parent | 2ba3cde348faa5b47d23179e2de5745649088033 (diff) |
QFuture: fix a codechecker warning
Codechecker complains about passing a forwarding reference to std::move,
which may unexpectedly cause lvalues to be moved. We should use
std::forward instead.
This amends cbf8fc0ac43365f4dd69c64ec770d8f547d772f3
Change-Id: Ieba9e960b5dfb448e9cebabe9541967698995b8f
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src')
-rw-r--r-- | src/corelib/thread/qfuture_impl.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/thread/qfuture_impl.h b/src/corelib/thread/qfuture_impl.h index 5af37b970e..90abb99d8e 100644 --- a/src/corelib/thread/qfuture_impl.h +++ b/src/corelib/thread/qfuture_impl.h @@ -150,7 +150,7 @@ auto createTuple(Arg &&arg, Args &&... args) constexpr auto Size = sizeof...(Args); // One less than the size of all arguments if constexpr (QtPrivate::IsPrivateSignalArg<std::tuple_element_t<Size, TupleType>>) { if constexpr (Size == 1) { - return std::move(arg); + return std::forward<Arg>(arg); } else { return cutTuple(std::make_tuple(std::forward<Arg>(arg), std::forward<Args>(args)...), std::make_index_sequence<Size>()); |