summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorYuhang Zhao <2546789017@qq.com>2019-02-01 20:15:50 +0800
committerYuhang Zhao <2546789017@qq.com>2019-02-03 12:23:04 +0000
commitaea357c6bd28fd460a92980c47efbc9a6f418572 (patch)
treee097296cdc543318fed3f0b046141c176d3f2350 /src
parentfd1ebef13e9d0ebb82f1994eed264b849e3be9e9 (diff)
qtmain_win.cpp: Improve coding style
Change-Id: I08c722f4ff8a088d13af5b7d9cfbc88258d533ad Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/winmain/qtmain_win.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/winmain/qtmain_win.cpp b/src/winmain/qtmain_win.cpp
index 752fba1d5a..0f29c6ac95 100644
--- a/src/winmain/qtmain_win.cpp
+++ b/src/winmain/qtmain_win.cpp
@@ -82,7 +82,7 @@ extern "C" int main(int, char **);
// Convert a wchar_t to char string, equivalent to QString::toLocal8Bit()
// when passed CP_ACP.
-static inline char *wideToMulti(int codePage, const wchar_t *aw)
+static inline char *wideToMulti(unsigned int codePage, const wchar_t *aw)
{
const int required = WideCharToMultiByte(codePage, 0, aw, -1, nullptr, 0, nullptr, nullptr);
char *result = new char[required];
@@ -92,17 +92,17 @@ static inline char *wideToMulti(int codePage, const wchar_t *aw)
extern "C" int APIENTRY WinMain(HINSTANCE, HINSTANCE, LPSTR /*cmdParamarg*/, int /* cmdShow */)
{
- int argc;
+ int argc = 0;
wchar_t **argvW = CommandLineToArgvW(GetCommandLineW(), &argc);
- if (!argvW)
+ if (argvW == nullptr)
return -1;
char **argv = new char *[argc + 1];
- for (int i = 0; i < argc; ++i)
+ for (int i = 0; i != argc; ++i)
argv[i] = wideToMulti(CP_ACP, argvW[i]);
argv[argc] = nullptr;
LocalFree(argvW);
const int exitCode = main(argc, argv);
- for (int i = 0; i < argc && argv[i]; ++i)
+ for (int i = 0; (i != argc) && (argv[i] != nullptr); ++i)
delete [] argv[i];
delete [] argv;
return exitCode;