diff options
| author | Andy Shaw <andy.shaw@qt.io> | 2019-03-18 14:32:48 +0100 |
|---|---|---|
| committer | Andy Shaw <andy.shaw@qt.io> | 2019-03-19 13:35:25 +0000 |
| commit | fda57bbb32c7c08e750f9ed82d30d95052f927b5 (patch) | |
| tree | d7f3876502ea350555cdc55b4933f9618560ba83 /src | |
| parent | d2dff76a4fc2c28bf204db183230ffa1b86cbf43 (diff) | |
QTemporaryFile: Return early if the passed in QFile cannot be opened
Change-Id: I97f00163c24f74d31e1b41ec7337f72600bda2d5
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Mikhail Svetkin <mikhail.svetkin@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/corelib/io/qtemporaryfile.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/corelib/io/qtemporaryfile.cpp b/src/corelib/io/qtemporaryfile.cpp index 35bb465a04..ced08a9a87 100644 --- a/src/corelib/io/qtemporaryfile.cpp +++ b/src/corelib/io/qtemporaryfile.cpp @@ -908,8 +908,8 @@ QTemporaryFile *QTemporaryFile::createNativeFile(QFile &file) qint64 old_off = 0; if(wasOpen) old_off = file.pos(); - else - file.open(QIODevice::ReadOnly); + else if (!file.open(QIODevice::ReadOnly)) + return nullptr; //dump data QTemporaryFile *ret = new QTemporaryFile; if (ret->open()) { |