path: root/tests/auto/corelib/kernel/qtranslator/tst_qtranslator.cpp
diff options
authorShawn Rutledge <>2020-06-30 11:08:49 +0200
committerVolker Hilsheimer <>2020-07-07 16:14:58 +0000
commitc7c28b340662915a9f8fdb84c0a94c458fe6a290 (patch)
tree2878e2dcff2df2a881853d3e1a08161809c8752e /tests/auto/corelib/kernel/qtranslator/tst_qtranslator.cpp
parent8936918a651ac297c91bfd285995993b306347ab (diff)
Separate QPD::tabletDevice into priv tabletDevice and queryTabletDeviceHEADdev
There doesn't seem to be any reason users will need to query tablet devices by their IDs, because every event comes with a complete instance already, and we have QInputDevice::devices() to list them all. QPointingDevicePrivate::tabletDevice() can create a new instance if a matching one is not found (and complains about that); it's intended for use in QtGui, as a way to find the device if it was not part of the QWSI event. Now it sets the parent of those auto-created instances to QCoreApplication to avoid a memory leak. On the other hand, queryTabletDevice() is intended for use in platform plugins that need to check whether an instance exists; but they will take care of creating new instances themselves, and thus have more control over the parent and the details being stored. Now that the systemId can also be given, the search is more likely to have a unique result, on window systems that provide device IDs. Rename id() to systemId() to clarify that it's a system-specific unique device ID of some sort, not the same as the uniqueId that a stylus has. However it seems that in practice, this will often be 0; so clarify that if it's not unique, QInputDevicePrivate::fromId() and queryTabletDevice() may not always find the right instance. Clarify the function usage via comments. Change-Id: I82bb8d1c26eeaf06f07c290828aa17ec4a31646b Reviewed-by: Volker Hilsheimer <>
Diffstat (limited to 'tests/auto/corelib/kernel/qtranslator/tst_qtranslator.cpp')
0 files changed, 0 insertions, 0 deletions