summaryrefslogtreecommitdiffstats
path: root/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp
diff options
context:
space:
mode:
authorLaszlo Papp <lpapp@kde.org>2022-05-14 17:56:13 +0100
committerLaszlo Papp <lpapp@kde.org>2022-05-15 19:02:22 +0100
commit5d8f815e101da3ae9cd6a666cc097853f52b21da (patch)
tree6ac528b8e80e7e0d73e8e6c8f15fdd31fca762f6 /tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp
parent7c7606460403e6495b860134f28e8d4d45c6c810 (diff)
QKeySequence: Fix the one-off error in the mac glyph array sizeHEADdev
It seems that the size of the corresponding array in the code has a one-off error. This is now fixed. The end of the array passed to lower_bound is wrong because the hard-coded size is size + 1. However, the end is array + size. This is what lower_bound expects from an array. Or any other algorithm for that matter expecting the end of a container as an argument. This can cause issues with something like lower_bound because a potential "empty" fill is not sorted as lower_bound would expect the data structure. It could have been fixed by decreasing the size by one, however it is a more future-proof solution to avoid hard-coding the size and just use std::size(array) instead. Pick-to: 5.15 6.2 6.3 Change-Id: I1d25a5b1a80a3b2634b229e0718108ad5e7808a0 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp')
0 files changed, 0 insertions, 0 deletions