summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Extract header qtresource.h from qglobal.hSona Kurazyan2022-08-255-60/+77
| | | | | | Task-number: QTBUG-99313 Change-Id: I4dd219dcb9181bf23feb6639821764cd5dc19a24 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Extract header qconstructormacros.h from qglobal.hSona Kurazyan2022-08-253-22/+40
| | | | | | Task-number: QTBUG-99313 Change-Id: I3861a3095148c7927aabd8becf6f7b534f214fba Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Move docs for qlonglong and qulonglong to QtTypesSona Kurazyan2022-08-252-19/+19
| | | | | | | These were missed by fc3441101b201ae37fda899bf69b5b4ded790a26. Change-Id: I3a0c3a24d584e9cdc753647bcb6a3829291c9499 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Add qfunctions_win_p.h header for Windows helper functionsTor Arne Vestbø2022-08-252-1/+25
| | | | | | | | | | For now just includes qfunctions_winrt_p.h Once submodules have been moved over to qfunctions_win_p.h we can move non-WinRT specific content from qfunctions_winrt_p.h to _win_p.h. Change-Id: I467bb4991c67a8769b60b9cf9f26aa553c439b92 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
* wasm: use matchView() instead of match()Morten Sørvig2022-08-251-5/+5
| | | | | | | | QRegularExpression::match() is deprecated. Change-Id: I66c7b3043a3805614fedcdb081c7e704e9925e5e Reviewed-by: David Skoland <david.skoland@qt.io> Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* QMetaObject: add revision 11 for Qt 6.5Thiago Macieira2022-08-253-4/+5
| | | | | | | | | | | | | | | We changed qTryMetaTypeInterfaceForType() so it does record void and void* (see commit 2d0c31e7d92a3e9df4ce2b9c1d41b94fb12735fc and commit 3695b35dfc427f274e55f8e2a6a9876deb52f1b4). By incrementing the revision number, we make it possible to determine at runtime whether the new information ought to be present. We may add even more types (namely, non-const references) before 6.5.0 is out. For pointers, the restriction remains that the metatype is recorded only if the pointer is a pointer to a complete type. Change-Id: Ic6547f8247454b47baa8fffd170dad79b1a90f6b Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* QSystemLibrary: Use Windows functionality directlyYuhang Zhao2022-08-251-8/+8
| | | | | | | | | | Passing LOAD_LIBRARY_SEARCH_SYSTEM32 to LoadLibraryEx() can also only load libraries from the system directory, so in this case we can use it directly instead of doing all the work ourself. Change-Id: I4971781e55c9f1476861d599d58233114c280bc9 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* qt_fusionPalette: make links more legible on dark backgroundsMitch Curtis2022-08-251-2/+7
| | | | | | | | | | | | | QPalette's default for Link is Qt::blue, which is difficult to read on dark backgrounds. Use the same blue that is already used for Highlight, as it is consistent and easy to read. Task-number: QTBUG-90504 Pick-to: 6.4 Change-Id: Ic7aceafb2bd0e57b65448917c352e3551ad26610 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Use the qt type Qt::Edges instead of wasm-specificMikolaj Boc2022-08-246-86/+53
| | | | | | | | The types essentially do the same job - the one that is more general should be used, the other - removed, as it is redundant. Change-Id: Iec09d3311681abce1405fcf8c2cebfb72f3fd51c Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Re-create TLW's window only when its surface type is really changedIlya Fedin2022-08-241-1/+1
| | | | | | | Fixes: QTBUG-105017 Pick-to: 6.4 Change-Id: If5826172efb53b6df15dd3b7ba91b09d733cc77f Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
* wasm: disable asyncify for non-static buildsMorten Sørvig2022-08-241-0/+23
| | | | | | | | | | The asyncify support in the event loop currently uses EM_JS, which Emscripten does not support using from side modules. Change-Id: I5f961d9cd12f7b1b6cc1c2382b807a1da2918725 Reviewed-by: Lorn Potter <lorn.potter@gmail.com> Reviewed-by: Mikołaj Boc <Mikolaj.Boc@qt.io>
* CMake: don't use full paths for X11 SM and ICE libsSamuli Piippo2022-08-242-2/+3
| | | | | | | | | Full paths were recorded into INTERFACE_LINK_LIBRARIES which could point to temporary build directories. Pick-to: 6.4 6.3 6.2 Change-Id: I883fd8f652e4d9ecd7d8e0076d62f5c7f4e14ec9 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Make sockets' accept() methods return qintptrMårten Nordheim2022-08-2410-19/+19
| | | | | | | | | | | Not necessarily relevant outside windows, where the socket descriptor is SOCKET (= unsigned 64-bit). Also follow their recommendation to not compare to -1, but rather to INVALID_SOCKET. Pick-to: 6.4 6.3 6.2 Change-Id: I0cfa4dfd9e147469132e2e72de22b30eab01e15c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Doc: Remove "Container keywords" section from containers.htmlKai Köhne2022-08-241-23/+1
| | | | | | | | | | | For foreach, we just mention that it is deprecated, and forever is not actually directly related to Qt containers. Both macros are also documented in qglobal.cpp, and the section title is not referenced anywhere so this patch won't break any links. Pick-to: 6.4 Change-Id: I6c3e11b205237e5b502173f2216606adf5812f55 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Doc: Remove qmake-only reference in Q_IMPORT_PLUGIN descriptionKai Köhne2022-08-242-9/+3
| | | | | | | | | | The Static Plugins page describes handling of qmake and CMake already in greater detail. No need to replicate it here. Pick-to: 6.4 Task-number: QTBUG-88044 Change-Id: I2cae85c0b0d20585b563bab9e263121181adeb8c Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Doc: Generalize info about -rdynamic to be not qmake specificKai Köhne2022-08-241-1/+4
| | | | | | | Pick-to: 6.4 Fixes: QTBUG-88044 Change-Id: I079cb75b5a5c32e38dec73474c967cc836d94b68 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Doc: Remove mentioning of variadic macrosKai Köhne2022-08-241-2/+1
| | | | | | | | | We don't support compilers without variadic macros anymore; the check in code was removed already in commit 4628e5cded8. Pick-to: 6.4 Change-Id: Ica4d0b2f7055e3d00ae780e23eb4e5a9d2dcc191 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Unstringify QStandardPaths Android partsJuha Vuolle2022-08-241-14/+11
| | | | | | | | | Qt 6.4 introduced new facilities to reduce the plain strings with Android methods/signatures. Fixes: QTBUG-104186 Change-Id: Id01f26aff253b096054f9fd6d062cebce94fdb50 Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
* Remove unneeded Q_DECLARE_SHARED_IMPLSona Kurazyan2022-08-241-3/+2
| | | | | | | | | | After d06a686cad63474ddb2dfe4a4118c923c805e290, Q_DECLARE_SHARED_IMPL is used only in Q_DECLARE_TYPEINFO, so remove the indirection through Q_DECLARE_TYPEINFO_IMPL. Change-Id: Ida188053c4ea512e9ebdf04f807f86a6159f8425 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Resolve window focusing problems on WASMMikolaj Boc2022-08-245-21/+17
| | | | | | | | | | | | - Moved the modal window resolution to QWasmWindow::requestActivateWindow so that multiple async activation events are not issued in unpredictable patterns. - Request activation on added windows and on stack top in case of window removal Pick-to: 6.4 Change-Id: I6f02cf1b7e83abb7961caf311ffc83e91c8bf810 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
* Rearrange mapLocalTime() so its millis always have the right signEdward Welbourne2022-08-241-11/+12
| | | | | | | | | | | Doing a simple division to get seconds, before using rounding-down division to get days and positive seconds, saves the need to check for seconds and millis in opposite directions that might cause a needless overflow when computing the final result. Change-Id: Ia4f95bb0510eb4f2c1f9131a34d317bd41bbed2a Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* Make QHeaderView restore state from different stream versionsAxel Spoerl2022-08-241-14/+28
| | | | | | | | | | | | | | | | | | | If restoring a QHeaderView state from a data stream with version Qt_5_0, check alignment and resize mode properites for out-of-bound values. If out of bounds, try QDataStream version Qt_6_0, which is used by KDE apps compiled with 5.15.2 or 6.2.3. QFileDialog stores settings in the same settings file across different Qt versions, using different QDataStream versions. That makes QFileDialog vulnerable to the issue (QTBUG-104962). A respective auto test is added with this patch. Fixes: QTBUG-104962 Pick-to: 6.4 6.3 6.2 Task-number: QTBUG-104425 Change-Id: I666207fca7ab837ad27a247e504a40757ee8afab Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* CMake: Fix Android build for CMake < 3.19Joerg Bornemann2022-08-241-4/+5
| | | | | | | | | | | The Android build used cmake_language(DEFER) and guarded with a check for CMake's version being >= 3.18. However, cmake_language(DEFER) was introduced in CMake 3.19. Fix that version check. Fixes: QTBUG-105841 Pick-to: 6.3 6.4 Change-Id: Ic318c104cf212de4c97c5a89b73536609826fd5b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Account for dark system themes in qt_fusionPaletteMitch Curtis2022-08-242-42/+43
| | | | | | | | | | | | | | | | | | | | | | | On Ubuntu (Gnome), the Fusion style didn't account for when a dark theme was set in the system's settings. Neither QGtk3Theme, nor QGnomeTheme (which it derives from) provide a palette() implementation, so they'd fall back to QPlatformTheme's. This default implementation calls QPlatformThemePrivate::initializeSystemPalette(), which uses qt_fusionPalette(). This patch accounts for QPlatformTheme::appearance() in qt_fusionPalette(), adjusting the palette roles accordingly to look correct when run under a dark theme. This also fixes the same issue for the Fusion style in Qt Quick Controls. Fixes: QTBUG-90504 Task-number: QTBUG-99276 Pick-to: 6.4 Change-Id: Id096bf809ef7a63dc440b5a68283e123173e917e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Disable resizing only when explicitly askedMikolaj Boc2022-08-241-3/+2
| | | | | | | | | Do not assume that popups are unconditionally non-resizable. Only disallow resizing if explicitly asked by minimum/maximum size match. Change-Id: Ia8e3e4d074e4dc24b0ae4be56858e0d833eeebdb Pick-to: 6.4 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
* Implement the batch_tests featureMikolaj Boc2022-08-2410-1/+185
| | | | | | | | | | | | | | | | | | | | | | | | | | An approach of test batching (joining multiple tests into a single binary) has been taken, due to long linking times/binary size on certain platforms, including WASM. This change adds a new feature 'batch_test_support' in Qt testlib. Based on the value of the feature, test batching may become enabled with the -batch-tests switch. Batching works for every target added via qt_internal_add_test. When first such target is being processed, a new combined target for all of the future test sources is created under the name of 'test_batch'. CMake attempts to merge the parameters of each of the tests, and some basic checks are run for parameter differences that are impossible to reconcile. On the C++ level, convenience macros instantiating the tests are redefined when batch_tests is on. The new, changed behavior triggered by the changes in the macros registers the tests in a central test registry, where they are available for execution based solely on their test name. The test name is interoperable with the names CMake is aware of, so CTest is able to run the tests one by one in the combined binary. Task-number: QTBUG-105273 Change-Id: I2b6071d58be16979bd967eab2d405249f5a4e658 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Remove QT_MODULE defineSona Kurazyan2022-08-241-2/+0
| | | | | | | This doesn't seem to be used in any of the modules. Change-Id: I5c007f50bdd9f5ed5f512606a0d4599593c6b40e Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Move Q_AUTOTEST_EXPORT to qtconfigmacros.hSona Kurazyan2022-08-242-21/+20
| | | | | | | | | The include statements for qconfig*.h can now be moved there too. Task-number: QTBUG-99313 Change-Id: I65f564fc48b9074861b0f8b50046062c2e83090c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Change the license of all CMakeLists.txt and *.cmake files to BSDLucie Gérard2022-08-23165-165/+165
| | | | | | | Task-number: QTBUG-105718 Change-Id: I5d3ef70a31235868b9be6cb479b7621bf2a8ba39 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Unstringify QTimeZone Android partsJuha Vuolle2022-08-231-20/+29
| | | | | | | | | | Qt 6.4 introduced new facilities to reduce the plain strings with Android methods/signatures. Fixes: QTBUG-104187 Change-Id: I94fc336f253e4969ac96ebcba5c1423989b340ab Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
* Remove the dead drawShadePanel in qwasmcompositorMikolaj Boc2022-08-232-73/+0
| | | | | | | | The method is not used anywhere. Remove it to save tens of LOCs. Change-Id: Id853d12d238aa30eb197ab3fed7ccc24a2213e31 Pick-to: 6.4 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
* Revert Q_DECLARE_EXPORTED_LOGGING_CATEGORY in tst_qdockwidgetAxel Spoerl2022-08-231-1/+1
| | | | | | | | Q_DECLARE_EXPORTED_LOGGING_CATEGORY is available from 6.5 only, hence cherrypicking this solution fails. Change-Id: Ib3351a8846bb5cf6047cd2d13c9f7cd242df9c93 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Doc: Format certain operators in textPaul Wicking2022-08-2314-91/+91
| | | | | | | | | | Use correct text formatting; this ensures e.g. the decrement operator isn't converted to an en dash in the docs. Apply to increment operator docs also for consistency. Task-number: QTBUG-105729 Change-Id: I5f126b90bc1d1b91d86e1f87c9b17a583841adb6 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* rhi: metal: Update out-of-date internal commentsLaszlo Agocs2022-08-231-9/+12
| | | | | | | | | Would have been nice to provide a flag to set the METAL_DEVICE_WRAPPER_TYPE env.var. but apparently it needs to be set very early, the QRhi just cannot do it, it's too late to qputenv then. So just update the internal docs. Change-Id: I94926debe3af73b67018c5449d7893df38f31f0d Reviewed-by: Andy Nichols <andy.nichols@qt.io>
* [docs] QAnyStringView: remove the prediction that Qt 7 will drop L1Marc Mutz2022-08-231-3/+5
| | | | | | | | | | | | | | | | | UTF-8 can never replace Latin-1 as the go-to US-ASCII superset, because, as a variable-length encoding, it cannot use the important size check in equality comparisons with UTF-16 to avoid having to iterate the whole string data. Mention that. UTF-8 only makes sense in a UTF-8-only environment where the size check works again. As long as our preferred charset is UTF-16, Latin-1 must be the preferred US-ASCII wrapper. Pick-to: 6.4 6.3 6.2 Change-Id: Ibe52cfc0c9fce0e7aaacd4cd8d6361e8d8bdee3d Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* QCocoaDrag: don't add pasteboard items with non-absolute URLsTimur Pocheptsov2022-08-231-0/+6
| | | | | | | | | | | | | AppKit rejects them and we end up with inconsistent number of pasteboard items and drag images: "NSURLs written to the pasteboard via NSPasteboardWriting must be absolute URLs." "There are 1 items on the pasteboard, but 2 drag images." Fixes: QTBUG-105711 Pick-to: 6.4 6.3 6.2 5.15 Change-Id: I7b1bc99f6e0b2b304f92f69125fb6af4ab5e303f Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* QSystemLibrary: Cache the system directory pathYuhang Zhao2022-08-231-9/+11
| | | | | | | | | | The system directory path won't change during the lifetime of the application, so cache it to avoid querying it for multiple times. Change-Id: I302285794d491d581d74a93e7ba9affc6379c681 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* QSystemLibrary: Use in-class initializationYuhang Zhao2022-08-231-7/+4
| | | | | | | | Initialize the member variables in class. It's more modern and also saves some typing in some constructor functions. Change-Id: Ib4d942610a57e0af3f22248c00207d7cdb683763 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* Fix build without highdpiscaling featureIlya Fedin2022-08-231-0/+3
| | | | | | | Fixes: QTBUG-104925 Pick-to: 6.4 Change-Id: Ieb5dd2194c54a61733c427c8a0ddf7576147d6ea Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* QProcess/docs: add more information about environment variablesThiago Macieira2022-08-221-7/+44
| | | | | | | | Fixes: QTBUG-42500 Pick-to: 6.4 Change-Id: Ie4bb662dcb274440ab8bfffd170a6a56977ef8b9 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Ievgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io>
* Mac: close popups opened on inactive application on relevant user actionVolker Hilsheimer2022-08-223-1/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On macOS, users can right-click into an inactive application to open a context menu without activating the application. Qt handles a number of events to close open popups (window deactivating or a mouse press outside the popup), but none of those will get called when the application is already inactive. So the popup might stay open (and on top of the window stack) when the user clicks into other applications, or activates another window. To fix this we need to watch for events outside of the Qt application on which we need to close the popup: when the user presses a mouse button, or activates another application using Cmd-Tab. But we don't want to monitor for key events, as that requires user permission. Use a global event monitor to watch for mouse presses, and an notification observer to watch for application activations, and respond by closing all popups (and removing the monitor and observer again). Use the monitor as well to watch for mouse moves, and pass only those events through the Qt event system so that mouse tracking in the menu works even if the application is inactive. This change brings back a version of the global event monitor we had in Qt 5.15. However, a press into our own menu will trigger the activation observer after the application became active, which would now close the menu. We don't want that, so we also need to remove the observer when the application becomes active (which makes sense anyway, as we will get regular events from then on). Pick-to: 6.4 6.3 6.2 Fixes: QTBUG-105474 Change-Id: I18573fcda09a46c27730bd670a795f4d467aab01 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Mac: close popups when the user clicks into the menubarVolker Hilsheimer2022-08-221-0/+7
| | | | | | | | | | | | | Otherwise it is possible to have a context menu and a menu from the menu bar open at the same time. Native applications close the context menu, but also block the click into the title bar. This change only closes popups, the click goes through to the menubar. Pick-to: 6.4 6.3 6.2 Task-number: QTBUG-105474 Change-Id: I664c00eea83ba8fb43cc8a630d787f2d2b5b96ff Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Move PreselectFirstFileInDirectory theme hint from QGtk3Theme to QGnomeThemeIlya Fedin2022-08-222-2/+2
| | | | | | | | It doesn't use any gtk API, so can live in QGnomeTheme Pick-to: 6.4 Change-Id: Iff0391de6f01a03981f6e45b04fe9824fd2becfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Windows QPA: fix tree item discovery through UI AutomationAndré de la Rocha2022-08-221-19/+11
| | | | | | | | | | | | | | This change reverts a workaround for a compatibility issue with a Windows utility, which is no longer necessary with Qt6 and was in some cases preventing accessibility tools from discovering tree items. This reverts commit 1c55a6caf1fc2b8a73a9a756bcf6894c5d4e4398. Fixes: QTBUG-105814 Pick-to: 6.4 6.3 6.2 Change-Id: Id464da49704b6953affca2fa40acc03f1ffd05ac Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
* Add some more logging to QFontDatabaseTor Arne Vestbø2022-08-211-0/+7
| | | | | Change-Id: I5ac289cb7cb0beb842c403683681a739c44b26a1 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
* QSystemLibrary: Replace 0 with nullptrYuhang Zhao2022-08-212-7/+7
| | | | | | | Use modern C++ more. Change-Id: I8ba2a6e95187976b7e4077bb39f05eab04a8575f Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* [docs] QAnyStringView: mention automatic U8→L1 reclassificationMarc Mutz2022-08-211-0/+5
| | | | | | | | | | | | ...for US-ASCII literals. Amends eaabd0c5450ad849e24878d38dd05d5b23d7eec3. Pick-to: 6.4 Task-number: QTBUG-101014 Change-Id: Id0acccb9bf2dfb01bca93f62da634e8dfe299fbc Reviewed-by: Øystein Heskestad <oystein.heskestad@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* Fix int/qsizetype mismatches in data url supportMarc Mutz2022-08-211-2/+2
| | | | | | | | | | More int/qsizetype mismatches. Task-number: QTBUG-103525 Pick-to: 6.4 6.3 6.2 Change-Id: I30723b6f59fa62dd7096110458305da7573ad345 Reviewed-by: Mate Barany <mate.barany@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* Port QDir to qsizetype [1/3]: indexed to ranged loopsMarc Mutz2022-08-211-4/+4
| | | | | | | | | | | Indexed for loops are prone to int/qsizetype mismatches, so use ranged for loops where possible. Pick-to: 6.4 6.3 6.2 Task-number: QTBUG-103525 Change-Id: Ia3e97a6b2924f92d3f7fb1a7ae075b59188006e9 Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* QDir: fix non-idiomatic indexed loop countingMarc Mutz2022-08-211-1/+1
| | | | | | | | | | | | Counting backwards from two may be clever, and less to type, but it raised this code reader's eyebrows, so use the formulation everyone understands instead. Pick-to: 6.4 6.3 6.2 Task-number: QTBUG-103525 Change-Id: I9416539e552e78e4777a744405b0773a9df1f6d0 Reviewed-by: Mate Barany <mate.barany@qt.io> Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-09 16:46:35 +0000