summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuli Piippo <samuli.piippo@qt.io>2021-09-17 11:33:13 +0300
committerSamuli Piippo <samuli.piippo@qt.io>2021-09-22 16:11:45 +0300
commit27f7f769ba345d7899e4dc10b43a477ababbc99a (patch)
tree7d06d85617d8c857826dcafacc2d91d9718756b5
parentff74a32415ece9d882df096ef22323875e9a3be5 (diff)
CMake: use LIBRARIES in plugins
Fix CMake warnings caused by using PUBLIC_LIBRARIES in plugins. Plugins are not intended to be linked to. They should not have any public properties, but LIBRARIES instead of PUBLIC_LIBRARIES. Pick-to: 6.2 Change-Id: I35644c7ea97f03f26086c2ae5d2ea14a9e7a0a78 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
-rw-r--r--src/networksettings/CMakeLists.txt2
-rw-r--r--src/networksettings/networksettingsqml/CMakeLists.txt2
-rw-r--r--src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/networksettings/CMakeLists.txt b/src/networksettings/CMakeLists.txt
index 083b43f..daf0b30 100644
--- a/src/networksettings/CMakeLists.txt
+++ b/src/networksettings/CMakeLists.txt
@@ -27,7 +27,7 @@ qt_internal_add_module(NetworkSettings
-iconnmancommon.h # special case
INCLUDE_DIRECTORIES
connman
- PUBLIC_LIBRARIES
+ LIBRARIES
Qt::Core
Qt::DBus
Qt::Network
diff --git a/src/networksettings/networksettingsqml/CMakeLists.txt b/src/networksettings/networksettingsqml/CMakeLists.txt
index a2c8403..db3f58c 100644
--- a/src/networksettings/networksettingsqml/CMakeLists.txt
+++ b/src/networksettings/networksettingsqml/CMakeLists.txt
@@ -7,7 +7,7 @@ qt_internal_add_qml_module(networksettingsqml
QtQml
SOURCES
qnetworksettingsforeign.h qnetworksettingsforeign.cpp
- PUBLIC_LIBRARIES
+ LIBRARIES
Qt::Core
Qt::Qml
Qt::NetworkSettings
diff --git a/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt b/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt
index 410caea..d799013 100644
--- a/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt
+++ b/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt
@@ -16,7 +16,7 @@ qt_internal_add_qml_module(qtbuttonimageproviderplugin
SOURCES
plugin.cpp plugin_p.h
qtbuttonimageprovider.cpp qtbuttonimageprovider.h
- PUBLIC_LIBRARIES
+ LIBRARIES
Qt::Core
Qt::Gui
Qt::Qml