diff options
| author | Kai Koehne <kai.koehne@qt.io> | 2020-12-01 17:00:34 +0100 |
|---|---|---|
| committer | Kai Koehne <kai.koehne@qt.io> | 2020-12-03 08:13:29 +0100 |
| commit | ef6f66b06aa65a0481a215be15b9e2f1bf68ac58 (patch) | |
| tree | 7c1f1aa655a1d2e0df44d036a8f28a2d104fca04 /src/imports/controls/doc/snippets | |
| parent | 210763470afe9bfdf886d59b55ccb9965616dbd4 (diff) | |
Doc: Use explicit linkage with target_link_libraries
The Professional CMake book suggests always using explicit linkage with
target_link_libraries, so let's use that.
Whether to use PUBLIC or PRIVATE depends on the context. But let's
be conservative and advise on using PRIVATE by default.
Also prefer the versioned target name over the unversioned one.
Task-number: QTBUG-88935
Pick-to: 6.0
Change-Id: Icf96616e2229b48cd3304a84d45314e69b1e40a9
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'src/imports/controls/doc/snippets')
| -rw-r--r-- | src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake b/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake index 2e9d2f3f..5bbbcff5 100644 --- a/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake +++ b/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake @@ -1,4 +1,4 @@ #! [0] find_package(Qt6 COMPONENTS QuickControls2 REQUIRED) -target_link_libraries(mytarget Qt::QuickControls2) +target_link_libraries(mytarget PRIVATE Qt6::QuickControls2) #! [0] |