| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This patch updates the service framework code to use QRegularExpression
in place of QRegExp which is to be considered deprecated.
Task-number: QTBUG-72593
Change-Id: Ic1f464d7af1bc075ff004c0c4cb8425a83efa649
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
old, outdated and removed header.LGPL21 was used in some files. Replace
that with correct one (header.LGPL in src, headre.GPL-EXCEPT in tests
and header.BSD in examples).
Also remove unnesessary license files and add missing ones.
Change-Id: Ib021ae191316da379a01e355fe90fe39180f541b
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
|
|
|
|
|
|
|
|
| |
BSD-OLD and FDL-OLD were still used in some files. Fix those to use new
ones to be able to pass license tests in CI
Change-Id: I15665d24c0eaec574c3836ce6fdcaea1ea593434
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
|
|
|
|
|
|
|
|
| |
Use T::foo instead of static_cast<T*>(nullptr)->foo
to access the staticMetaObject of a T.
Change-Id: Ieef90dc2d21e938b3661f66703c8c9c2142b07d6
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Added explicit where it was missing. This is not a source-
incompatible change, because code that breaks by this is
a bug. Let's not have this sitting around in an LTS.
Change-Id: Ib360290b0d01d9690703945f4fbf7efe946c5a59
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
... or equivalent.
QtBase 5.6 headers already compile that way, so let the other
modules follow suit.
Required to change one misuse of reinterpret_cast into static_cast.
Task-number: QTBUG-45291
Change-Id: I8212182c7cd87302aeb16b0cca7e6b0e3ef6c0c6
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
| |
VS2013 rightfully complains that when calling the assignment operator, the
compiler generated one needs visibility to the private class. Since we don't
have that, we must explicitly define the assignment operator. This is binary
compatible and common practice.
Change-Id: Id2558908d0b2841f8dfb6da15cb2614470c4f215
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
| |
Some files had wrong licenses too.
Change-Id: I7f940d4a136d102cb2c7755702308938530158c4
Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
|
|
|
|
|
| |
Change-Id: Ie9ba1ca09620b55d99b65ac7dd9bf0fa9e29da56
Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
|
|
|
|
|
|
| |
Change-Id: I462c22b1c85dad6afa4c580af085cc08f822625d
Reviewed-by: Lorn Potter <lorn.potter@jollamobile.com>
Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
|
|
|
|
|
|
|
| |
Change-Id: I5b725fe7f0abfc85c3df7b06c96ec3a5fb54b934
Sanity-Review: Qt Sanity Bot <qt_sanitybot@qt-project.org>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
|
|
|
|
|
|
|
| |
remove trailing spaces & expand tabs
Change-Id: I7606f8c263e3660b307ac865090d11293e892598
Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
|
|
|
|
|
|
|
|
|
| |
Prior to this fix, method calls would only work if the method's
parameters were either just standard Qt types or just custom types.
Any combination would lead to a failure invoking the method.
Change-Id: I6f140767dfec1692ba7d766284f39916057cd017
Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
|
|
|
|
|
|
|
| |
qremoteserviceregister_dbus_p.h:151:22: error: private field 'connection' is not used [-Werror,-Wunused-private-field]
Change-Id: I445b478857e0807b468e5ba1daa92fa1c8c7d9da
Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
|
|
|
|
|
|
|
| |
No more JsonDB in QtSFW.
Change-Id: Ie2ffbd5e1beeae9058eec6133551ad8595c59b64
Reviewed-by: Lorn Potter <lorn.potter@jollamobile.com>
|
|
|
|
|
|
|
|
| |
qservicereply.h:95:9: error: declaration of ‘parent’ shadows a member of 'this' [-Werror=shadow]
qservicereply.h:112:5: error: declaration of ‘proxyObject’ shadows a member of 'this' [-Werror=shadow]
Change-Id: I697bb79fae7fbe77451f3652f5360fb79ba30373
Reviewed-by: Aaron McCarthy <mccarthy.aaron@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class method does not need to be virtual, since nothing is
deriving from it. If something ever does, then the destructor should
be virtual too, to avoid this warning:
qservicepackage.cpp:49:10: required from here
qshareddata.h:163:72: warning: deleting object of polymorphic class type ‘QServicePackagePrivate’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
Change-Id: I0e5ccc6edcb6a74e801edfbe73320cf5a0ece171
Reviewed-by: Aaron McCarthy <mccarthy.aaron@gmail.com>
|
|
|
|
|
|
|
|
| |
Change-Id: Id893f505be66103366d13b88cbb177d3bb401cc1
Reviewed-by: Andrew Stanley-Jones <asj@cban.com>
Reviewed-by: Tasuku Suzuki <stasuku@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
These macros were removed from Qt Core and they are no longer defined
causing qtsystems to fail to build.
Change-Id: I0e08e7a53f20a016e403d9022e349b25ba38a7ec
Reviewed-by: Andrew Stanley-Jones <asj@cban.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As "interface" is defined as struct in objbase.h on windows it either
should not be used as a variable or parameter name or undefed before.
(see CI failure in https://codereview.qt-project.org/#change,45321 )
As parts of QtSystems rely on other windows headers which need interface
defined as struct it cannot be 'undef'ed "globally". Thus "interface" is
replaced with proper values in files where it occurs.
Change-Id: I9f77df966c7243fbc06aea87be075bfbd9b05d4a
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Rainer Keller <rainer.keller@digia.com>
Reviewed-by: Cristiano di Flora <cristiano.diflora@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Change the default linux backend to unix when dbus isn't
present. This is a better backend to default to than
the localsocket backend since it doesn't spin the Qt
event loop.
Change-Id: I7af9bf588504ee82c8269a76a7cbd0ff123df042
Reviewed-by: Lincoln Ramsay
Reviewed-by: Jonas Rabbe <jonas.rabbe@gmail.com>
|
|
|
|
|
| |
Change-Id: Ic8ca7e4c48df42dad63bda87fc5d5ecb4cbd5410
Reviewed-by: Andrew Stanley-Jones <asj@cban.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix QString-construction from const char * returned by getenv,
(potential crash).
- Fix single character string constants.
- Integer truncation.
- Unused variables.
Change-Id: I245daa1eb68801227d42ae07681f8e640c1f55c0
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
|
|
|
|
|
|
|
|
| |
The global files now live in qtbase only, and are made available to the
other modules via the $QT_INSTALL_DOCS variable.
Change-Id: I776e3168e41e6ae2fe1ee3c3f0097482466bcb62
Reviewed-by: Jerome Pasion <jerome.pasion@digia.com>
|
|
|
|
|
|
|
|
|
| |
Change copyrights and license headers from Nokia to Digia
Change-Id: I7786bc90235877567a7f61fc5c82af8dc3ad28c8
Reviewed-by: Janne Anttila <janne.anttila@digia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
|
|
|
|
|
| |
Change-Id: I8f7389dac06dee984f79deec1b070b1c6d27604d
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
|
|
|
|
|
|
| |
Change-Id: I40c2efe22e373dec3c6e1e75bdd35da9be3ff0eb
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
|
|
|
|
|
| |
Change-Id: I98dd7cc723a8454724286dcfb4fefe989469034a
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
|
|
|
|
|
|
|
|
| |
When using fcntl use FD_CLOEXEC instead since it's supported
on all platforms.
Change-Id: I549d5ed684447a05c1dbabae6c0dc1f6cb1ad381
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
|
|
|
|
|
| |
Change-Id: I0fe4e04056396bfb6ba6fee77db017f2997fb1d6
Reviewed-by: Andrew Stanley-Jones <andrew.stanley-jones@nokia.com>
|
|
|
|
|
| |
Change-Id: I151398d0ca986649119d056404a8c1fc0d3d8add
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
|
|
|
|
|
|
|
|
|
| |
OSX does not allow the timeval.tv_usec to be greater than
1 million (1 second), so split the value between the usec
path and the second field.
Change-Id: I926c360aa91e5d5131e6b7099df808f29ac3c56a
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
|
|
|
|
|
|
|
|
|
| |
Update the backend include files and avoid using a linux
only pipe2. Also compile sfwlisten correctly and place
it in the right location.
Change-Id: I083c286a8ed2ca7bdba8f3025c2a66a9e0405a1a
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
|
|
|
|
|
|
|
|
|
| |
It was already doing this for Mac builds. Do it for all Unix builds now.
This way, we don't need a special code path, enabled for the CI system,
that allows tests to pass there that then fail on regular desktops.
Change-Id: I8b0bc61339a3d615c2703e7692927e03f5457101
Reviewed-by: Andrew Stanley-Jones <andrew.stanley-jones@nokia.com>
|
|
|
|
|
|
|
| |
Use the new, simpler QT_STATIC macro.
Change-Id: I44381e608d2b65388a6f395d08060b7972821d9d
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
|
|
| |
Apparently caused by
qtbase:b719bd498ee179f92bee174a622c7954ed542fd0.
Change-Id: Icd5fa7829ab76fb3e73ed717d50b7794da2fac6e
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
|
|
|
|
|
|
|
|
| |
QDataStream used to be defined through indirect inclusion (by way of
qpair.h). Instead, include the header directly.
Change-Id: Ia178c13cdaaa9b3cb962b6afff991a3b4433af88
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
|
|
|
|
|
| |
Change-Id: I9d02220325bcf18a279710d830a468207b2ae551
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
|
|
| |
unused variable warning
fix a misspelling in a doc
Change-Id: Ib71fb28f471eae714375b649ab6393ce86d835fe
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
|
| |
If the Unix IPC backend is used and debug is off, we don't have QtNetwork
Change-Id: Idd5bfe08a98f19a2a39df5ec5893c699f0e803e5
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- load(qt_module) => load(qt_build_config)
- remove:
- CONFIG+=module (obsolete)
- code relating to module version headers (automated now)
- %mastercontent assignment (automated now)
- QT_BUILD_*_LIB defines (automated now)
- pointless QPRO_PWD assignments
- pointless DEFINES+=QT_MAKEDLL
Change-Id: I062c0bbe4bb69c2952f35b6bd6628770c0bc9446
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
| |
Change-Id: If491cb14a1829baf84769c8425144e7848604c37
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
| |
Change-Id: I6bafddeb11e764d17c5e9d9147c4e60da59c80a7
Reviewed-by: Andrew Stanley-Jones <andrew.stanley-jones@nokia.com>
|
|
|
|
|
| |
Change-Id: Ied629f52b278241e2007491175ba338698bae5bc
Reviewed-by: Andrew Stanley-Jones <andrew.stanley-jones@nokia.com>
|
|
|
|
|
|
|
|
|
|
| |
Allow the backend to be selected on the qmake command line,
which allows for easier testing. Use by specifiying
SFW_BACKEND=unix, localsocket or dbus.
Change-Id: I699737a7d2c97b564ebb5dc6b6d7c87dec8b6eb5
Reviewed-by: Zsolt Simon <zsolt.simon@nokia.com>
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
| |
Change-Id: I458578c85afc01e21a7a3b114c46cea3d0d0bc4f
Reviewed-by: Zsolt Simon <zsolt.simon@nokia.com>
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
|
|
|
|
|
|
|
|
|
| |
If sfwlisten listens on several interfaces it could crash
since the QUdpSocket was delete.
Change-Id: I0a91a98477b70fa01ac2493a5f7ac1915498bc73
Reviewed-by: Zsolt Simon <zsolt.simon@nokia.com>
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
|
|
|
|
|
|
|
| |
Also, have the copy constructor avoid double-initialization of members.
Change-Id: If2130c5dc51a0b371822f0c27673467b82be36ab
Reviewed-by: Andrew Stanley-Jones <andrew.stanley-jones@nokia.com>
|
|
|
|
|
| |
Change-Id: Ic9c49710b546dbec89ba2e4e0eef77ab92030553
Reviewed-by: Andrew Stanley-Jones <andrew.stanley-jones@nokia.com>
|
|
|
|
|
| |
Change-Id: I74f7513b2492308369cc6acbe77d928325f82de8
Reviewed-by: Andrew Stanley-Jones <andrew.stanley-jones@nokia.com>
|