QPdfSearchResult: std::move ctor arguments

The ctor is a perfect sink for the arguments, and already took them by
value. What was missing was to std::move them into place instead of
using the copy ctor.

Change-Id: I3a708bea2cdd8417ea3e604af2850d99a5966c3f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>

2 files changed, 10 insertions, 5 deletions

diff --git a/src/pdf/qpdfsearchresult.cpp b/src/pdf/qpdfsearchresult.cpp
index 2a3bf4dad..026b06dec 100644
--- a/src/pdf/qpdfsearchresult.cpp
+++ b/src/pdf/qpdfsearchresult.cpp
@@ -45,8 +45,13 @@ QT_BEGIN_NAMESPACE
 QPdfSearchResult::QPdfSearchResult() :
     QPdfSearchResult(new QPdfSearchResultPrivate()) { }
 
-QPdfSearchResult::QPdfSearchResult(int page, QList<QRectF> rects, QString contextBefore, QString contextAfter) :
-    QPdfSearchResult(new QPdfSearchResultPrivate(page, rects, contextBefore, contextAfter)) { }
+QPdfSearchResult::QPdfSearchResult(int page, QList<QRectF> rects,
+                                   QString contextBefore, QString contextAfter)
+    : QPdfSearchResult(new QPdfSearchResultPrivate(page, std::move(rects),
+                                                   std::move(contextBefore),
+                                                   std::move(contextAfter)))
+{
+}
 
 QPdfSearchResult::QPdfSearchResult(QPdfSearchResultPrivate *d) :
     QPdfDestination(static_cast<QPdfDestinationPrivate *>(d)) { }
diff --git a/src/pdf/qpdfsearchresult_p.h b/src/pdf/qpdfsearchresult_p.h
index 5b6c5f959..2ad25aa6a 100644
--- a/src/pdf/qpdfsearchresult_p.h
+++ b/src/pdf/qpdfsearchresult_p.h
@@ -63,9 +63,9 @@ public:
     QPdfSearchResultPrivate() = default;
     QPdfSearchResultPrivate(int page, QList<QRectF> rects, QString contextBefore, QString contextAfter) :
         QPdfDestinationPrivate(page, rects.first().topLeft(), 0),
-        contextBefore(contextBefore),
-        contextAfter(contextAfter),
-        rects(rects) {}
+        contextBefore{std::move(contextBefore)},
+        contextAfter{std::move(contextAfter)},
+        rects{std::move(rects)} {}
 
     QString contextBefore;
     QString contextAfter;