summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2021-01-12 15:22:30 +0100
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2021-01-12 16:21:01 +0000
commitf1f763cf3c7254406b7b6f01551b6624210bb834 (patch)
tree0eb56d1d0ad188b3ac8b98aeae684bb175361b09
parent1e1b0ef36a23e1c2cc6b2b45aa67a5a07dae64bc (diff)
Fix leak in QQuickWebEngineViewPrivate::contextMenuRequested
Change-Id: Idb41daa68709c769330527a713689241ac073359 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
-rw-r--r--src/webengine/api/qquickwebengineview.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/webengine/api/qquickwebengineview.cpp b/src/webengine/api/qquickwebengineview.cpp
index 7b875bf55..a0395f1c1 100644
--- a/src/webengine/api/qquickwebengineview.cpp
+++ b/src/webengine/api/qquickwebengineview.cpp
@@ -235,7 +235,6 @@ void QQuickWebEngineViewPrivate::contextMenuRequested(const WebEngineContextMenu
m_contextMenuData = data;
- QQuickWebEngineContextMenuRequest *request = new QQuickWebEngineContextMenuRequest(data);
QQmlEngine *engine = qmlEngine(q);
// TODO: this is a workaround for QTBUG-65044
@@ -243,6 +242,7 @@ void QQuickWebEngineViewPrivate::contextMenuRequested(const WebEngineContextMenu
return;
// mark the object for gc by creating temporary jsvalue
+ QQuickWebEngineContextMenuRequest *request = new QQuickWebEngineContextMenuRequest(data);
engine->newQObject(request);
Q_EMIT q->contextMenuRequested(request);