|author||Jocelyn Turcotte <email@example.com>||2014-02-28 11:27:02 +0100|
|committer||The Qt Project <firstname.lastname@example.org>||2014-03-07 18:19:19 +0100|
Deploy QtWebEngineCore as a Qt module
This delegates the linking step from ninja to qmake so that we can let qmake decide the destination of the target itself, easing the deployment and installation logic across platforms. The module is only deployed as a binary and no header are available outside of the source tree. This is only to make sure that the dependence of the QtWebEngine and QtWebEngineWidgets libraries on it is resolved at runtime exactly the same way as with other Qt modules, on all platforms. Ninja still takes care of the compilation and gyp lets qmake know how and what to link by dumping the list of flags and input files in a generated .pri file. This has to be done in a separate .pro file so that we can make sure that ninja is run inconditionally before make reaches the dependency check in core_module.pro, ensured by the parent Makefile. Note 1: This patch removes RPATH hacks that are no longer necessary Note 2: Other targets like ffmpegsumo are still linked by ninja. The same logic could be moved to a qmake file but this require some more work to make sure that some switches (e.g. -stdlib=libc++) are coordinated between gyp and qmake. Change-Id: If65968547bde5b9cf732e31e97931c17ae1921a7 Reviewed-by: Zoltan Arvai <email@example.com> Reviewed-by: Andras Becsi <firstname.lastname@example.org>
Diffstat (limited to 'qtwebengine.pro')
1 files changed, 4 insertions, 8 deletions
diff --git a/qtwebengine.pro b/qtwebengine.pro
index c3e56fe8e..366446c7a 100644
@@ -1,12 +1,8 @@
-# Examples will only be able to find libQt5WebEngineCore.so if the proper RPATH was set on libQt5WebEngineWidgets.so
-# Arch Linux disables RPATH for security reasons.
- # As long as we are a module separate from the rest of Qt, we want to unconditionally build examples.
- # Once part of Qt 5, this should be removed and we should respect the Qt wide configuration.
- QTWEBENGINE_BUILD_PARTS = $$QT_BUILD_PARTS
- QTWEBENGINE_BUILD_PARTS *= examples
+# As long as we are a module separate from the rest of Qt, we want to unconditionally build examples.
+# Once part of Qt 5, this should be removed and we should respect the Qt wide configuration.
+QTWEBENGINE_BUILD_PARTS = $$QT_BUILD_PARTS
+QTWEBENGINE_BUILD_PARTS *= examples