Fix all GCC and Clang warnings

Fix all warnings save for -Wdeprecated-declarations in tests.

Warnings from GCC 9.2.0:

  src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23:
    warning: variable 'resource_root_relative_path' set but not used
    [-Wunused-but-set-variable]

  src/core/chromium_overrides.cpp:121:21:
    warning: moving a local object in a return statement prevents copy elision
    [-Wpessimizing-move]

  src/core/render_widget_host_view_qt.cpp:540:12:
    warning: enumeration value 'kNull' not handled in switch [-Wswitch]
    warning: enumeration value 'kMiddlePanningVertical' not handled in switch
    [-Wswitch]
    warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch
    [-Wswitch]
    warning: enumeration value 'kDndNone' not handled in switch [-Wswitch]
    warning: enumeration value 'kDndMove' not handled in switch [-Wswitch]
    warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch]
    warning: enumeration value 'kDndLink' not handled in switch [-Wswitch]
    warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch]

  src/core/type_conversion.cpp:57:12:
    warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch
    [-Wswitch]

  src/core/api/qtbug-60565.cpp:83:6:
    warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)'
    alias between functions of incompatible types 'void(void*, const
    std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=]
  src/core/api/qtbug-60565.cpp:79:6:
    warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias
    between functions of incompatible types 'void(void*, const std::nothrow_t&)
    noexcept' and 'void(void*)' [-Wattribute-alias=]
  src/core/api/qtbug-60565.cpp:75:6:
    warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)'
    alias between functions of incompatible types 'void(size_t, const
    std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const
    std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned
    int)'} [-Wattribute-alias=]
  src/core/api/qtbug-60565.cpp:71:6:
    warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias
    between functions of incompatible types 'void(size_t, const std::nothrow_t&)
    noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'}
    and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=]

Warnings from Clang 9.0.1:

  src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29:
    warning: private field 'm_dispatcher' is not used [-Wunused-private-field]

  src/core/web_event_factory.cpp:1296:5:
    warning: unannotated fall-through between switch labels
    [-Wimplicit-fallthrough]

  src/core/compositor/compositor_resource_fence.h:55:81:
    warning: extra ';' after member function definition [-Wextra-semi]

  src/core/renderer/render_frame_observer_qt.h:81:10:
    warning: 'ReadyToCommitNavigation' overrides a member function but is not
    marked 'override' [-Winconsistent-missing-override]

  src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27:
    warning: private field 'guest_' is not used [-Wunused-private-field]

  src/core/chromium_overrides.cpp:121:12:
    warning: moving a local object in a return statement prevents copy elision
    [-Wpessimizing-move]
  src/core/chromium_overrides.cpp:145:64:
     warning: missing field 'set_up_command_line' initializer
     [-Wmissing-field-initializers]
  src/core/chromium_overrides.cpp:146:55:
     warning: missing field 'set_up_command_line' initializer
     [-Wmissing-field-initializers]

  src/core/render_widget_host_view_qt.cpp:540:13:
     warning: 7 enumeration values not handled in switch: 'kNull',
     'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch]

  src/core/compositor/stream_video_node.cpp:50:18:
     warning: 'updateState' overrides a member function but is not marked
     'override' [-Winconsistent-missing-override]
  src/core/compositor/stream_video_node.cpp:103:18:
     warning: 'initialize' overrides a member function but is not marked
     'override' [-Winconsistent-missing-override]

  src/core/type_conversion.cpp:57:13:
     warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in
     switch [-Wswitch]

  src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60:
     warning: extra ';' outside of a function is incompatible with C++98
     [-Wc++98-compat-extra-semi]

  tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10:
     warning: lambda capture 'this' is not used [-Wunused-lambda-capture]

  tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62:
     warning: lambda capture 'item' is not used [-Wunused-lambda-capture]

  tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55:
     warning: lambda capture 'this' is not used [-Wunused-lambda-capture]

Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>

1 files changed, 22 insertions, 6 deletions

diff --git a/src/core/api/qtbug-60565.cpp b/src/core/api/qtbug-60565.cpp
index be601b7e4..f48a2a701 100644
--- a/src/core/api/qtbug-60565.cpp
+++ b/src/core/api/qtbug-60565.cpp
@@ -68,20 +68,20 @@ void __ShimCppDeleteArray(void* address)
     SHIM_ALIAS_SYMBOL(ShimCppDeleteArray);
 
 __asm__(".symver __ShimCppNewNoThrow, _Znw" SIZE_T_MANGLING "RKSt9nothrow_t@Qt_5");
-void __ShimCppNewNoThrow(size_t size, const std::nothrow_t&) noexcept
-    SHIM_ALIAS_SYMBOL(ShimCppNew);
+void *__ShimCppNewNoThrow(size_t size, const std::nothrow_t&) noexcept
+    SHIM_ALIAS_SYMBOL(ShimCppNewNoThrow);
 
 __asm__(".symver __ShimCppNewArrayNoThrow, _Zna" SIZE_T_MANGLING "RKSt9nothrow_t@Qt_5");
-void __ShimCppNewArrayNoThrow(size_t size, const std::nothrow_t&) noexcept
-    SHIM_ALIAS_SYMBOL(ShimCppNewArray);
+void *__ShimCppNewArrayNoThrow(size_t size, const std::nothrow_t&) noexcept
+    SHIM_ALIAS_SYMBOL(ShimCppNewArrayNoThrow);
 
 __asm__(".symver __ShimCppDeleteNoThrow, _ZdlPvRKSt9nothrow_t@Qt_5");
 void __ShimCppDeleteNoThrow(void* address, const std::nothrow_t&) noexcept
-    SHIM_ALIAS_SYMBOL(ShimCppDelete);
+    SHIM_ALIAS_SYMBOL(ShimCppDeleteNoThrow);
 
 __asm__(".symver __ShimCppDeleteArrayNoThrow, _ZdaPvRKSt9nothrow_t@Qt_5");
 void __ShimCppDeleteArrayNoThrow(void* address, const std::nothrow_t&) noexcept
-    SHIM_ALIAS_SYMBOL(ShimCppDeleteArray);
+    SHIM_ALIAS_SYMBOL(ShimCppDeleteArrayNoThrow);
 
 static void* __shimCppNew(size_t size);
 static void* __shimCppNewArray(size_t size);
@@ -92,17 +92,33 @@ SHIM_HIDDEN void* ShimCppNew(size_t size) {
     return __shimCppNew(size);
 }
 
+SHIM_HIDDEN void* ShimCppNewNoThrow(size_t size, const std::nothrow_t&) noexcept {
+    return __shimCppNew(size);
+}
+
 SHIM_HIDDEN void* ShimCppNewArray(size_t size) {
     return __shimCppNewArray(size);
 }
 
+SHIM_HIDDEN void* ShimCppNewArrayNoThrow(size_t size, const std::nothrow_t&) noexcept {
+    return __shimCppNewArray(size);
+}
+
 SHIM_HIDDEN void ShimCppDelete(void* address) {
     __shimCppDelete(address);
 }
 
+SHIM_HIDDEN void ShimCppDeleteNoThrow(void* address, const std::nothrow_t&) noexcept {
+    __shimCppDelete(address);
+}
+
 SHIM_HIDDEN void ShimCppDeleteArray(void* address) {
     __shimCppDeleteArray(address);
 }
+
+SHIM_HIDDEN void ShimCppDeleteArrayNoThrow(void* address, const std::nothrow_t&) noexcept {
+    __shimCppDeleteArray(address);
+}
 } // extern "C"
 
 static void* __shimCppNew(size_t size) {