Do not extract download file names from certain url schemes

Chromium uses the default download file name if the scheme of
a file to download is either about or data, as the file name extraction
methods do not seems to work for those.

Mimic this behavior in Qt WebEngine as well.

Fixes: QTBUG-90355
Change-Id: I14b8c4f64559500d3f231dd26533a5947bf94bc3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

1 files changed, 5 insertions, 2 deletions

diff --git a/src/core/download_manager_delegate_qt.cpp b/src/core/download_manager_delegate_qt.cpp
index 1f6013cbb..f1ad1e677 100644
--- a/src/core/download_manager_delegate_qt.cpp
+++ b/src/core/download_manager_delegate_qt.cpp
@@ -162,8 +162,11 @@ bool DownloadManagerDelegateQt::DetermineDownloadTarget(download::DownloadItem *
     if (suggestedFilename.isEmpty())
         suggestedFilename = toQt(item->GetTargetFilePath().AsUTF8Unsafe());
 
-    if (suggestedFilename.isEmpty())
-        suggestedFilename = QUrl::fromPercentEncoding(toQByteArray(item->GetURL().ExtractFileName()));
+    if (suggestedFilename.isEmpty()) {
+        GURL itemUrl = item->GetURL();
+        if (!itemUrl.SchemeIs("about") && !itemUrl.SchemeIs("data"))
+            suggestedFilename = QUrl::fromPercentEncoding(toQByteArray(itemUrl.ExtractFileName()));
+    }
 
     if (suggestedFilename.isEmpty()) {
         suggestedFilename = QStringLiteral("qwe_download");