Refactor out ProfileIODataQt

Currently we can crash due to use-after-free of browser
context, it happens due to fact that resource context
has pointer to browser context which is destroyed on ui
thread, while resource context is destroyed on io thread.

We used url request getter to maintain objects destruction
on io thread. Refactor the code and create profile io data,
which will live on io thread, move all the objects
currently maintained by url request getter qt to newly
created class. Fix destruction order and remove references to
browser context from resource context.

Compared to url request getter, profile io data is not
ref counted class and uses weak pointer factory to handle
all "generate" requests.

Task-number: QTBUG-67865
Change-Id: Iee4fec854eda1c1600d26e991657d4877cbc966f
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>

1 files changed, 145 insertions, 0 deletions

diff --git a/src/core/profile_io_data_qt.h b/src/core/profile_io_data_qt.h
new file mode 100644
index 000000000..d29fefa24
--- /dev/null
+++ b/src/core/profile_io_data_qt.h
@@ -0,0 +1,145 @@
+/****************************************************************************
+**
+** Copyright (C) 2018 The Qt Company Ltd.
+** Contact: https://www.qt.io/licensing/
+**
+** This file is part of the QtWebEngine module of the Qt Toolkit.
+**
+** $QT_BEGIN_LICENSE:LGPL$
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and The Qt Company. For licensing terms
+** and conditions see https://www.qt.io/terms-conditions. For further
+** information use the contact form at https://www.qt.io/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 3 as published by the Free Software
+** Foundation and appearing in the file LICENSE.LGPL3 included in the
+** packaging of this file. Please review the following information to
+** ensure the GNU Lesser General Public License version 3 requirements
+** will be met: https://www.gnu.org/licenses/lgpl-3.0.html.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 2.0 or (at your option) the GNU General
+** Public license version 3 or any later version approved by the KDE Free
+** Qt Foundation. The licenses are as published by the Free Software
+** Foundation and appearing in the file LICENSE.GPL2 and LICENSE.GPL3
+** included in the packaging of this file. Please review the following
+** information to ensure the GNU General Public License requirements will
+** be met: https://www.gnu.org/licenses/gpl-2.0.html and
+** https://www.gnu.org/licenses/gpl-3.0.html.
+**
+** $QT_END_LICENSE$
+**
+****************************************************************************/
+
+#ifndef PROFILE_IO_DATA_QT_H
+#define PROFILE_IO_DATA_QT_H
+
+#include "browser_context_adapter.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/custom_handlers/protocol_handler_registry.h"
+#include "services/proxy_resolver/public/interfaces/proxy_resolver.mojom.h"
+#include <QtCore/QString>
+#include <QtCore/QPointer>
+#include <QtCore/QMutex>
+
+namespace net {
+class DhcpProxyScriptFetcherFactory;
+class HttpAuthPreferences;
+class HttpNetworkSession;
+class NetworkDelegate;
+class ProxyConfigService;
+class URLRequestContext;
+class URLRequestContextStorage;
+class URLRequestJobFactoryImpl;
+}
+
+namespace QtWebEngineCore {
+
+class ProfileQt;
+
+// ProfileIOData contains data that lives on the IOthread
+// we still use shared memebers and use mutex which breaks
+// idea for this object, but this is wip.
+
+class ProfileIODataQt {
+
+public:
+    ProfileIODataQt(ProfileQt *profile); // runs on ui thread
+    virtual ~ProfileIODataQt();
+
+    content::ResourceContext *resourceContext();
+    net::URLRequestContext *urlRequestContext();
+    void initializeOnIOThread();
+    void initializeOnUIThread(); // runs on ui thread
+    void shutdownOnUIThread(); // runs on ui thread
+
+    void cancelAllUrlRequests();
+    void generateAllStorage();
+    void generateStorage();
+    void generateCookieStore();
+    void generateHttpCache();
+    void generateUserAgent();
+    void generateJobFactory();
+    void regenerateJobFactory();
+
+    void setRequestContextData(content::ProtocolHandlerMap *protocolHandlers,
+                               content::URLRequestInterceptorScopedVector request_interceptors);
+    void setFullConfiguration(); // runs on ui thread
+    void updateStorageSettings(); // runs on ui thread
+    void updateUserAgent(); // runs on ui thread
+    void updateCookieStore(); // runs on ui thread
+    void updateHttpCache(); // runs on ui thread
+    void updateJobFactory(); // runs on ui thread
+    void updateRequestInterceptor(); // runs on ui thread
+
+private:
+    ProfileQt *m_profile;
+    std::unique_ptr<net::URLRequestContextStorage> m_storage;
+    std::unique_ptr<net::NetworkDelegate> m_networkDelegate;
+    std::unique_ptr<content::ResourceContext> m_resourceContext;
+    std::unique_ptr<net::URLRequestContext> m_urlRequestContext;
+    std::unique_ptr<net::HttpNetworkSession> m_httpNetworkSession;
+    std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory> m_protocolHandlerInterceptor;
+    std::unique_ptr<net::DhcpProxyScriptFetcherFactory> m_dhcpProxyScriptFetcherFactory;
+    std::unique_ptr<net::HttpAuthPreferences> m_httpAuthPreferences;
+    std::unique_ptr<net::URLRequestJobFactory> m_jobFactory;
+    base::WeakPtr<ProfileIODataQt> m_weakPtr;
+    scoped_refptr<CookieMonsterDelegateQt> m_cookieDelegate;
+    content::URLRequestInterceptorScopedVector m_requestInterceptors;
+    content::ProtocolHandlerMap m_protocolHandlers;
+    proxy_resolver::mojom::ProxyResolverFactoryPtr m_proxyResolverFactory;
+    net::URLRequestJobFactoryImpl *m_baseJobFactory = nullptr;
+    QAtomicPointer<net::ProxyConfigService> m_proxyConfigService;
+    QPointer<BrowserContextAdapter> m_browserContextAdapter; // never dereferenced in IO thread and it is passed by qpointer
+    BrowserContextAdapter::PersistentCookiesPolicy m_persistentCookiesPolicy;
+    QString m_cookiesPath;
+    QString m_channelIdPath;
+    QString m_httpAcceptLanguage;
+    QString m_httpUserAgent;
+    BrowserContextAdapter::HttpCacheType m_httpCacheType;
+    QString m_httpCachePath;
+    QList<QByteArray> m_customUrlSchemes;
+    QList<QByteArray> m_installedCustomSchemes;
+    QWebEngineUrlRequestInterceptor* m_requestInterceptor = nullptr;
+    QMutex m_mutex;
+    int m_httpCacheMaxSize = 0;
+    bool m_initialized = false;
+    bool m_updateAllStorage = false;
+    bool m_updateCookieStore = false;
+    bool m_updateHttpCache = false;
+    bool m_updateJobFactory = false;
+    bool m_updateUserAgent = false;
+    bool m_ignoreCertificateErrors = false;
+    base::WeakPtrFactory<ProfileIODataQt> m_weakPtrFactory; // this should be always the last member
+    friend class NetworkDelegateQt;
+    DISALLOW_COPY_AND_ASSIGN(ProfileIODataQt);
+};
+} // namespace QtWebEngineCore
+
+#endif // PROFILE_IO_DATA_QT_H