diff options
author | Allan Sandfeld Jensen <allan.jensen@theqtcompany.com> | 2015-01-22 11:30:24 +0100 |
---|---|---|
committer | Jocelyn Turcotte <jocelyn.turcotte@digia.com> | 2015-01-22 17:55:41 +0100 |
commit | 4c724c022664286191558803632d45cd28749ae4 (patch) | |
tree | 128ac4e844990fa1d85dfca446d54baf62918f7a /src/core/web_contents_adapter.cpp | |
parent | b6c905a0616f3ed22e553171ad4f5667c1250941 (diff) |
Improve geolocation permission security
Ensure we only grant permission to the origin the user replied to,
otherwise we might get a race exploit.
Change-Id: I4f737148f4e41432c160b81c324531e9cde0edc6
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Diffstat (limited to 'src/core/web_contents_adapter.cpp')
-rw-r--r-- | src/core/web_contents_adapter.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/web_contents_adapter.cpp b/src/core/web_contents_adapter.cpp index 3f6d7060c..d7dfcb97c 100644 --- a/src/core/web_contents_adapter.cpp +++ b/src/core/web_contents_adapter.cpp @@ -773,7 +773,7 @@ void WebContentsAdapter::grantMediaAccessPermission(const QUrl &securityOrigin, void WebContentsAdapter::runGeolocationRequestCallback(const QUrl &securityOrigin, bool allowed) { Q_D(WebContentsAdapter); - d->webContentsDelegate->m_lastGeolocationRequestCallback.Run(allowed); + d->webContentsDelegate->geolocationPermissionReply(securityOrigin, allowed); } void WebContentsAdapter::grantMouseLockPermission(bool granted) |