diff options
| author | Michal Klocek <michal.klocek@qt.io> | 2018-04-30 09:44:58 +0200 |
|---|---|---|
| committer | Michal Klocek <michal.klocek@qt.io> | 2018-05-18 10:49:35 +0000 |
| commit | 7d6f72463ef372aabf4c4e6f212b9d331ef1338a (patch) | |
| tree | dfc6f4cfc208170488bb415a259b71a7f3c399ae /src/core/web_contents_delegate_qt.cpp | |
| parent | 216f19d52ce9e920349da9247afc2c8e85df2c56 (diff) | |
Remove keeping browser context as shared pointer in web context adapter
In widgets we document that web contents can not out live browser
context ie. WebEngineProfile can not be deleted before WebEnginePage
which uses it.
In qml we can not be sure the order in which objects are garbage
collected. We used shared pointers to keep order of destruction.
Unfortunately shared pointers do not work well with corner cases,
and we added more and more code to deal with that (shutdown methods
+ qpointers wrapping qsharedpointers). In order to remove growing
complexity remove usage of shared pointers to keep strict deletion order.
Remove shared pointer from WebContentsAdapter and simply track the WebContents,
that is used by the given BrowserContext. Force deletion of webcontents first.
Change-Id: I05f886a0094d971b03f9a35e12c4b4672f0fe4ce
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Diffstat (limited to 'src/core/web_contents_delegate_qt.cpp')
0 files changed, 0 insertions, 0 deletions