diff options
author | Marc Mutz <marc.mutz@qt.io> | 2021-12-03 11:48:08 +0100 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2022-01-09 18:13:57 +0000 |
commit | 1451c1532c2a5b65b5cbc586adc0cb8dce5bf27a (patch) | |
tree | f5815060e53f0f9cbf6565f80c92905c16233cc5 /src/pdf/qpdfdestination.h | |
parent | d95f6a6b23e3052c39a32f50d6e604cf17e698e3 (diff) |
Un-export the value classes
Value classes should not be exported wholesale, because that makes
inline function part of the ABI on Windows debug builds, severely
restricting what we can do to them going forward (e.g. removing).
De-inline the QPdfSearchResult dtor as a drive-by.
Fixes: QTBUG-98885
Pick-to: 6.3
Change-Id: If2a2c7bec2b99df7e33dfc008fd07e6edda5413c
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/pdf/qpdfdestination.h')
-rw-r--r-- | src/pdf/qpdfdestination.h | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/src/pdf/qpdfdestination.h b/src/pdf/qpdfdestination.h index efc283ade..e445f0e5a 100644 --- a/src/pdf/qpdfdestination.h +++ b/src/pdf/qpdfdestination.h @@ -50,27 +50,28 @@ QT_BEGIN_NAMESPACE class QPdfDestinationPrivate; -class Q_PDF_EXPORT QPdfDestination +class QPdfDestination { - Q_GADGET + Q_GADGET_EXPORT(Q_PDF_EXPORT) Q_PROPERTY(bool valid READ isValid) Q_PROPERTY(int page READ page) Q_PROPERTY(QPointF location READ location) Q_PROPERTY(qreal zoom READ zoom) public: - ~QPdfDestination(); - QPdfDestination(const QPdfDestination &other); - QPdfDestination &operator=(const QPdfDestination &other); + Q_PDF_EXPORT ~QPdfDestination(); + Q_PDF_EXPORT QPdfDestination(const QPdfDestination &other); + Q_PDF_EXPORT QPdfDestination &operator=(const QPdfDestination &other); - QPdfDestination(QPdfDestination &&other) noexcept; + Q_PDF_EXPORT QPdfDestination(QPdfDestination &&other) noexcept; QT_MOVE_ASSIGNMENT_OPERATOR_IMPL_VIA_MOVE_AND_SWAP(QPdfDestination) void swap(QPdfDestination &other) noexcept { d.swap(other.d); } - bool isValid() const; - int page() const; - QPointF location() const; - qreal zoom() const; + + Q_PDF_EXPORT bool isValid() const; + Q_PDF_EXPORT int page() const; + Q_PDF_EXPORT QPointF location() const; + Q_PDF_EXPORT qreal zoom() const; protected: QPdfDestination(); |