diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2022-03-23 10:57:45 +0100 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2022-03-24 12:53:52 +0100 |
| commit | 5740c3a3faf9401194b3f0d300bdf6b93ef7a5f1 (patch) | |
| tree | 491560c93c75137708936b8ce11b9ffa62a44462 /src/pdf | |
| parent | d9b982056d72adc62defd5e02365bb0fddeb8adf (diff) | |
QPdfDocumentRenderOptions: pass by cref where still possible
The object is quite large (16 for QRect + 8 for QSize + 4+4 for flags
= 32 bytes), and Clazy complains about passing it by value.
Fix at least for the relational operators, where, granted, it makes
least sense (them being inline). The other users are behind the ABI
wall, though.
Change-Id: I9a70d007cc1f90e3ee71d3522c02fd7efcbee6ba
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'src/pdf')
| -rw-r--r-- | src/pdf/qpdfdocumentrenderoptions.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/pdf/qpdfdocumentrenderoptions.h b/src/pdf/qpdfdocumentrenderoptions.h index 250efdc2f..ea30e61cc 100644 --- a/src/pdf/qpdfdocumentrenderoptions.h +++ b/src/pdf/qpdfdocumentrenderoptions.h @@ -65,7 +65,7 @@ public: constexpr void setScaledSize(const QSize &s) noexcept { m_scaledSize = s; } private: - friend constexpr inline bool operator==(QPdfDocumentRenderOptions lhs, QPdfDocumentRenderOptions rhs) noexcept; + friend constexpr inline bool operator==(const QPdfDocumentRenderOptions &lhs, const QPdfDocumentRenderOptions &rhs) noexcept; QRect m_clipRect; QSize m_scaledSize; @@ -78,14 +78,14 @@ private: Q_DECLARE_TYPEINFO(QPdfDocumentRenderOptions, Q_PRIMITIVE_TYPE); -constexpr inline bool operator==(QPdfDocumentRenderOptions lhs, QPdfDocumentRenderOptions rhs) noexcept +constexpr inline bool operator==(const QPdfDocumentRenderOptions &lhs, const QPdfDocumentRenderOptions &rhs) noexcept { return lhs.m_clipRect == rhs.m_clipRect && lhs.m_scaledSize == rhs.m_scaledSize && lhs.m_renderFlags == rhs.m_renderFlags && lhs.m_rotation == rhs.m_rotation && lhs.m_reserved == rhs.m_reserved && lhs.m_reserved2 == rhs.m_reserved2; // fix -Wunused-private-field } -constexpr inline bool operator!=(QPdfDocumentRenderOptions lhs, QPdfDocumentRenderOptions rhs) noexcept +constexpr inline bool operator!=(const QPdfDocumentRenderOptions &lhs, const QPdfDocumentRenderOptions &rhs) noexcept { return !operator==(lhs, rhs); } |