summaryrefslogtreecommitdiffstats
path: root/src/tools/qwebengine_convert_dict/main.cpp
diff options
context:
space:
mode:
authorJoerg Bornemann <joerg.bornemann@qt.io>2017-02-16 15:33:02 +0100
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2017-02-21 23:56:38 +0000
commit37206c2baf013b07cd26d416a8ab0db493d7d651 (patch)
tree5e66dea31e8ade60d7180c6122e74c038b78d367 /src/tools/qwebengine_convert_dict/main.cpp
parent905017117d38d799bc95d6cfdd0195b717b605b8 (diff)
Fix Q_ASSERT when dragging an item over WebEngineView
When dragging something over a WebEngineView we're waiting for the result of the asynchronous DragTargetDragOver using a RunLoop. The result will be delivered by a call to updateDragAction. The RunLoop will call MessagePumpForUIQt::Run which spins a QEventLoop. The QEventLoop will dispatch more posted QDragMoveEvent objects while we're handling the current QDragMoveEvent. This triggers a recursion guard's Q_ASSERT when dragging from a QtQuick item onto a WebEngineView. When waiting for the DragTargetDragOver result we're not interested in Qt events. Instead of using a RunLoop, implement a poor man's chromium event loop and actively wait for updateDragAction being called. In practice, no more than two iterations of the loop are run until updateDragAction is called. Therefore the extra CPU and sleep times are negligible. Task-number: QTBUG-58920 Change-Id: Icfdf9c680c4c9987ac3dbb41fbc3e1403af0fa9f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'src/tools/qwebengine_convert_dict/main.cpp')
0 files changed, 0 insertions, 0 deletions