diff options
author | Michal Klocek <michal.klocek@qt.io> | 2020-08-11 14:46:42 +0200 |
---|---|---|
committer | Michal Klocek <michal.klocek@qt.io> | 2020-08-28 13:40:00 +0200 |
commit | 1978e726a909ac945c32429e216c49ecad3ecb3a (patch) | |
tree | bf0cbbf13ba31f08b4552544122044ac6386fdf4 /src/webenginewidgets/api/qwebenginepage.h | |
parent | 08375ee796a545e3916feb24e0b35d561e6f0049 (diff) |
Improve QWebEngineCertificateError api
* remove const ref from QWebEngineCertificateError
Q_GADGET is a value type, QWebEngineCertificateError is pass
as const reference from api. This is not so useful since, in qml this
will be anyway copied and for c++ this is not useful since
reject, ignore, defer methods are all const. Therefore simply
pass it by value.
* make consistent naming defer(), acceptCertificate(), rejectCertificate()
* remove properties 'differed', 'answered' which are use internally,
user knows if he calls functions.
* error.errorDescription -> error.description()
* error.error() -> error.type()
[ChangeLog] In QWebEngineCertificateError use acceptCertificate()
instead of ignoreCertificiateError()
Change-Id: I9ffa500a0a455d98445b066252dd283872740731
Reviewed-by: Michael BrĂ¼ning <michael.bruning@qt.io>
Diffstat (limited to 'src/webenginewidgets/api/qwebenginepage.h')
-rw-r--r-- | src/webenginewidgets/api/qwebenginepage.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/webenginewidgets/api/qwebenginepage.h b/src/webenginewidgets/api/qwebenginepage.h index 199ba9e2e..102f36a30 100644 --- a/src/webenginewidgets/api/qwebenginepage.h +++ b/src/webenginewidgets/api/qwebenginepage.h @@ -375,7 +375,7 @@ protected: virtual bool javaScriptConfirm(const QUrl &securityOrigin, const QString& msg); virtual bool javaScriptPrompt(const QUrl &securityOrigin, const QString& msg, const QString& defaultValue, QString* result); virtual void javaScriptConsoleMessage(JavaScriptConsoleMessageLevel level, const QString& message, int lineNumber, const QString& sourceID); - virtual void certificateError(const QWebEngineCertificateError &certificateError); + virtual void certificateError(QWebEngineCertificateError certificateError); virtual bool acceptNavigationRequest(const QUrl &url, NavigationType type, bool isMainFrame); private: |