diff options
author | Pierre Rossi <pierre.rossi@theqtcompany.com> | 2015-06-11 14:06:13 +0200 |
---|---|---|
committer | Jani Heikkinen <jani.heikkinen@theqtcompany.com> | 2015-06-12 09:26:58 +0000 |
commit | 0b65f3ca378810d3b33345b99bf084124acf3e5f (patch) | |
tree | 3f2857dfd9c98498d8be92607a11a2a4f023ab41 /src/webenginewidgets/api/qwebengineprofile_p.h | |
parent | e0e74a0a9286bb92ae7e2e2395827538133d2bf0 (diff) |
Last minute API review cleanup
The getters in QWebEngineDownloadItem were not const.
The script collection in QWebEngineProfile was passed by reference,
which is not idiomatic of Qt.
Change-Id: I9b4218b407288b91a726a711bd2a7e1c1167d99a
Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
Diffstat (limited to 'src/webenginewidgets/api/qwebengineprofile_p.h')
-rw-r--r-- | src/webenginewidgets/api/qwebengineprofile_p.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/webenginewidgets/api/qwebengineprofile_p.h b/src/webenginewidgets/api/qwebengineprofile_p.h index b0bfc88b9..55941580d 100644 --- a/src/webenginewidgets/api/qwebengineprofile_p.h +++ b/src/webenginewidgets/api/qwebengineprofile_p.h @@ -43,6 +43,7 @@ #include "qwebenginescriptcollection.h" #include <QMap> #include <QPointer> +#include <QScopedPointer> namespace QtWebEngineCore { class BrowserContextAdapter; @@ -72,10 +73,10 @@ public: void removeUrlSchemeHandler(QWebEngineUrlSchemeHandler *); void clearUrlSchemeHandlers(); - QWebEngineScriptCollection scriptCollection; private: QWebEngineProfile *q_ptr; QWebEngineSettings *m_settings; + QScopedPointer<QWebEngineScriptCollection> m_scriptCollection; QExplicitlySharedDataPointer<QtWebEngineCore::BrowserContextAdapter> m_browserContextRef; QMap<quint32, QPointer<QWebEngineDownloadItem> > m_ongoingDownloads; QMap<QByteArray, QPointer<QWebEngineUrlSchemeHandler> > m_urlSchemeHandlers; |