Improve Q(Quick)WebEngineDownloadItem API

Implements suggestions from 5.14 API review:
- Replace QString with const QString &
- Extend documentation

Change-Id: I08365767128aa72bc7ef2356c761c2abe512e4eb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

2 files changed, 4 insertions, 4 deletions

diff --git a/src/webenginewidgets/api/qwebenginedownloaditem.cpp b/src/webenginewidgets/api/qwebenginedownloaditem.cpp
index e1bfc506f..724249208 100644
--- a/src/webenginewidgets/api/qwebenginedownloaditem.cpp
+++ b/src/webenginewidgets/api/qwebenginedownloaditem.cpp
@@ -588,7 +588,7 @@ QString QWebEngineDownloadItem::downloadDirectory() const
     download item's state.
 */
 
-void QWebEngineDownloadItem::setDownloadDirectory(QString directory)
+void QWebEngineDownloadItem::setDownloadDirectory(const QString &directory)
 {
     Q_D(QWebEngineDownloadItem);
     if (d->downloadState != QWebEngineDownloadItem::DownloadRequested) {
@@ -626,7 +626,7 @@ QString QWebEngineDownloadItem::downloadFileName() const
     download item's state.
 */
 
-void QWebEngineDownloadItem::setDownloadFileName(QString fileName)
+void QWebEngineDownloadItem::setDownloadFileName(const QString &fileName)
 {
     Q_D(QWebEngineDownloadItem);
     if (d->downloadState != QWebEngineDownloadItem::DownloadRequested) {
diff --git a/src/webenginewidgets/api/qwebenginedownloaditem.h b/src/webenginewidgets/api/qwebenginedownloaditem.h
index 169d80553..27fca6f8a 100644
--- a/src/webenginewidgets/api/qwebenginedownloaditem.h
+++ b/src/webenginewidgets/api/qwebenginedownloaditem.h
@@ -130,9 +130,9 @@ public:
     bool isSavePageDownload() const;
     QString suggestedFileName() const;
     QString downloadDirectory() const;
-    void setDownloadDirectory(QString directory);
+    void setDownloadDirectory(const QString &directory);
     QString downloadFileName() const;
-    void setDownloadFileName(QString fileName);
+    void setDownloadFileName(const QString &fileName);
 
     QWebEnginePage *page() const;