Fix all GCC and Clang warnings

Fix all warnings save for -Wdeprecated-declarations in tests.

Warnings from GCC 9.2.0:

  src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23:
    warning: variable 'resource_root_relative_path' set but not used
    [-Wunused-but-set-variable]

  src/core/chromium_overrides.cpp:121:21:
    warning: moving a local object in a return statement prevents copy elision
    [-Wpessimizing-move]

  src/core/render_widget_host_view_qt.cpp:540:12:
    warning: enumeration value 'kNull' not handled in switch [-Wswitch]
    warning: enumeration value 'kMiddlePanningVertical' not handled in switch
    [-Wswitch]
    warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch
    [-Wswitch]
    warning: enumeration value 'kDndNone' not handled in switch [-Wswitch]
    warning: enumeration value 'kDndMove' not handled in switch [-Wswitch]
    warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch]
    warning: enumeration value 'kDndLink' not handled in switch [-Wswitch]
    warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch]

  src/core/type_conversion.cpp:57:12:
    warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch
    [-Wswitch]

  src/core/api/qtbug-60565.cpp:83:6:
    warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)'
    alias between functions of incompatible types 'void(void*, const
    std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=]
  src/core/api/qtbug-60565.cpp:79:6:
    warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias
    between functions of incompatible types 'void(void*, const std::nothrow_t&)
    noexcept' and 'void(void*)' [-Wattribute-alias=]
  src/core/api/qtbug-60565.cpp:75:6:
    warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)'
    alias between functions of incompatible types 'void(size_t, const
    std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const
    std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned
    int)'} [-Wattribute-alias=]
  src/core/api/qtbug-60565.cpp:71:6:
    warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias
    between functions of incompatible types 'void(size_t, const std::nothrow_t&)
    noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'}
    and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=]

Warnings from Clang 9.0.1:

  src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29:
    warning: private field 'm_dispatcher' is not used [-Wunused-private-field]

  src/core/web_event_factory.cpp:1296:5:
    warning: unannotated fall-through between switch labels
    [-Wimplicit-fallthrough]

  src/core/compositor/compositor_resource_fence.h:55:81:
    warning: extra ';' after member function definition [-Wextra-semi]

  src/core/renderer/render_frame_observer_qt.h:81:10:
    warning: 'ReadyToCommitNavigation' overrides a member function but is not
    marked 'override' [-Winconsistent-missing-override]

  src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27:
    warning: private field 'guest_' is not used [-Wunused-private-field]

  src/core/chromium_overrides.cpp:121:12:
    warning: moving a local object in a return statement prevents copy elision
    [-Wpessimizing-move]
  src/core/chromium_overrides.cpp:145:64:
     warning: missing field 'set_up_command_line' initializer
     [-Wmissing-field-initializers]
  src/core/chromium_overrides.cpp:146:55:
     warning: missing field 'set_up_command_line' initializer
     [-Wmissing-field-initializers]

  src/core/render_widget_host_view_qt.cpp:540:13:
     warning: 7 enumeration values not handled in switch: 'kNull',
     'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch]

  src/core/compositor/stream_video_node.cpp:50:18:
     warning: 'updateState' overrides a member function but is not marked
     'override' [-Winconsistent-missing-override]
  src/core/compositor/stream_video_node.cpp:103:18:
     warning: 'initialize' overrides a member function but is not marked
     'override' [-Winconsistent-missing-override]

  src/core/type_conversion.cpp:57:13:
     warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in
     switch [-Wswitch]

  src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60:
     warning: extra ';' outside of a function is incompatible with C++98
     [-Wc++98-compat-extra-semi]

  tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10:
     warning: lambda capture 'this' is not used [-Wunused-lambda-capture]

  tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62:
     warning: lambda capture 'item' is not used [-Wunused-lambda-capture]

  tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55:
     warning: lambda capture 'this' is not used [-Wunused-lambda-capture]

Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>

1 files changed, 1 insertions, 1 deletions

diff --git a/tests/auto/widgets/loadsignals/tst_loadsignals.cpp b/tests/auto/widgets/loadsignals/tst_loadsignals.cpp
index c0bb8d5c5..20e5fbf0d 100644
--- a/tests/auto/widgets/loadsignals/tst_loadsignals.cpp
+++ b/tests/auto/widgets/loadsignals/tst_loadsignals.cpp
@@ -234,7 +234,7 @@ void tst_LoadSignals::fileDownloadDoesNotTriggerLoadSignals_qtbug66661()
     QTemporaryDir tempDir;
     QWebEngineDownloadItem::DownloadState downloadState = QWebEngineDownloadItem::DownloadRequested;
     connect(view->page()->profile(), &QWebEngineProfile::downloadRequested,
-        [this, &downloadState, &tempDir](QWebEngineDownloadItem* item){
+        [&downloadState, &tempDir](QWebEngineDownloadItem* item){
             connect(item, &QWebEngineDownloadItem::stateChanged, [&downloadState](QWebEngineDownloadItem::DownloadState newState){
                 downloadState = newState;
             });