diff options
| author | Kirill Burtsev <kirill.burtsev@qt.io> | 2021-09-15 13:57:50 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-09-21 14:10:39 +0000 |
| commit | 5fbf9cf0ca44678924ddd83db2a8dfa543c0f420 (patch) | |
| tree | 7d70c3808efa5fb00e69aa3631b3844c3d37a04a /tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp | |
| parent | daa6d1576b93e79b9e7724f0e1bcc5d993900fa6 (diff) | |
Ensure load in newly created page first before checking for UserAgent
Condition to use UserAgent override 'ShouldUseUserAgentOverride' is only
activated when DocumentLoader is set. This happen only after load, so
test should check that before checking UserAgent.
Task-number: QTBUG-76249
Change-Id: I3b966f8a2141ed656890ce922667e55be09c8676
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit e918a90f6c2166f753eb1516f115962968ef1cb4)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp')
| -rw-r--r-- | tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp index 84075a276..8a44af3fb 100644 --- a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp +++ b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp @@ -4625,6 +4625,7 @@ void tst_QWebEnginePage::customUserAgentInNewTab() QCOMPARE(evaluateJavaScriptSync(&page, QStringLiteral("navigator.userAgent")).toString(), expectedUserAgent); QTest::mouseClick(view.focusProxy(), Qt::LeftButton, {}, elementCenter(&page, "link")); QTRY_VERIFY(page.newPage); + QTRY_COMPARE(page.newPage->loadSpy.count(), 1); QTRY_VERIFY(!lastUserAgent.isEmpty()); QCOMPARE(lastUserAgent, expectedUserAgent); QCOMPARE(evaluateJavaScriptSync(page.newPage.get(), QStringLiteral("navigator.userAgent")).toString(), expectedUserAgent); @@ -4642,6 +4643,7 @@ void tst_QWebEnginePage::customUserAgentInNewTab() QVERIFY(page.loadSpy.takeFirst().value(0).toBool()); QTest::mouseClick(view.focusProxy(), Qt::LeftButton, {}, elementCenter(&page, "link")); QTRY_VERIFY(page.newPage); + QTRY_COMPARE(page.newPage->loadSpy.count(), 1); QTRY_VERIFY(!lastUserAgent.isEmpty()); QCOMPARE(lastUserAgent, expectedUserAgent); QCOMPARE(evaluateJavaScriptSync(&page, QStringLiteral("navigator.userAgent")).toString(), expectedUserAgent); |