diff options
| author | Allan Sandfeld Jensen <allan.jensen@theqtcompany.com> | 2016-02-11 14:56:59 +0100 |
|---|---|---|
| committer | Peter Varga <pvarga@inf.u-szeged.hu> | 2016-03-11 06:21:31 +0000 |
| commit | a35cf1f491b69e3aba4f9cd95dd37eff8c0a34b1 (patch) | |
| tree | d6ada6030aafa45a5bae14ad0dad7749d424a473 /tests/auto | |
| parent | 2648205d7bc0844cd70200497956fae4661e4b5d (diff) | |
Cleanup QUrl initialization in favicon-manager test
No need to call QUrl constructors multiple times. And we should avoid
using remote URLs even invalid ones that still cause DNS lookups.
Change-Id: I251784a3d607377986349f196b893cf3a45656a7
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Diffstat (limited to 'tests/auto')
| -rw-r--r-- | tests/auto/widgets/qwebenginefaviconmanager/tst_qwebenginefaviconmanager.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/tests/auto/widgets/qwebenginefaviconmanager/tst_qwebenginefaviconmanager.cpp b/tests/auto/widgets/qwebenginefaviconmanager/tst_qwebenginefaviconmanager.cpp index f435288f7..0b7a955b3 100644 --- a/tests/auto/widgets/qwebenginefaviconmanager/tst_qwebenginefaviconmanager.cpp +++ b/tests/auto/widgets/qwebenginefaviconmanager/tst_qwebenginefaviconmanager.cpp @@ -105,7 +105,7 @@ void tst_QWebEngineFaviconManager::faviconLoadFromResources() QSignalSpy loadFinishedSpy(m_page, SIGNAL(loadFinished(bool))); QSignalSpy iconUrlChangedSpy(m_page, SIGNAL(iconUrlChanged(QUrl))); - QUrl url = QUrl("qrc:/resources/favicon-single.html"); + QUrl url("qrc:/resources/favicon-single.html"); m_page->load(url); QTRY_COMPARE(loadFinishedSpy.count(), 1); @@ -124,7 +124,7 @@ void tst_QWebEngineFaviconManager::faviconLoadEncodedUrl() QSignalSpy iconUrlChangedSpy(m_page, SIGNAL(iconUrlChanged(QUrl))); QString urlString = QUrl::fromLocalFile(TESTS_SOURCE_DIR + QLatin1String("qwebenginefaviconmanager/resources/favicon-single.html")).toString(); - QUrl url = QUrl(urlString + QLatin1String("?favicon=load should work with#whitespace!")); + QUrl url(urlString + QLatin1String("?favicon=load should work with#whitespace!")); m_page->load(url); QTRY_COMPARE(loadFinishedSpy.count(), 1); @@ -157,7 +157,7 @@ void tst_QWebEngineFaviconManager::aboutBlank() QSignalSpy loadFinishedSpy(m_page, SIGNAL(loadFinished(bool))); QSignalSpy iconUrlChangedSpy(m_page, SIGNAL(iconUrlChanged(QUrl))); - QUrl url = QUrl("about:blank"); + QUrl url("about:blank"); m_page->load(url); QTRY_COMPARE(loadFinishedSpy.count(), 1); @@ -192,7 +192,7 @@ void tst_QWebEngineFaviconManager::errorPageEnabled() QSignalSpy loadFinishedSpy(m_page, SIGNAL(loadFinished(bool))); QSignalSpy iconUrlChangedSpy(m_page, SIGNAL(iconUrlChanged(QUrl))); - QUrl url = QUrl(QUrl("http://non.existent/url")); + QUrl url("invalid://url"); m_page->load(url); QTRY_COMPARE(loadFinishedSpy.count(), 1); @@ -208,7 +208,7 @@ void tst_QWebEngineFaviconManager::errorPageDisabled() QSignalSpy loadFinishedSpy(m_page, SIGNAL(loadFinished(bool))); QSignalSpy iconUrlChangedSpy(m_page, SIGNAL(iconUrlChanged(QUrl))); - QUrl url = QUrl(QUrl("http://non.existent/url")); + QUrl url("invalid://url"); m_page->load(url); QTRY_COMPARE(loadFinishedSpy.count(), 1); |