summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--src/core/file_picker_controller.cpp2
-rw-r--r--tests/auto/widgets/qwebenginescript/tst_qwebenginescript.cpp20
2 files changed, 11 insertions, 11 deletions
diff --git a/src/core/file_picker_controller.cpp b/src/core/file_picker_controller.cpp
index 334321273..d8b5b520e 100644
--- a/src/core/file_picker_controller.cpp
+++ b/src/core/file_picker_controller.cpp
@@ -154,7 +154,7 @@ void FilePickerController::accepted(const QVariant &files)
{
QStringList stringList;
- if (files.canConvert(QVariant::StringList)) {
+ if (files.canConvert(QMetaType::QStringList)) {
stringList = files.toStringList();
} else if (files.canConvert<QList<QUrl> >()) {
const QList<QUrl> urls = files.value<QList<QUrl>>();
diff --git a/tests/auto/widgets/qwebenginescript/tst_qwebenginescript.cpp b/tests/auto/widgets/qwebenginescript/tst_qwebenginescript.cpp
index 5699f1d36..a0887275d 100644
--- a/tests/auto/widgets/qwebenginescript/tst_qwebenginescript.cpp
+++ b/tests/auto/widgets/qwebenginescript/tst_qwebenginescript.cpp
@@ -415,7 +415,7 @@ void tst_QWebEngineScript::webChannel()
QCOMPARE(testObject.text(), QStringLiteral("test"));
if (worldId != QWebEngineScript::MainWorld)
- QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant(QVariant::Invalid));
+ QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant());
}
#endif
void tst_QWebEngineScript::noTransportWithoutWebChannel()
@@ -423,11 +423,11 @@ void tst_QWebEngineScript::noTransportWithoutWebChannel()
QWebEnginePage page;
page.setHtml(QStringLiteral("<html><body></body></html>"));
- QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant(QVariant::Invalid));
+ QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant());
page.triggerAction(QWebEnginePage::Reload);
QSignalSpy spyFinished(&page, &QWebEnginePage::loadFinished);
QVERIFY(spyFinished.wait());
- QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant(QVariant::Invalid));
+ QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant());
}
void tst_QWebEngineScript::scriptsInNestedIframes()
@@ -488,9 +488,9 @@ void tst_QWebEngineScript::webChannelResettingAndUnsetting()
// There should be no webChannelTransport yet.
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::MainWorld),
- QVariant(QVariant::Invalid));
+ QVariant());
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::ApplicationWorld),
- QVariant(QVariant::Invalid));
+ QVariant());
QWebChannel channel;
page.setWebChannel(&channel, QWebEngineScript::MainWorld);
@@ -499,13 +499,13 @@ void tst_QWebEngineScript::webChannelResettingAndUnsetting()
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::MainWorld),
QVariant(QVariantMap()));
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::ApplicationWorld),
- QVariant(QVariant::Invalid));
+ QVariant());
page.setWebChannel(&channel, QWebEngineScript::ApplicationWorld);
// Now it should have moved to ApplicationWorld.
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::MainWorld),
- QVariant(QVariant::Invalid));
+ QVariant());
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::ApplicationWorld),
QVariant(QVariantMap()));
@@ -513,9 +513,9 @@ void tst_QWebEngineScript::webChannelResettingAndUnsetting()
// And now it should be gone again.
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::MainWorld),
- QVariant(QVariant::Invalid));
+ QVariant());
QCOMPARE(evaluateJavaScriptSyncInWorld(&page, "qt.webChannelTransport", QWebEngineScript::ApplicationWorld),
- QVariant(QVariant::Invalid));
+ QVariant());
}
void tst_QWebEngineScript::webChannelWithExistingQtObject()
@@ -523,7 +523,7 @@ void tst_QWebEngineScript::webChannelWithExistingQtObject()
QWebEnginePage page;
evaluateJavaScriptSync(&page, "qt = 42");
- QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant(QVariant::Invalid));
+ QCOMPARE(evaluateJavaScriptSync(&page, "qt.webChannelTransport"), QVariant());
QWebChannel channel;
page.setWebChannel(&channel);