| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The example runs a nested event loop while waiting for the printer
to return a document. During that event loop, a user was previously
free to click on any of the buttons in the print preview dialog,
whoich would mess up the internal state and cause a crash. This change
adds a filter to that event loop to exclude user input events, and
updates the docs to mention the reasoning behind this pattern.
Fixes: QTBUG-122916
Pick-to: 6.7
Change-Id: I4d3d336ffa9bd23e036772bd78f6f1e5870ab732
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example takes precedence over build system file type.
According to QUIP-18 [1], all examples file should be
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I558c6f409a480835d335101577ae633194b0559d
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.7
Change-Id: I1fe5fe8620055eec7c7fd4831459b0aa39864f97
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
This change adds the relevant permission pop-up text to the Quick Nano
Browser example for the local font access API.
Task-number: QTBUG-121320
Change-Id: I0347f028301fe57cfece7962798398a0dc9978e5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid doing network operations unless a network-specific scheme is
given.
In fact, network loading is not supported anyway, so
QUrl::fromLocalFile() would be just as good for now. But perhaps we
could support network loading eventually; and this approach is not
harmful in the example in the meantime. You just get a "file not found"
error if you give an http(s) URL on the command line.
Pick-to: 6.5 6.7
Fixes: QTBUG-123548
Change-Id: I2364fd99396d4d65df92106e45818166ef2abf2f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
| |
qrc:/WebAuthDialog.qml:115:21: Unable to assign QString to QRectF
Change-Id: I88e2f6c3da745d0f8b9663c40ae895cbbdfd8ad9
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, permissions for clipboard access could only be managed
through the JavascriptCanAccessClipboard and JavascriptCanPaste
settings. This change allows copy/paste to be handled the same way
as notification and geolocation permissions.
If both JavascriptCanAccessClipboard and JavascriptCanPaste are
enabled, permissions will be granted unconditionally without a
feature request being made.
Fixes: QTBUG-77450
Change-Id: I383e27e244ced3d6b7988644e38d2307c6267f76
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
- added a method to set image animation policy in QWebEngineSettings
Fixes: QTBUG-86154
Change-Id: I8b3ab6067f9cff4219b0da90bb8601406cb98e24
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the scope later is a SiC (Type A, but still) change, so better
do it now when we introduce the class.
Found in API-review.
Amends 605b0b3dcce24ff82c1e7a1ab3db7dace9668b81.
Pick-to: 6.7
Change-Id: I4f399beed4a7a817c3f58e5864ed56b3a223a116
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This example exists to show a simpler viewer using PdfScrollablePageView
rather than PdfMultiPageView. Most users will probably prefer the latter,
so we don't highlight this one.
Pick-to: 6.7
Task-number: QTBUG-81560
Change-Id: Ia601b8c8ec0cb9002aa118917720a37b4f8095a5
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
- Modified WebAuthUXState as enum class
- Renamed QWebEngineWebAuthUXRequest as QWebEngineWebAuthUxRequest
- Renamed QWebEngineWebAuthPINRequest as QWebEngineWebAuthPinRequest
- Replaced all occurrence of UX and PIN with Ux and Pin respectively
Fixes: 6.7
Change-Id: Iaf0b4c93e0dfa3508a604f7d6562c4401ff800af
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
In cookiebrowser example, all new cookie widgets are added at position
0. Background color of the newly added widget is set based on the
color of last inserted cookie widget.
Fixes: QTBUG-120446
Pick-to: 6.7 6.6 6.5
Change-Id: I76fe3ae83b31489365396a2ebcd31d840b2fa857
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's better for usability in case the user is doing repeated searches:
press control-F and start typing to search for different text, rather
than needing to do something else to select or delete the existing
text in the search field.
Fixes: QTBUG-120447
Pick-to: 6.2 6.5 6.6 6.7
Change-Id: I8d5a519a631c406dff91198b23a022856609fa4c
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A crash was possible if there are no search results and the user
presses the up/down buttons alongside the search field on the toolbar.
That was easily fixed (in a previous patch); but actually those buttons
should be disabled if there are no results to navigate. To do that, we
need a notifying property rather than depending on the invokable
QAIM::rowCount(). Follow the usual pattern for a one-dimensional model:
add a `count` property in the subclass (as in XmlListModel,
FolderListModel, CalendarModel, and a few others).
Task-number: QTBUG-119776
Change-Id: I51c75b58f3a440c1c470794518a572b384376ea7
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Also fixed the qrc file.
Fixes: QTBUG-119738
Pick-to: 6.6 6.7
Change-Id: I97e981260fff90e6f9ef3a1ea661d9cf47e6ee45
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-119732
Pick-to: 6.6 6.7
Change-Id: Ibfdc2989cea704a05fa5f6ed038c2b08498285e7
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.6 6.7
Fixes: QTBUG-119732
Change-Id: Ia034b8a1566cd2858ccfe1313d73b503b10d752b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][WebEngineCore] Add QWebEnginePage::desktopMediaRequested() signal
[ChangeLog][WebEngineQuick] Add QQuickWebEngineView::desktopMediaRequested() signal
Pick-to: 6.7
Fixes: QTBUG-112142
Task-number: QTBUG-70077
Change-Id: I4bfad88732b45fb68b77f7617440bcb50b248a11
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Multiline copyright entries are entered via string array.
Task-number: QTBUG-111873
Pick-to: 6.5 6.6
Change-Id: I1b90e5333505227db66bc25d3baba8311afda37d
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.5 6.6 6.6.0
Change-Id: Id3279026fcc791a9bd5e3e51a7ba7dd3c4a6930c
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
|
|
|
|
|
|
|
| |
- Corrected the typo in the file system access window title.
Pick-to: 6.6
Change-Id: I9667726527e90477f6602e9ac8acf1a68742abe7
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yes, the class needs to inherit from QSpinBox in order to override the
protected virtuals, but that doesn't mean a QPdfPageSelector should
model is-a QSpinBox. E.g. the range of the QPdfPageSelector is taken
from the QPdfDocument, and no good can come from a user changing it
through the use of QSpinBox API, esp. if one thinks about the class
being displayed as a native widget in QtDesigner.
In a similar vein, the inheritance from QSpinBox leaves users
wondering (and the docs didn't do anything to enlighten them) what
properties are pertinent to the task at hand. setValue() to set the
page index is ... meh, but still somewhat discoverable. But that
text() is only QPdfDocument::pageLabel() if no affixes are set takes
quite some digging.
Part of this could be fixed by providing domain-specific properties
like currentPage for value, but that would just increase the
confusion, because those two properties would must needs exist on the
same object.
Instead, fix by moving the old QPdfPageSelector as
QPdfPageSelectorSpinBox into qpdfpageselector_p.h, removing its pimpl
and having QPdfPageSelector inherit QWidget instead, aggregating a
QPdfPageSelectorSpinBox. This involves a few more objects (the widget,
the layout), but gives QPdfPageSelector full control over its
interface.
Add a few salient properties (more can be added if needed, by copying
them from QSpinBox or QAbstractSpinBox).
Note how well the new API rhymes with QPdfPageNavigator in the
connect() in pdfviewer example's MainWindow.
Since we still store everything in QPdfPageSelectorSpinBox, but don't
pimpl it anymore, QPdfPageSelectorPrivate can lose the q_ptr now, and
merely contains the pointer to its QPdfPageSelectorSpinBox. This
could be optimized further, by making QPdfPageSelectorSpinBox and
QPdfPageSelectorPrivate the same class, but that's neither BC- nor
SC-relevant anymore, and can be done later (or never, seeing as this
widget is unlikely to be used more than a few times per application).
Found in API-review.
As a drive-by, port to the std-compatible subset of the QPointer API.
Pick-to: 6.6
Change-Id: I0d82d098d38d5f2fcf7f1c8c9aed6e792a8deb2d
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We kept urls in examples to point to company website.
However this site is heavy to load and moreover it changes
overtime leaving example screenshots obsolete.
Introduce internal qt version web ui page which will
be default page for examples and which displays basic
information and can work offline.
For start show version info and command line options
for chrome://qt
Pick-to: 6.6
Change-Id: I0271ce6e7b152efe4942a6240b0c74ba382d5fcc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quick Nano Browser and Simple Browser need this to be able to use the
camera and microphone on macOS.
Also document the need for signing the applications in the examples
documentation.
Pick-to: 6.6
Task-number: QTBUG-114939
Change-Id: I7a260a7ec62138fec8f7b4d6c1f2009eee9004d6
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebEngine examples are generally added to the new 'Web Technologies'
category - only Nano Browser remains also in the 'Application Examples'
category.
The 2 Qt PDF examples are placed in the 'Graphics & Multimedia'
category. This is not ideal, but from the existing categories the
arguably best matching one.
Pick-to: 6.5 6.6
Task-number: QTBUG-115174
Change-Id: I3824272f62a4940f91041c8694fd2a06929863ed
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't think it was very confusing, but just in case we could want a
currentSearchResult() returning the actual result object at some point.
It was a suggestion from header review.
Amends 288e9be6ba2be40761333036f3397298df5e1018
Pick-to: 6.6
Change-Id: Ie3eb500e3a79b80b8abafbe19c48b57c7e9d71be
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
| |
- Updated the application's path for code signing.
Change-Id: I8469d573ba5f952d02734bc75e33b34f0c6e4494
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
If no settings loaded, start recipe browser example
with no style sheets applied.
Fixes: QTBUG-114471
Pick-to: 6.6 6.5
Change-Id: Ibdcf0e5171dfa76925e9af95754f0583aedec9bd
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtPositioningHelper now uses the Qt Permissions API. Also fixup the
examples Simple Browser, Quick Nano Browser and Maps to use the right
key on macOS and sign the application as part of the build process
Moves the Geopermission auto tests to manual tests for webenginequick
and webenginewidgets on macOS.
Pick-to: 6.6
Fixes: QTBUG-114939
Change-Id: Id6771889f20c866d2fcdbb477dbbb7da30367043
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
- Implemented AuthenticatorRequestClientDelegateQt support to handle authenticator requests.
- Added FIDO user verification and resident credential support
Fixes: QTBUG-90938
Fixes: QTBUG-90941
Change-Id: I6367791e1e9e8aaac27c376408377f838832f426
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
There's already nanobrowser in Application Examples so this removes the
other webengine examples from that category.
Pick-to: 6.5.2 6.5 6.6
Change-Id: I1f6dc7be7cb0ad4b0ac8134eb438ac0a0db7a5d3
Reviewed-by: Tuukka Turunen <tuukka.turunen@qt.io>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.6 6.5 6.5.2
Change-Id: I795da5e37bd084e5c101aaed14fda5a9b3be4b92
Reviewed-by: Kimmo Leppälä <kimmo.leppala@qt.io>
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.5.2 6.5 6.6
Change-Id: Ia6f1950425d078fbcf4b5e212e5cc983544f3397
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This manifest is required for User-Agent to report the
correct Windows versions.
Document Windows App Manifest in platform-notes and
mention it in the httpUserAgent documentation.
Pick-to: 6.6
Fixes: QTBUG-63021
Change-Id: Ie3896c50a0a912742e8d1a0dc20f3305b343d3f4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Calling TabBar.removeItem(Item item) with an integer results
in an exception in the qml engine making the tabs not closable.
'removeItem' is called twice on the same item/index.
Remove the wrong call.
Pick-to: 6.5
Change-Id: Ie46794e219e82b956b615fa5cbb5dfe745598901
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
| |
Pick-to: 6.5
Change-Id: Iec4f3db0a6dad1eb040e44b09bc0b0000714ecdb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since Qt 6, the default Qt Quick Controls style is native style on
Windows and macOS. Since Qt 6.5, there is a warning to not to
customize native style:
"QML QQuickItem: The current style does not support customization of
this control ..."
Use non-native Fusion style instead, which appearance still resembles
the native style and is customizable.
Pick-to: 6.5
Change-Id: Ifadd74a152b739461f2ad7ef1cb9763a2974b492
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The '\meta category' command was used for tagging examples with a
specific category, used in Qt Creators Welcome mode.
As we want to also generate lists of examples belonging to a category
elsewhere in the documentation, replace the command with a macro that
expands to the original \meta command and also adds the example to
a group using the \ingroup command. This way, the category names can
be used as arguments to the \generatelist or \annotatedlist commands.
Pick-to: 6.5
Task-number: QTBUG-112731
Change-Id: If9519fd8994c64cf57dc4c9a9387d7be80493d80
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This patch merges the qtwebengine examples recipe browser, stylesheet
browser and markdown editor into one single example.
Pick-to: 6.5
Task-number: QTBUG-108751
Change-Id: I338707d7d3275b03bf2a2d7b65064ac91e562d7f
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove duplicated unused helper questionForFeature()
- Replace lambdas by slots where possible
- Fix clang warning about using multiple arguments to QString::arg()
- Remove dead code in WebView::contextMenuEvent() which checks on
inspectElement == actions.cend(), but is within an "if" checking
the same condition.
Pick-to: 6.5
Change-Id: Ie85a3811f4f5a8c3fa9550d4eb2ca5bf79e39084
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
There are 3 OS settings under Windows 11 that need to be enabled for
the HTML5 Geolocation in QtWebEngine to work properly. This isn't
very straightforward to a user, therefore this patch adds a note to
the documentation.
Pick-to: 6.5
Change-Id: Id36a4726a182178c5a15fce039e464fd6bb7517e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Also moves the example to the manual tests directory.
Task-number: QTBUG-108751
Change-Id: Ie3fa492cfcaf61ee26ed65fa22954bb6a6532d6e
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
(cherry picked from commit 23d1131577e1780de0552211a84357bcb1f63de5)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let's be clear in the title that this is a widget-based example, as
opposed to the Qt Quick example in the docs.
The screenshot is from macOS 13.2.1.
The 6.6 example has more features, so this screenshot looks a bit
incomplete compared to that.
Pick-to: 6.5
Task-number: QTBUG-81560
Change-Id: I28b50d608756f10967f1bf5f7ac72ec9a83d9417
Reviewed-by: Matthias Rauter <matthias.rauter@qt.io>
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
|
|
|
|
|
|
|
| |
It otherwise looks like a bit like an oversight or bug.
Pick-to: 6.5
Change-Id: If11fe034fa91022eb70c99b8a916fb35ac86f75d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
- else after return
- Use multiarg version of QString::arg(QString)
Pick-to: 6.5
Change-Id: Iceff3ee8877b866b5b9187cd85da54864ab17834
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
| |
As a drive-by, make constructors explicit.
Pick-to: 6.5
Change-Id: I5c8e3d8049504afa4aa5a0d7c1a85bb59eb3cd38
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.5
Change-Id: I14ed5efed1bf228239f95a8a4addce5d19a9f220
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doesn't demonstrate anything complicated, the code isn't even worth
quoting as snippets. We could consider introducing a help browser to
replace it with more functionality.
Task-number: QTBUG-108751
Change-Id: I3b796388796a78d017836a10bee18032b2cd4905
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit e4051de7db7b7f0905770280f9a06e133d453cf7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move and add missing parts as snippet.
Task-number: QTBUG-108751
Change-Id: I25849941700337626ca46e399fdb52264bc4659a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Yigit Akcay <yigit.akcay@qt.io>
(cherry picked from commit 55f9fc348278b2aa8985ec9c1e7e092f88f68f83)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This example shows how to use dialogs, however documentation
already provides snippets for that added in 3cbe59e29a.
The only missing one was tooltip, therefore add missing snippet
and move example to manual tests.
Task-number: QTBUG-108751
Change-Id: I84eda805455fb0276046ed1089389d605a8af672
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit 6bf30525ee49d270dae6a6440bc607513f21237c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|