| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The PdfPageView QML Type documentation contains a code snippet. The code
snippet should demonstrate how to use the PdfPageView QML type, however it uses the PdfMultiPageView QML type instead. This fix creates a new
code snippet that implements the PdfPageView QML type. This snippet
replaces the incorrect snippet that was used previously.
Fixes: QTBUG-123536
Pick-to: 6.7
Change-Id: I319b4d86133d7dc41664229110a6c13ed46b7e80
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If QPdfLink stored polygons instead of rects, it would make sense to
transform each point using QPdfDocumentPrivate::mapPageToView();
but the quadpoints (polygons) in the test.pdf from QTBUG-100630 happen
to describe rectangles. This patch successfully does the transform so
that they line up with the link text. It doesn't do much good since the
links in that PDF are invalid anyway, but presumably links using
quadpoints occur in the real world sometimes.
Pick-to: 6.7
Task-number: QTBUG-100630
Change-Id: I0cb151dbb30ca73c8f9ed2bcd29508ced05de064
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use FPDF_PageToDevice() rather than subtracting from page height,
in all the remaining places where we were doing that.
Also use FPDF_DeviceToPage() to convert coordinates coming from
the view, for hit-testing links and for selecting ranges of text.
Mark the private utility functions that we're modifying const
while we're at it.
Pick-to: 6.5 6.6 6.7
Task-number: QTBUG-100630
Fixes: QTBUG-106565
Change-Id: Ide4f73b80888a0e08381c6e4995f69ebeaa2d12f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a drive-by, remove unneeded includes.
QPdfDocumentPrivate::convertPageRect() will be useful for fixing
related bugs. If PDF files can contain arbitrary transforms, and
"page coordinates" returned from pdfium functions are not already
converted, then it's never ok to just subtract from page height to
invert the y's.
Pick-to: 6.5 6.6 6.7
Fixes: QTBUG-120764
Change-Id: Iffce528c0c5e66c499e7147078b7b8718f7610ce
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a PDF-viewing application is unceremoniously exited while
QQuickPixmapReader::processJobs() still has PDF rendering jobs
queued up, it could be that the shared QPdfDocument instance
is deleted just as QPdfIOHandler::read() starts the rendering.
Use a QPointer to avoid that.
Fixes: QTBUG-121502
Pick-to: 6.5 6.6 6.7
Change-Id: I5d0674ca77ab5015b710df49b3842064e65d4adc
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This example exists to show a simpler viewer using PdfScrollablePageView
rather than PdfMultiPageView. Most users will probably prefer the latter,
so we don't highlight this one.
Pick-to: 6.7
Task-number: QTBUG-81560
Change-Id: Ia601b8c8ec0cb9002aa118917720a37b4f8095a5
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-117983
Change-Id: I11cb0bbc54f0679d99e64ae737655f91a93c568a
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-117983
Change-Id: Ic7a1ea3e9a9015dd797d4beb86fed74ef0e5c976
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When executing 'ninja docs' documentation is generated locally with
code attributions for qtwebengine and qtpdf, however it is missing on
doc.qt.io in case of qtpdf.
Make 'ninja prepare_docs' target to already generate pdf_attributions,
hopefully it fixes the issue as it is unknown how those docs are
generated in the end, moreover this is the only difference between
qtwebengine and qpdf doc target setup.
This amends 98c84d8d7a4ef4a308b1a75f90ff075135995c60
Fixes: QTBUG-120663
Pick-up: 6.7 6.6 6.5
Change-Id: Id1b371209ead987460fabb53c3bc35070dbedb35
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.7 6.6
Change-Id: I68e46ec382c4c63c106c545cf6815777954a6afc
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A crash was possible if there are no search results and the user
presses the up/down buttons alongside the search field on the toolbar.
That was easily fixed (in a previous patch); but actually those buttons
should be disabled if there are no results to navigate. To do that, we
need a notifying property rather than depending on the invokable
QAIM::rowCount(). Follow the usual pattern for a one-dimensional model:
add a `count` property in the subclass (as in XmlListModel,
FolderListModel, CalendarModel, and a few others).
Task-number: QTBUG-119776
Change-Id: I51c75b58f3a440c1c470794518a572b384376ea7
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-119776
Pick-to: 6.2 6.5 6.6 6.7
Change-Id: Id7addc15c15b78451d7f8b989335d12976426a30
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I8eea99a472cc597ff9864b570c90b28b79b3751e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: I1131b2873f82d954ca47bf90bc82200d5f4cd751
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-115044
Pick-to: 6.5 6.6
Change-Id: I83314f3b7955e1ef9c857bcc96c07f6f90b2f875
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
third_party zlib got pulled into build and we need also
use_system_zlib flag set accordingly.
Pick-to: 6.6 6.5
Task-number: QTBUG-116595
Change-Id: Iee4c91ec240512e23fe7ab612658320b0537920c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-119536
Pick-to: 6.5 6.6
Change-Id: I31028e19c2d376133f0fcd6c06ecc295163f1747
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add builds for android on windows platform. These
are required by qt release scripts to create armv7 targets
on windows.
Note new 'is_mingw' setting for toolchainis. This required
as andorid on windows build use mingw toolchain as a
host toolchian. Main gn_arg argument 'is_mingw' is used
only for target/default toolchian, in this case gn drops
toolchian_args. However toolchain_args are evaluated in
case of secondary/host toolchain.
Override v8 snapshot toolchain to avoid pulling windows
(msvc or clang) toolchains and creating yet another set of
toolchain targets.
Task-number: QTBUG-83459
Change-Id: I927872d69e363277b9f90c3adda28518d6b6bb13
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/pdfwidgets/qpdfpageselector.cpp:
* warning: Cannot find 'QPdfPageSelector::currentPageIndex'
specified with '\property' in any header file
src/core/doc/src/qtwebengine-deploying.qdoc:
* warning: Unknown command '\maocs'
Mark documentation modules free of warnings.
Pick-to: 6.6
Change-Id: Icbdf9622501b1fc4911f58682ffd2146efc36c1f
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
| |
Policy in qtwebengine is to use a separate d-pointer to avoid tying
the module build to a particular upstream Qt release.
Pick-to: 6.6 6.6.0
Change-Id: I0be241ee379663721225484cda22d952942a95fd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite for using QT_PDF_REMOVED_SINCE.
Pick-to: 6.6
Change-Id: I46adece3ba1ff1a4c95218a1bc731dea05afc1f3
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
|
|
|
|
|
|
|
|
| |
Amends b8419577eb99c158
Pick-to: 6.6
Change-Id: Ie60b418be63699cf1ff2baec5d867ccd85536f2b
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function was introduced in
d1347ebbe99b467799680bb6e3cee81932751df5 as a bugfix for QTBUG-111067.
The patch was also picked to 6.5, which is not really correct, because
we normally guarantee forward BC in patch releases.
Generally, there is no reason to expose this method to the API - we
could just use a lambda internally. Do it now.
Treat the exposed function as internal, and remove it completely
both from the API and the ABI.
Pick-to: 6.6 6.5
Change-Id: I48b93767c341aca58135872f391fc731561b68d4
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In QPdfBookmarkModelPrivate::appendChildNode it was not necessary to
call FPDF_LoadPage() just to be able to call FPDF_GetPageHeight():
the BookmarkModel has the QPdfDocument which can do that for it,
using FPDF_GetPageSizeByIndex() instead.
7b8832ca2b84d549c9d374550c3c46b3d4d42a38 added
QQuickPdfDocument::carrierFile() returning a pointer that
QQuickPdfDocument continues to own. QQuickPdfDocument::setSource()
took care of deleting the existing one if we open a different
document, but the destructor did not delete it.
Pick-to: 6.2 6.5 6.6
Task-number: QTBUG-114953
Change-Id: Ie8d9cea456cb91d9541deb575dac17db0d367ead
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The standard guarantees that int is a default type for enum class, so
no need to spell it out explicitly.
Found during Qt 6.6 API review
Pick-to: 6.6
Change-Id: I4ec4eb443ffe5d54f24ab20ef1de43105a06bb6d
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
... because it does.
Found during Qt 6.6 API Review.
Pick-to: 6.6
Change-Id: Ia8f27d3ca1cca0141bd6de7874ba20225171fb63
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the 6.6 header review it was suggested that the caller should do the
trimming if necessary; avoiding it here is more efficient. So far the
only caller is QPdfPageSelector (although we may need to implement the
same feature in the Quick PDF examples at some point).
Typing page labels into QPdfPageSelector didn't work because
QPdfPageSelector::validate() was not overridden. Now we reuse
pageIndexForLabel() for that too: if the label is found, it's valid; if
the label is not found, we just assume the user is not done typing yet.
There's no QPdfDocument function to do a substring search for page
labels, or to return the whole list of them either. It seems they
can only be gotten one-at-a-time via the FPDF_GetPageLabel function.
Now it actually works in the widget-based example
qtwebengine/examples/pdfwidgets/pdfviewer/pdfviewer: if you load a
document that has some Roman-numeral-numbered preface pages and type
e.g. " iii" into the spinbox, it jumps to page iii.
Fixes: QTBUG-115476
Pick-to: 6.6
Change-Id: I070338effee1bbf916581c5ba964367424b786b2
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use 'ldir' response files directly and drop cmake workaround.
This also drops cmake FILE_PERMISSIONS which requires cmake 3.21
This change amends 75ae9b61967dc484e91f3dbee435045e63258c84
Task-number: QTBUG-105053
Task-number: QTBUG-111225
Fixes: QTBUG-115033
Pick-to: 6.6
Change-Id: I8d59dca3eaa842939d71727f419f66e3589d6e0a
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
We do not override use skia in 3rparty, set it as gn arg.
Do not use ml inliner as does not work properly with our android
ndk.
Pick-to: 6.6
Change-Id: Idefe6d94438b2403b90e00cf4343b0f882b60881
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.6
Change-Id: I1bb84b20a080d7f615bf0795ac2d97739e99ac1d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.6
Change-Id: I56e1695ee4fc2b0e12da6580a5673df80bba8b6d
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
| |
...as suggested in the 6.6 header review.
It's small enough to be more efficient that way.
Pick-to: 6.6
Change-Id: Ia2b7a983f4edf6e66dc13905e31a11d7e4be4290
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The most common limit for the maximum number of allowed documentation
warnings is zero. As all Qt module docs include() a common configuration
from qtbase, it's better to control the base warninglimit from a central
location in qtbase/doc/global.
This allows for a temporary increase of the limit across all modules as
needed - for example, when updating the QDoc binary that the CI
provisions to a version that introduces new types of documentation
warnings.
Task-number: QTBUG-113326
Change-Id: Ic28d57f29e1f8ea5b551fe25a413dafcf04c0ccc
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
| |
Amends f36f0d5202fee3b778290dd68d1c30911b75b5b4.
Task-number: QTBUG-114367
Pick-to: 6.6
Change-Id: If1478f4021e5bcc4f011c943fcc3817580ec21c2
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
| |
Task-number: QTBUG-83459
Task-number: QTBUG-113551
Pick-to: 6.5 6.6
Change-Id: I1b3e21da8fbd714d4a4291a8804e6c901bf8e292
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
We now add NOMINMAX to PlatformCommonInternal target which will be
linked to everything else, so min/max will not be defined upon the
inclusion of `windows.h`, or other headers.
Pick-to: 6.5 6.6
Change-Id: Ib6d0719126b1fa2b324ba4dfea8db69093280c37
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Compile QPdf for mingw too. Support new
is_mingw, is_msvc, is_gcc flags which together
with is_clang pass compiler type to gn.
Task-number: QTBUG-111362
Change-Id: Ib008f4002f7bb0a1b72f010c531c7e759b72a6bf
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtPdf has own png library which is controlled by
pdfium_use_system_libpng and used by xfa.
However skia dependency also pulls root third_party
png and we need also use_system_libpng flag set accordingly.
Add missing pdfium_use_system_zlib flag too.
Fixes: QTBUG-112466
Pick-to: 6.5
Change-Id: I08b7b32e5fd0ffe08cf77421ff2f0965755304ca
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
We use that feature when compiling pdfium for qtwebengine
and qtpdfium if xfa enabled.
Fixes: QTBUG-111626
Change-Id: I362739e7529f89b1705d3c25a1c9849b13a1a968
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-113160
Pick-to: 6.5
Change-Id: Ic987711802db7eb32cdb15ac9f313d2203984981
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For v8 context generator data_dep race condition occurs
on universal builds. As data_dep is runtime dependency,
it will be not included into our linker WebEngineCore.stamp,
changing the behavior in gn would look ugly as it would require
introducing another flag to just to handle this case to force
this dependency for build time. Therefore add extra
v8_context_snapshot.stamp to cmake to cover that case.
Change-Id: Ia8b2320fc8e615235bde483d282dfca73a38f215
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QPdfPageNavigator did not emit the page history signals when pages were
jumped.
This patch ensures correct signal emission in all cases.
It adds a new auto test class for QPdfPageNavigator.
Fixes: QTBUG-112614
Pick-to: 6.5 6.2
Change-Id: I67af5a4d22a8e76b9c12c72c168fa5b3b4390f2c
Reviewed-by: Yigit Akcay <yigit.akcay@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not clearing the search results leads to crashes when the incoming
page model is larger than the outgoing model, due to internal
state being still in sync with the old document, but the page count
of the new document being used.
Fixes: QTBUG-111067
Pick-to: 6.5
Change-Id: Ic81744ebe0cb7d1a152453721abd7d1b5c5fa2b9
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
When doing unity build, `CharacterHitTolerance` collides with similarly
named variable in `qpdfdocument.cpp`.
Pick-to: 6.5
Task-number: QTBUG-109394
Change-Id: If7ac4ec095c88bff38f3b62b4caac82f0bfd8368
Reviewed-by: Orkun Tokdemir <orkun.tokdemir@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let's be clear in the title that this is a widget-based example, as
opposed to the Qt Quick example in the docs.
The screenshot is from macOS 13.2.1.
The 6.6 example has more features, so this screenshot looks a bit
incomplete compared to that.
Pick-to: 6.5
Task-number: QTBUG-81560
Change-Id: I28b50d608756f10967f1bf5f7ac72ec9a83d9417
Reviewed-by: Matthias Rauter <matthias.rauter@qt.io>
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure gn is build before doc target, otherwise
parallel top level build might not succeed.
As configure runs the gn binary is not compiled
so use scripting mode to execute gn call during
build time.
Pick-to: 6.5
Task-number: QTBUG-108751
Change-Id: I7e851de90e2a3ec52f5259d51f677b23d8245bcb
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-88482
Pick-to: 6.5
Change-Id: If58a8443afb38f372ca3dc7372472db888586dba
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
Now you can click links on pages in PDF documents in QPdfView.
Task-number: QTBUG-77511
Fixes: QTBUG-102760
Change-Id: I348dcfd906be088aa3fcbe53aec4628b521cc2f3
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generate a new rsp file for each cmake target
containing '-L' flags and pass them to cmake.
Task-number: QTBUG-105053
Task-number: QTBUG-111225
Change-Id: Ib25c009795b776bc5f0f6e07fb89b932ef30b484
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit a21742ef6064c1e84ebc43468d253dd14d86bf02)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
| |
Task-number: QTBUG-83459
Change-Id: I39915206859f031dd78798eeb7b2b49f4f148452
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|