| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
configure.pri
src/pdf/api/qpdfpagerenderer.h
Change-Id: I7e68277080e29238bbfe8511539ea75b2db89489
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We use now network service avoid io-ui-io-ui hops,
pipe proxying url loader factory directly to ui thread.
This solves thread safty issues.
Add deprecated request interceptor test cases.
Task-number: QTBUG-83082
Task-number: QTBUG-82999
Change-Id: I38778cf1a70789c5e92e04c93d1c93e2cc4c765a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Interrupt the waiting on the event loop in CallbackSpy::waitForResult()
to not block calls on the UI thread.
It is necessary because RenderProcessHost creates channel for mojo
communication on the UI thread. QWebEnginePage::runJavaScript() needs
this channel because the JavaScript is executed in the render process.
If evaluateJavaScriptSync() is called before the mentioned channel is created,
the JavaScriptExecuteRequest mojo message might not be sent because the
wait would block the thread.
Change-Id: Ic5bb5a6fde02717cec49dcf9e458f2eaac09eacf
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
As the dependency 6420ad91d3 in declarative for the only present
focusChild is integrated and test doesn't fail according to grafana.
Change-Id: I0d8fbb966548687d3fb92ec123726f110f18d8d5
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The normal WebViewImpl::SetBaseBackgroundColor expects to be called only during
certain lifecycle states, otherwise a DCHECK will be triggered. Whereas
the *Override version forces a lifecycle update.
Needs 3rdparty change to stop RenderWidgetHostViewBase::SetBaseBackgroundColor
from clearing the override color when switching between opaque and transparent
colors though.
Change-Id: If4c1e22886d7ebc7d87ca880dd9c6a659855a931
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Move the qmltests that require testsupport to qmltests2, this enables
us to run most of the tests on CI configurations that isn't developer-
builds.
Change-Id: Ie0ba060632b36cbd738d6ede512a6a5f35880ae3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Icaf68648cbc2c13a61fc3b208ff1e64ca36c90b6
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
| |
| |
| |
| |
| |
| | |
Fixes: QTBUG-82953
Change-Id: I7dfa916ea0ada00ce84a1e9e49de9eea1800a108
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After tedious investigation the issue boils down to error prone
synchronization of web engine settings. WebEngineSettings are
synchronized between the browser process and the render process.
Moreover in the browser process the sync message is send to the render
with QTimer::singleShot, which can cause race conditions if
for example QWebPage::setUrl was used meanwhile. This makes
current settings not being picked up by the render process and results
in 'titleUpdate' test case flaky. This happens due to the fact that
ShouldDisplayErrorPageForFailedLoad in the render process frame view
could have invalid value.
Try to sync web engine settings on every adapter load, setContent or
reload.
Mark some flaky settings in tests.
Fixes: QTBUG-83078
Change-Id: I5289472f146e104d5cb6c3b9b20b26d3dc42f4b1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\ |
|
| | |\
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
src/3rdparty
tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
Change-Id: Idbc9d3b06c0052a721c974fbcbfa3164faaead14
|
| | | |\
| | | | |
| | | | |
| | | | | |
Change-Id: I5f7aab6031f1c1ca289d5ba408d408684849031c
|
| | | | |\
| | | | | |
| | | | | |
| | | | | | |
Change-Id: I50afabc6022fea5b3db2a7dcb8659b654573661f
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The RenderViewObserverQt_SetBackgroundColor message was sent with wrong
Routing ID.
This fix also cleans up RenderWidgetHostViewQt::UpdateBackgroundColor()
method.
Fixes: QTBUG-81781
Change-Id: Ida198fb061715d389859ace17e1f773db491c51d
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
| | | | |/
| | | |/|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit d4022e03ccaeb92e41075f276e4011bd49627165
and partially fb430b4e104dd6313a776980b4798f1333193149.
Reason for revert: initial blacklisting was done because of wrong assumption for test being flaky. But this is not the case. There is a non-zero chance that invalid build for macOS will be generated due to some undiscovered issue in build configuration or CI. Produced binaries are invalid and can't be used. If this first testcase fails then the whole suite will fail for every test. Blacklisting only moves failure further: first time from contextMenuRequested to javaScriptDialogRequested and etc, and second time to next test in whole suite tst_InspectorServer::testPageList. This creates a lot of really invalid failure entries in grafana testresults aggregator. It also creates confusion for the reason behind these kind of test failures and invalid bug report for other test failures.
Task-number: QTBUG-76549
Change-Id: I1dfe850f6a9cabec352c6e2bd5471e7c4f2e99ca
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
Change-Id: I80c99deb95c06191c4e872e45c56dff0c6c26001
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Avoid having the enum name in the enum values.
Change-Id: Ida5b3405e6922eb1a2a37edc6fb650019254f4d4
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: Ic4b70d31c85a31a434644c311eb173cda6a82fbd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I0d52e4f6684425cb15319760e0001bdb13846997
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I08a8e1b9cae4add9b3831c7f0b7fc6328e9af332
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Blacklists tst_Accessibility::focusChild() for now.
Conflicts:
src/core/api/core_api.pro
src/core/net/plugin_response_interceptor_url_loader_throttle.h
src/process/process.pro
Change-Id: I95821a3851120dc16673f4c760e802952eae5c41
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I23bd548db07c6332170e9d304977e5974c7f049f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\ \ \ |
|
| | |\| |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
tests/auto/quick/qquickwebengineview/BLACKLIST
Change-Id: I365daa73d2eb422ac916c32b86c5ad0d3c32086d
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I847a1750ce5c9533db43fb60f91b9739c544791a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |/
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Toggling page's setting is actually first batched and then executed
asynchronously by timer. So javascript code might not necessarily see
this update immediately after change on UI thread.
Change-Id: I1a1f373b5fd0b96c5b937a2dca1ce0ed99364c33
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The replacement of error with networkError was reverted.
Change-Id: Iae618b1e74ac7f67b6c02a809b3177b2183b5783
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I3469b38146fae425d1282e47b405a6d2710191bf
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
They need the general structure around, and a hint that
the table is not just for layout.
Change-Id: I12f0512a940da4aabb8ce1513da139d8f023f1e2
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The Qt version was added in 5.14 "for use as eventual replacement for
QString::SplitBehavior." Move another step closer to that goal.
Change-Id: I0a37800da400a1f4213d8522de0c818356a7c481
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes: QTBUG-80737
Fixes: QTBUG-81556
Fixes: QTBUG-81614
Change-Id: Ie6a69cdbf46d0508bff226f1b8fed28a618e1949
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/core/renderer_host/web_channel_ipc_transport_host.cpp
tests/auto/widgets/qwebengineprofile/tst_qwebengineprofile.cpp
Change-Id: I47f2b893bc9f27cd9df641f76badc9e53b482ad4
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Remove code duplication on triggering new url load, and use direct
code to clear SelectedText instead of CollapseSelection as it assumes
focused frame and might be ignored.
Fixes: QTBUG-81574
Change-Id: I01cf02967e118f407c8a3997e176d5b258478a5a
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes: QTBUG-81783
Change-Id: I107a4009630dc261013498a05987c0e8e29651eb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add tests for changing httpUserAgent, httpAcceptLanguage, and
persistentCookiesPolicy.
Use local HttpServer instead of network in existing tests.
Stabilize disableCache test and unblacklist.
Stop actually downloading the test binary in downloadItem test.
Register 'myscheme' to avoid warning from QWebEngineUrlScheme.
Task-number: QTBUG-81558
Change-Id: I3178edd1eb241257e211855168ec4ca428a90d29
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Due to sandboxing we can no longer pass pac file.
Pass it as data url instead by reading the pac file and
encoding into base64.
Fix failing proxypac url on windows.
Fixes: QTBUG-81557
Change-Id: I3dc3da4fbd3cce4e903c75022b8e9fe5faf71604
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Mojo data pipes are non-blocking, meaning we have to wait until there's room in
a buffer before we can transfer data from the QIODevice to the pipe.
Use mojo::SimpleWatcher to monitor the pipe for readiness and use the two-phase
BeginWriteData/EndWriteData API to let the QIODevice write directly into the
pipe's internal buffer, avoiding a copy.
Fixes: QTBUG-82244
Change-Id: I65e69ce72d0e99bc047c57b5a22531c0891c553a
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Mouse clicks are set to be ignored in chromium 79 as no useful actions
are available before first real navigation. Add simple blank load for
that and also enforce checks for different kind of policy.
Task-number: QTBUG-80743
Change-Id: Icb0056895c5b194e85bb711b8449e179257f8d5d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Blacklisted one test requiring an update of qt5.git.
Conflicts:
.qmake.conf
Change-Id: I75e55a1c5f8840cde55ddb60d632287b2affadeb
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The test assumes a 1-1 correspondence between request URLs and initiator
origins, but really we have a 1-N correspondence since the same URL can be
requested multiple times by different initiator origins. The current flakiness
results from just such a conflict, namely from one URL being requested both by
the main site (w3schools.com) and by AdSense (doubleclick.net).
Fixes: QTBUG-82288
Change-Id: Ida121d8f23b396b72a28faab91780d6fa4d99c92
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Same as the widget fix:
ffdf7ece Fix widget accessibility on macOS
This patch depends on a focusChild() fix in qtdeclarative:
6420ad91d3 Fix QAccessibleQuickWindow::focusChild() to return focused descendant
Task-number: QTBUG-78284
Task-number: QTBUG-81539
Change-Id: If0da937d2c778a158ce02e1433b28ca0888692d8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Setting an empty string instead of "()" fixes that case where the file
input doesn't have "accept" attribute.
Task-number: QTBUG-82109
Change-Id: I8a72f819fa6d8bbab4e5f1067b38ad75ff11e118
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Trigger cookie monster init by making simple blank navigation to allow
run every single test separately. API loadAllCookies supposed to init
cookie storage to avoid this navigation but currenly doesn't work.
Task-number: QTBUG-80605
Change-Id: I0b71e7eeb015169af2042e90713c5aa96f8bb135
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
BackAction might not be immediatelly enabled after frame's
content check through javascript. Amends d7d40469b5.
Change-Id: I2b6242da190c39b8d72d17d563c6c86238e56887
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Needs an id to a valid anchor.
Change-Id: I39d586e94ca68c0d502302aa27d228f3c5caf160
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |\ \ |
|
| | |\|
| | | |
| | | |
| | | | |
Change-Id: I349a4ecbbd9d3d121ca6564db77e417872246554
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
macOS Accessibility queries the window for the focused accessibility
element. The window forwards the query to the widget with active focus.
This widget is the RWHVQtDelegateWidget if a web element is focused
in QWebEngineView. Therefore, a QAccessibleWidget interface has been
implemented for the RWHVQtDelegateWidget to forward the request to the
QWebEngineView.
The focused accessibility element expected to be returned by the
QAccessibleInterface::focusChild() method. In case of the macOS accessibility
backend, it is called by the accessibilityFocusedUIElement() NSAccessibility
API function. It expects the focused web accessibility element otherwise
VoiceOver won't focus properly.
The focused web accessiblity element is looked up by the new
BrowserAccessibilityQt::focusChild() method.
RenderWidgetHostviewQtDelegateWidget::focusChild() and
QWebengineViewAccessible::focusChild() methods have been also implemented
to forward it.
This patch depends on a focusChild() fix in qtbase:
a132e02540 Fix QAccessibleWidget::focusChild() to return focused descendant
Microsoft Narrator also uses focusChild() to query the current focused
element when it starts but it is still functional without this fix.
Task-number: QTBUG-78284
Task-number: QTBUG-81539
Change-Id: I3c4861e58622ccbb5046c60c4efcc19842400a88
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It relies on moving the cursor.
Task-number: QTBUG-76312
Change-Id: I6bdd53b8c0eb41300a538137fb7ec52881c38f33
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Also speculatively increase timeouts for load operations
Task-number: QTBUG-81263
Task-number: QTBUG-79852
Change-Id: Id7fc0849d671535e35c939edbe4ef365b229dce4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|