| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Change-Id: I1f5843b1abba9edb3c106718abac5cd92ee961cd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Should help narrow down flakiness
Task-number: QTBUG-122469
Change-Id: If8b0d7441af10c8aad876098c6744777696b3358
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This object represents a frame on a web page, e.g. a <frame> or <iframe>
element.
Frames can be found through QWebEnginePage::mainFrame()
and findFrameByName(). Also provides some basic getters
on QWebEngineFrame and tests.
Change-Id: If3905c6ecd14cf6c3508c65edc98f49415739489
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Verify network access before running the test.
Task-number: QTBUG-124558
Change-Id: Ida7825854074b9c29d5f0b6db6613d4997e450f8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][QtWebEngineCore][QWebEngineNavigationRequest] hasFormData
has been added to indicate navigations request (re)posting form data.
Fixes: QTBUG-67613
Change-Id: I0275513a12d4591a53040c62bfce636e99926ab7
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The localFontAccessPermission test was occasionally failing to
acquire transient user activation, and thus failing. This change uses
an event hander for when a button is pressed, ensuring the activation
is acquired.
Change-Id: Iddafa92b7a7e8ea415a73dff8685691b6b39fef4
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to QUIP-18 [1], all build system
files should be BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I2f13ceaa8eb68b7745cffc66651f892c1fbeeff2
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Previously WebContentsAdapter assumed that drag-n-drop MIME data with
hasUrls() == true would also have a nonempty url list. This is not
always the case. Instead, check directly if urls() is nonempty.
Pick-to: 6.7
Fixes: QTBUG-123765
Change-Id: I9e2189e3f0223f98bdd8be273adb96cf063f4be3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
API has changed since b6dd845ec4a6bfb6b620686681e20d38a2f24101, and this
test wasn't included in CMakeLists so we haven't been running it. Now it
checks search result rectangle bounds. The new test PDFs are from the
pdfium repository https://pdfium.googlesource.com/pdfium and include
different kinds of transforms (the Tm command apparently).
Pick-to: 6.7
Task-number: QTBUG-120764
Change-Id: I25cf5944dd227dd4d2c70cbbac470d1d0fcc181a
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
| |
Change-Id: I39bba6769b39e4685fbef10e19f0b1956b62208f
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use FPDF_PageToDevice() rather than subtracting from page height,
in all the remaining places where we were doing that.
Also use FPDF_DeviceToPage() to convert coordinates coming from
the view, for hit-testing links and for selecting ranges of text.
Mark the private utility functions that we're modifying const
while we're at it.
Pick-to: 6.5 6.6 6.7
Task-number: QTBUG-100630
Fixes: QTBUG-106565
Change-Id: Ide4f73b80888a0e08381c6e4995f69ebeaa2d12f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
| |
This change hooks up QuickWebEngineView to the newly-enabled local font
access API.
Task-number: QTBUG-121320
Change-Id: Ib7e093904ea8d834a2282cd265086e501cb392ff
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Unused parameters
Change-Id: I1c300daefc5461aa692f8624d6af7c5f9ce80464
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accessing local fonts on the user's machine has been available in
Chromium since v103, via a (draft) API descrived here:
https://developer.chrome.com/docs/capabilities/web-apis/local-fonts
This change adds support for the relevant notification types,
effectively exposing the API to WebEngine applications.
Task-number: QTBUG-121320
Change-Id: I42c5261dc689c3d7bb4aa3c58c6300421220a36a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, permissions for clipboard access could only be managed
through the JavascriptCanAccessClipboard and JavascriptCanPaste
settings. This change allows copy/paste to be handled the same way
as notification and geolocation permissions.
If both JavascriptCanAccessClipboard and JavascriptCanPaste are
enabled, permissions will be granted unconditionally without a
feature request being made.
Fixes: QTBUG-77450
Change-Id: I383e27e244ced3d6b7988644e38d2307c6267f76
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
- added a method to set image animation policy in QWebEngineSettings
Fixes: QTBUG-86154
Change-Id: I8b3ab6067f9cff4219b0da90bb8601406cb98e24
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Mouse events will miss the hittesting if they are sent
before the page is drawn.
Introduce new test page that listens for first paint events.
Pick-to: 6.7 6.6
Change-Id: I4846ec1bde3805f5dd0098d490cb85c72cb0884f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I0cc532c63f900b3bd56268a4d8a7132d3caea4f7
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Was missing from the QML settings.
Change-Id: I585fd7906b6831d9cf1c560427be18b1d76fd8ca
Fixes: QTBUG-85473
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QWebEngineCookieStore::setCookie was incorrectly validating cookies
after an API change in chromium; this would lead to cookies being
considered always valid which could crash if validation failed.
This commit updates the API call and adds a test to check that
invalid cookies are no longer added.
Pick-to: 6.7 6.6
Change-Id: I6fc4268a483c9495c19843f3a7b16b4f234633b4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many Qt Quick tests choreograph event delivery with
QQuickTouchUtils::flush(&window);
but that uses private API. To avoid linking Qt Quick Private, disable
touch compression completely, so that QTouchEventSequence::commit()
causes the touch event to be fully delivered immediately. Amends
25fd2017f82bf25991feec2e5cceb21ceda4da15
Fixes: QTBUG-121564
Change-Id: I1802b56fba7b4e3be6948fa96e1c53ba0fba8739
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-84884
Change-Id: I2796ba53dc512aa27ab64911154237d89e1f5271
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PdfMultiPageView does not expose a property alias to TableView.rows;
we could call it pageCount, but we don't want to mislead users into
thinking that the view is the "source of truth" for how many pages
it's going to show. The document's pageCount is populated earlier,
and that's a problem only in such a case when it's too early to ask
the view to go to a particular page. So we work around it in the
view by treating these goTo functions as requests to be satisfied
as soon as it becomes possible.
Fixes: QTBUG-119416
Pick-to: 6.5 6.6 6.7
Change-Id: Ie2377fe6f2983b72e871b1be2afe4d0878f60841
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.5 6.6 6.7
Task-number: QTBUG-120245
Change-Id: I4d3478a6243e9fb0c6ccc872f471c7d09dc7eb3e
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pinch.persistentScale is settable since 6.5 (qtdeclarative
a432970b258edb9ff041d221b2155df30cad4799): we need that to tell
PinchHandler to start over from 1 after we have also set the rendered
scale back to 1, because PinchHandler does not read the scale property
for itself.
Fixes: QTBUG-115502
Pick-to: 6.5 6.6 6.7
Change-Id: I21951c447bf33e5942b6a1635488d5474ec8f293
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
With Qt 6, QPageSize::PageSizeId enum was cleaned up and some values
were reordered, but the WebEngineQuick part was not changed accordingly.
Pick-to: 6.7 6.6 6.5
Fixes: QTBUG-120218
Change-Id: I7e4c419750d30a64193e68b0b217ebbccce07d87
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Port the request's d-pointer to std::unique_ptr
- Disable copy of the request
- Remove QWebEngineMediaSourceModel from the header
- Remove the NameRole definition
- Update tests and documentation according to changes
- Use forward declaration in qwebenginepage
Pick-to: 6.7
Change-Id: I972b3104a0bca5367a4bb63ac183a60d00a71776
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
- Modified WebAuthUXState as enum class
- Renamed QWebEngineWebAuthUXRequest as QWebEngineWebAuthUxRequest
- Renamed QWebEngineWebAuthPINRequest as QWebEngineWebAuthPinRequest
- Replaced all occurrence of UX and PIN with Ux and Pin respectively
Fixes: 6.7
Change-Id: Iaf0b4c93e0dfa3508a604f7d6562c4401ff800af
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Test chooseDesktopMedia extension API.
Pick-to: 6.7
Task-number: QTBUG-85731
Change-Id: I2479297b2ccd45bd28bdbe6e9157ad67d0a15739
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During input composition, the cursor is set to the starting position of
the string being edited and refrain from updating it throughout the
composition process. Once the string is committed, it is set to the last
position of the committed string. The modified code is designed to
exhibit the same behavior as the widget and quickwidget.
Fixes: QTBUG-118746
Pick-to: 6.5 6.6 6.7
Change-Id: I9adb7a9bea9493457a1d9d4b32338cdba30920a1
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebEngineDriver is a modified ChromeDriver and provides the same
functionality.
[ChangeLog][WebEngineCore] Added WebEngineDriver
Fixes: QTBUG-82046
Task-number: QTBUG-86869
Change-Id: Ib8a40e1f6ca883efa6776c647a5b57d2930593ae
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit 613be810df6b6e83d64ceb015aaabf28e41d34da)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plain Image is ok for loading one PDF page at a time, except that the
pdf plugin has to create its own PDF document object if it cannot reuse
an instance that is already open. So PdfPageImage was created just as an
optimization, with the expectation that the document will be given to
the document property. But in case someone doesn't understand and tries
to set only the inherited Image.source property instead, fall back to
QQuickImageBase::load() to avoid crashing. Amends
7b8832ca2b84d549c9d374550c3c46b3d4d42a38
If both the document and source properties are set, prefer the document
(for the sake of performance).
Add test coverage of other combinations of properties, while we're at it.
Pick-to: 6.5 6.6 6.7
Fixes: QTBUG-104767
Task-number: QTBUG-77506
Change-Id: I1ee0d0bb2a6c5f399234ddddd969be02e7a6c020
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without the include module build with BUILD_TESTS=ON
is broken as cmake function call for dictionary setup is not
found.
This commit amends 73d58b489e8f4f900042f0ab6c1104e6431752e1.
Pick-to: 6.5 6.6 6.7
Change-Id: I2c02317b92e1b5726963d120bf97dff1a12c7375
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the plugin finder logic everywhere to match with Chrome. This
comes with a small cleanup: collect PDF-related helper functions
scattered around WebEngine in one pdf_util_qt implementation.
Add auto test to catch this recurring issue earlier.
Pick-to: 6.5 6.6 6.7
Task-number: QTBUG-119878
Change-Id: I03b2bd62bebf5b38afc572e0629db106d024e89d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][WebEngineCore] Add QWebEnginePage::desktopMediaRequested() signal
[ChangeLog][WebEngineQuick] Add QQuickWebEngineView::desktopMediaRequested() signal
Pick-to: 6.7
Fixes: QTBUG-112142
Task-number: QTBUG-70077
Change-Id: I4bfad88732b45fb68b77f7617440bcb50b248a11
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Implement QWebEngineClientHints class to provide API for each
user agent client hints.
Task-number: QTBUG-112826
Task-number: QTBUG-112825
Change-Id: I3091d60fb363bbafc16c8e48195c1fd82e8a81bb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I8eea99a472cc597ff9864b570c90b28b79b3751e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
Apparently didnt affect test results though
Pick-to: 6.6
Change-Id: I86809e6287ba7ca80209146c73a0cc0d523756ac
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
| |
Add missing header include.
Do not compile global setting tests as it tests so far
only doh and requires ssl.
Fixes: QTBUG-119525
Change-Id: I011cd3b0ed6e9d5e55e1fc80a102cc7a388681f1
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
- DCHECK hit while running tst_QQuickWebEngineViewGraphics test.
- Added qWaitForWindowExposed() to wait for the windows, and then perform the verification.
Pick-to: 6.6
Change-Id: Ia5c2dba5f1c38ae06e7aac24f0f6d5f3d6f5859d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
| |
Not only tables can have cell as a child.
Pick-to: 6.5 6.6
Fixes: QTBUG-119023
Task-number: QTBUG-113859
Change-Id: Ic997f752059f5ac3cac9a7d7cf1fefcecbc2ddd5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a QWebEngineUrlRequestInterceptor has added extra headers to
the request on profile level, later the request was not processed
by the page interceptor. Relax this rule and only prevent the
interception of blocked or redirected requests.
Add auto test and extend documentation.
Pick-to: 6.6
Task-number: QTBUG-117752
Change-Id: I503bfc256a5e874a678be64c597c74e04e7ce966
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The pointer to the page interceptor is stored in WebContentsAdapter
and we lose it when recreating the adapter. Prevent this and add
auto test.
Fixes: QTBUG-117867
Pick-to: 6.6
Change-Id: I5e79cdcc5996bdf2bb53c3016d4133f978ccfb39
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have constant crashes on apple m1 with those test,
skip it for now.
Verify window in comboBoxPopupPosition* tests.
Pick-to: 6.6
Change-Id: I4b9744fbcae556bc8d17e7602d003f306f54c62d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling QWebEngineDownloadRequest::cancel() had no effect if the download
request was accepted by default. These downloads had no corresponding
internal DownloadItem yet, but we tried to cancel them using the
DownloadManager. The safest option is to always check if the DownloadItem
exists in Chromium.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: I8f92d45e00e088aea7d22d5b7271b5b09adf6cbb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Duplicate entries in the QML type file are created when exporting the type as a value and its enums within a namespace.
Resolved this by introducing a derived class, and using it for exporting the Enums.
- Added namespace resolution to avoid type ambiguity
Fixes: QTBUG-117031
Pick-to: 6.6
Change-Id: Ieea4492238843c3c781c8d9602ddc89207b61137
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Images and PDFs had to be explicitly accepted to download, even if a
filePath was given as argument of QWebEnginePage::save(). This behavior
was inconsistent with saving HTML pages (and the documentation).
Adjust the corresponding test case with verifying the download result
of an auto-accepted download, and add a new test case to make sure about
downloads are not accepted by default when there is no desired filePath.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: I90f4cfa485da2831327bcb25571a0b69499d9006
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the filePath argument of QWebEnginePage::save() is ignored
when the user tries to download anything but HTML; and the requested
download path is the Downloads folder of the OS.
Fix this and adjust the corresponding test case with checking path
and file name of the download request.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: Ia1d3afc898b1aad223aab772b775724a50e88bd3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Fix a race-condition in our tests that the change exposed
Pick-to: 6.6
Task-number: QTBUG-116478
Change-Id: Id21c6b0bc9934fdcb69bd85350f5f263a9b96914
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium introduced the Initial NavigationEntry that meant to
represent the initial empty document at FrameTree creation time.
It is just a placeholder entry put in the list of NavigationEntries
that gets replaced on the next navigation.
A side effect of this is that we have an extra entry in the list before
we load any page.
This change also reverts the history related tests modified by
106 Adaptations that introduced this behavior.
Fixes: QTBUG-117489
Pick-to: 6.5 6.6
Change-Id: I2738591b681082792544bd884f8ecec54ce9d72d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|