| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do comments from api review:
* use static setDnsMode
* use struct for mode and server templates
* remove QObject
* do not use QScopedPointer
* use the namespace instead of the class
Pick-to: 6.6
Change-Id: I766626330e4cc190a170fcd6b5e32b1f60ad675c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
To allow duplicate key values and preserve order within multi key
duplicates
Pick-to: 6.6
Change-Id: I8da0a3441255c9b72256d63f4ede10491c96c2dc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
For consistency with other response headers, even if it is going
to be inconsistent with existing request headers.
Pick-to: 6.6
Change-Id: I9e9c36ac20982d9c833486171fa9944c9059f471
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It has been found to not have any real effect, therefore, we remove it
again to not release a non-functional API and create false expectations
in users.
This reverts commits
3f5de5fab74e6c152cdf5d04f3d893feaa31790b
ab21f39c6a54be331dd8a155d3374bfe790e0274 (parts)
082eef1916a86d6d5e0c751d271c7c8a1a5e457d
5e257fb57a211f95556ec387fe6f262a60cbb6fe
Pick-to: 6.6
Task-number: QTBUG-61071
Change-Id: Ifb33e32128e77dfffed863a1a7501ba21796692d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The density of Q_FOREACH uses is non-negligible here, too high for
this author, still unfamiliar with this module, to tackle in a short
amount of time. But they're concentrated in just a few TUs, so pick a
different strategy:
Mark the whole module with QT_NO_FOREACH, to prevent new uses from
creeping in, and whitelist the affected TUs by #undef'ing
QT_NO_FOREACH locally, at the top of each file. For TUs that are part
of a larger executable, this requires these files to be compiled
separately, so add them to NO_PCH_SOURCES (which implies
NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115805 to keep track of
this.
Task-number: QTBUG-115805
Change-Id: I7a80b1820972687ccced24d9edd7a8f5b826556f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][QtWebEngineQuick][WebEngineProfile] Added
clearHttpCacheCompleted signal.
[ChangeLog][QtWebEngineCore][QWebEngineProfile] Added
clearHttpCacheCompleted signal.
Fixes: QTBUG-89670
Fixes: QTBUG-111541
Change-Id: If93a99f7171c516ef75a3c8004da9ae621705a1a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Naviagte away from reload.html as it may reload
multiple times.
Task-number: QTBUG-105342
Task-number: QTBUG-116165
Change-Id: I5dc6b7eeb9827a13752f476f2e3b0c415cedbb43
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We kept urls in examples to point to company website.
However this site is heavy to load and moreover it changes
overtime leaving example screenshots obsolete.
Introduce internal qt version web ui page which will
be default page for examples and which displays basic
information and can work offline.
For start show version info and command line options
for chrome://qt
Pick-to: 6.6
Change-Id: I0271ce6e7b152efe4942a6240b0c74ba382d5fcc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
We prefer to name settings with Enabled at the end.
From API review.
Pick-to: 6.6
Change-Id: I7aacc6dbb92d852fd21b067475d2fd9e7df56163
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch improves the DNS-over-HTTPS configuration and sets defaults
for the general DNS logic. The following changes are included:
- Insecure Chromium DNS client is always OFF (OFF is the Chromium
default as well)
- Add DnsMode::SystemOnly, which configures Chromium to only use the
system DNS
- The default DNS configuration is DnsMode::SystemOnly
- Rename DnsMode::Secure to DnsMode::SecureOnly and
DnsMode::WithFallback to DnsMode::SecureWithFallback to be clearer
what each enum value does
- Add error handling for invalid URI templates
- Added test cases to handle the new logic
- Some minor refactoring for cleanup purposes with the new defaults and
logic taken into consideration
- Some minor bug fixes
Task-number: QTBUG-98284
Pick-to: 6.6
Change-Id: Ie332166f8b5b83c8939af35e4eb8b69b417abdcf
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- test_findTextInterruptedByLoad:
Remove whitespaces from the text as it takes lot
of time to render according to perf.
It should fix the timeout errors.
- loadStartedAfterInPageNavigation:
Remove the viewport meta tag from test.html.
The 2x scale is only applied in embedded builds,
it puts some elements out of the view.
- acceptNavigationRequestNavigationType:
Refresh the reload.html page only once.
On qemu it may reload multiple times messing up
the list of navigation types.
- horizontalScrollbarTest:
Skip instead of blacklist.
- tst_qtbug_110287:
Use an url that loads faster.
Pick-to: 6.6
Task-number: QTBUG-105342
Change-Id: Ifbd41885fee62b12f7022534f9b8bd5e20cbef01
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
The error page is not relevant for the test but it can significantly
slow down the test because of the embedded javascript.
Pick-to: 6.6
Change-Id: I8b7e876f74110f758c5a23579018c598a29ba1e2
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The accessibility tree serialization may happen before the layouting is
completed. This means that during the serialization some children may
have not been created yet and results different roles for elements.
It has been broken by enabling the TimedHTMLParserBudget optimization:
https://crrev.com/c/4152859
Pick-to: 6.6
Change-Id: I798a8ed5bd704a6900c7b56f462091b79a12815d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtPositioningHelper now uses the Qt Permissions API. Also fixup the
examples Simple Browser, Quick Nano Browser and Maps to use the right
key on macOS and sign the application as part of the build process
Moves the Geopermission auto tests to manual tests for webenginequick
and webenginewidgets on macOS.
Pick-to: 6.6
Fixes: QTBUG-114939
Change-Id: Id6771889f20c866d2fcdbb477dbbb7da30367043
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Additionally make destructor out of line in
qwebengineurlrequestinterceptor as it mirrors
qwebenigneurlresponeinterceptor.
Pick-to: 6.6
Change-Id: I0cdf7eae9faa671415359368560fb8f6aabf05fe
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
- Implemented AuthenticatorRequestClientDelegateQt support to handle authenticator requests.
- Added FIDO user verification and resident credential support
Fixes: QTBUG-90938
Fixes: QTBUG-90941
Change-Id: I6367791e1e9e8aaac27c376408377f838832f426
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
The wait took too long. Rewrite it to be race safe, and increase timeoue.
Pick-to: 6.6
Change-Id: I18c8e17621502bfcfaa739d900ea64e33d0678f6
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the invalid 'width' attribute the input element
defaults to a size that depends on the system (charmap) settings.
It may result in failing tests that depend on the size of the element
e.g. tests that use 'elementCenter'.
Pick-to: 6.5 6.6
Task-number: QTBUG-105342
Change-Id: I508d365fc4240d67d3e2240e8e33495c1de6ee4c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.6
Change-Id: I1bb84b20a080d7f615bf0795ac2d97739e99ac1d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.6
Change-Id: Ibe750d541dba458f2278632355bcaf864fdc845a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
ICU has to be initialized to make it work.
Pick-to: 6.6
Change-Id: Icff7cd4d7b93768d46c02612d9f477bfc2b6230e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a WebView or WebEngineView gets a mouse or touch grab, we don't want
to give it up to any handlers that may be lurking on Items underneath.
WebView is opaque, so we don't know whether the user is trying to drag a
scrollbar or something else, but interactive items outside shouldn't
interfere, in general.
[ChangeLog][QtWebEngineQuick] WebEngineView (or WebView backed by Qt
WebEngine) no longer allows components outside to take over the mouse or
touch exclusive grab. For example if the user starts dragging a
scrollbar inside the web view, that continues until release, regardless
of any DragHandler, Flickable etc.
Fixes: QTBUG-103518
Pick-to: 6.5 6.6
Change-Id: I4352dc8482020f0efc7a0901e94ccf7fc147fa1b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
Add ResourceRequestBody to QWebEngineUrlRequestJob, thus exposing the
request body to custom URL scheme handlers.
Fixes: QTBUG-67055
Change-Id: I0a31dfdbb4e3353dc1e469234ba452a0cbfd5965
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
This patch implements a QIODevice subclass that gives access to the
request body inside QWebEngineUrlRequestInterceptor::interceptRequest().
Fixes: QTBUG-61320
Change-Id: Ib6010dad908c65e070d63927b619eaed2347e317
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The pdfquick subdir was added when the target Pdf was found.
This breaks the build if PdfQuick is not compiled.
=> make adding the subdir conditional to PdfQuick.
Pick-to: 6.6 6.5
Change-Id: I9f46d4254c402f7f1dbde8a899edffd3f8b21c4e
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Invalid proxy settings may result in a crash in chromium.
Use chromium's helper function that validates proxy configs
instead of constructing net::ProxyServer manually.
On invalid input, result will be a `SCHEME_INVALID` ProxyServer.
Fixes: QTBUG-113992
Pick-to: 6.5 6.6
Change-Id: I1745ae3c3cd4da40d3d8b92a14f752ac9b3f8d31
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Make the constructor explicit, add explicit external destructor.
Use QMultiMap instead of QHash for request headers, as those can
potentially be repeating.
Pick-to: 6.6
Change-Id: Id1730b015971287e63562ac67cfa964f2abbb7cc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A user can create QKeyEvent which may have too long
QKeyEvent::text and does not fit into null terminated blink
WebKeyboardEvent::text. Till now the text was mem copied
however without null-termination if it was too long
(which is char16_t[WebKeyboardEvent::kTextLengthCap])
It seems that real keyboard events do not generate any 'key.text'
for modifiers, however user can provide any text (for example
in the form of 'shift' 'control'). Therefore 'alt' still
worked as we had 16 bytes of space but 'shift' was already
too long.
In case we can not fit into blink web keyboard event text
with null terminated string simply skip the text
as it is not there in the first place in case of non-user
generated key events. This way the text is always
null-terminated.
Pick-to: 6.6 6.5 5.15
Fixes: QTBUG-113704
Change-Id: Ib1560a44e7451ab7d886c72338b7433fc51318ed
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Since 67d0c0821 in declarative strings are not longer converted
to QStringList in case of c++ calls. Be explicit now.
Fixes: QTBUG-114339
Pick-to: 6.6 6.5
Change-Id: I644a50eea6640d751d81a5a21f478577d4c999cb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Do not prevent access to files when users navigate by user gesture,
reload, or navigate the main frame back and forward in history.
Task-number: QTBUG-113413
Task-number: QTBUG-113485
Change-Id: I942362f7048618dac7a067c8713285deb4ca06f5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
[ChangeLog][WebEngineCore] Add QWebEnginePage::devToolsId()
[ChangeLog][WebEngineView] Add devToolsId property
Change-Id: I16e8a27d595b010239557c2a3af2d3b39976cd46
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Does not fix the underlying issue, but may give us more meaningful
information about the seemingly random crashes we have seen on the CI.
Change-Id: I239fd05bf6a7add38e17830aad59f961036871d9
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
- Added testcase to test WebWindowType parameter in CreateWindow.
Fixes: QTBUG-112645
Pick-to: 6.5
Change-Id: I4f6bf452afcceeaa67ff07b879a2acd836bd8fac
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Increase the timeout for load function as it tries to use network.
Do not allocate HTTPS server on heap as in case of failure
it is never deallocated and next test also fails.
Fixes: QTBUG-113350
Change-Id: Ifab6045afeb694a2b457604fa4d9e9c002483659
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Yigit Akcay <yigit.akcay@qt.io>
|
|
|
|
|
|
|
|
| |
[ChangeLog][WebEngineCore] Add qWebEngineGetDomainAndRegistry()
Fixes: QTBUG-105294
Change-Id: Ica40453f807b00c8548f974a495ddf84bbe8e194
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
| |
Only the main frames should administer scripts associated with it.
Pick-to: 6.5
Fixes: QTBUG-113109
Change-Id: Ibda66f55ef99da632134a9de1425797262faba9b
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Martin Negyokru <negyokru@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement QWebEngineGlobalSettings, a singleton class that contains
global web engine settings (currently only for DoH).
Allow the user to configure the stub host resolver to enable
DNS-over-HTTPS.
Fixes: QTBUG-98284
Change-Id: I1b06737c84e1b8d613aa257f4a891f82cac21013
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
- disables reading from canvas.
Fixes: QTBUG-84486
Change-Id: I3e181bfa6e351dea8dfa61f8010bafb94ea8a77d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QPdfPageNavigator did not emit the page history signals when pages were
jumped.
This patch ensures correct signal emission in all cases.
It adds a new auto test class for QPdfPageNavigator.
Fixes: QTBUG-112614
Pick-to: 6.5 6.2
Change-Id: I67af5a4d22a8e76b9c12c72c168fa5b3b4390f2c
Reviewed-by: Yigit Akcay <yigit.akcay@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Add the convenience method QQuickWebEngineView::save for saving pages without
the need to explicitly handle download requests.
Task-number: QTBUG-56093
Change-Id: I67909fdca6472d1ea9b32e0f89c1ab90219bca3b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Document the fact Stop WebAction can interrupt the in-progress PDF
generation.
- Update PrintViewManagerQt::PrintPreviewDone(): Normally
IsPrintRenderFrameConnected() implies IsRenderFrameLive(), but we have
to check both to avoid crash when render process exits. (Like Chrome
does.)
- Update PrintViewManagerQt::RequestPrintPreview(): Handle that case when
print preview params were sent between processes at the beginning, but it
was interrupted before RequestPrintPreview() could start PDF generation.
- Add a simple auto test to catch crashes
Pick-to: 6.5
Task-number: QTBUG-108154
Change-Id: I8a4f9cc97ddcf9a165d66a5981d93a023858fbc1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
According to ci this test would succeed in 13000ms on qemu.
Fixes: QTBUG-111939
Change-Id: I21911920961a885eee38dcd3261e46b497a1c251
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
(cherry picked from commit f576588c85f4f635d38f56a1db087a50c19add42)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the QWebEngineUrlResponseInterceptor abstract class,
which, when implemented, allows a user to intercept response headers and
modify them in any way they like.
A response interceptor can be set via
QWebEngineProfile::setUrlResponseInterceptor(),
QQuickWebEngineProfile::setUrlResponseInterceptor() or
QWebEnginePage::setUrlResponseInterceptor().
Also, the QWebEngineUrlResponseInfo class is implemented, which contains
the request and response data to be used with the response interceptor.
If a response interceptor is set in the profile and page, the one in the
profile takes precedence.
Fixes: QTBUG-61071
Change-Id: I484d14373ff597b1d531541c066f0102bae28c72
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In qml url can have different schemas like 'qrc'
'file' 'assets'. Make correct conversion so
file can be loaded.
Note check isLocalFile() is not true for qrc scheme.
Fixes: QTBUG-106072
Pick-to: 6.5.0 6.5 6.4
Change-Id: I4dcc969e4c6d9b3f58ea5d81d20d8e81b55edfde
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
QQuickWebEngineProfile already initializes totalBytes.
Also clean up QWebEngineDownloadRequestPrivate and fix typo in
documentation.
Pick-to: 5.15 6.4 6.5
Fixes: QTBUG-104869
Change-Id: I8c4b79c076ddc63180960e22a9488b45ff6c4402
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are three functions we use within file systems API, which
trigger dialogs:
* window.showSaveFilePicker
* window.showOpenFilePicker
* window.showDirectoryPicker
Only first one was tested with widgets, therefore add tests which cover
use of api, and also test cover the found issues in previous commits.
Note we have separate test to cover file system dialogs coming from
<input> html tags in tst_filePicker
Pick-to: 6.5 6.4
Change-Id: I4616efa84688ed471fb8c4566e49262bce945638
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Make cmake aware of test data, this will make data
deployable on android.
Task-number: QTBUG-83459
Change-Id: Id4271f54f8351e955a6ee57c3a36656d69a2a682
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Password test does not pass on emulator, the same issue
exists already on windows.
Navigation uses hardcoded values for event which ends with
"Mouse event at 465, 65 occurs outside target window (320x616)"
due to smaller screen of android emulator.
Blacklist tests for now.
Task-number: QTBUG-83459
Task-number: QTBUG-106072
Task-number: QTBUG-111306
Change-Id: Iacc4c7711d58b0ffb6cdda3474b4d59b628ca5f7
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Implement WebActions to temporarily change text direction directly from
context menu - like Chrome does. They only work for the selected input
field. Omit the "default" option since it is always grayed out in Chrome.
Task-number: QTWB-67
Change-Id: I4bacbd82c6bd7261ac465eec9da3776613f98074
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I6ebd403a3affae8bfbc5afee9d528664fb08122c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|