summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIsmo Haataja <ismo.haataja@digia.com>2014-10-20 15:39:16 +0300
committerIsmo Haataja <ismo.haataja@digia.com>2014-10-21 07:05:48 +0200
commita7124b38f54423d2a85b82e02dbb41564e2838ef (patch)
treee104cdd9538945544cec9d84181a0494fc443f91
parentac81a6ee1447e98e08e83f182d4c8ca4af9a0345 (diff)
Fix NPE in staging approve command
The class member variable 'emailMessages' was never properly allocated and this caused NPE (null pointer exception) when accessing it. Task-number: QTQAINFRA-905 Change-Id: I99d91a3345ca6ef8b05d4b0436929fff33d7e2da Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
-rw-r--r--gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java
index e1959ca8d3..c44754e37b 100644
--- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java
+++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java
@@ -217,7 +217,7 @@ public class StagingApprove extends SshCommand {
}
// Create list for possible email notification messages sent to user at the end
- List<ReplyToChangeSender> emailMessages = new ArrayList<ReplyToChangeSender>();
+ emailMessages = new ArrayList<ReplyToChangeSender>();
// Use current message or read it from stdin.
prepareMessage();