diff options
| author | Patrik Teivonen <patrik.teivonen@qt.io> | 2022-08-29 10:01:04 +0300 |
|---|---|---|
| committer | Patrik Teivonen <patrik.teivonen@qt.io> | 2022-09-06 07:05:24 +0000 |
| commit | b572d10a9d12bd2d983fdaf57de4ec3050e6d800 (patch) | |
| tree | 9d27768240ef1caa252428c44676d089caee589b /packaging-tools/create_installer.py | |
| parent | d4c144513ee9813bac5f8a2207516bb48b9035fe (diff) | |
Reduce use of module globals by wrapping code outside functions in main
-Move code from module scope to main() functions where it makes sense
-Pass module variables as arguments to functions that used them
Linters will complain about naming clashes in outer scope if same name
is used in a function.
Change-Id: I1319cf1632f94907ee918e6f7593c79b0909e48b
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Diffstat (limited to 'packaging-tools/create_installer.py')
| -rw-r--r-- | packaging-tools/create_installer.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/packaging-tools/create_installer.py b/packaging-tools/create_installer.py index 81c155e6e..cb36da8fc 100644 --- a/packaging-tools/create_installer.py +++ b/packaging-tools/create_installer.py @@ -1079,7 +1079,8 @@ class QtInstallerTask: log.info("IFW tools extracted into: %s", self.ifw_tools_dir) -if __name__ == "__main__": +def main() -> None: + """Main""" parser = argparse.ArgumentParser(prog="Script to create Qt Installer Framework based installers.") parser.add_argument("-c", "--configurations-dir", dest="configurations_dir", type=str, default="configurations", help="define configurations directory where to read installer configuration files") @@ -1142,3 +1143,7 @@ if __name__ == "__main__": task = QtInstallerTask(args) task.verbose() create_installer(task) + + +if __name__ == "__main__": + main() |