diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2019-03-12 16:50:39 +0100 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2019-03-15 14:47:18 +0000 |
| commit | d4565be6557fca844dcf4bf427e0ff9c0838df50 (patch) | |
| tree | ea002e07fe7f0ea29113b64ebabf03233e2813d5 /src/plugins/projectexplorer/kit.cpp | |
| parent | e80d83cb20cfd57ce9bbb059f6f5b7cb6c86d416 (diff) | |
ProjectExplorer: Drop KitAspect::defaultValue()
The functionality of this function overlapped with KitAspect::setup(),
leading to unclear responsibilities and resulting in bugs such as the
one fixed by 776d54e435.
Therefore, we drop the defaultValue() function, merging its
implementation with setup() where applicable.
Change-Id: Iefa9c3df8b76e97ddf9ad388516621f7ea6558d4
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/projectexplorer/kit.cpp')
| -rw-r--r-- | src/plugins/projectexplorer/kit.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/plugins/projectexplorer/kit.cpp b/src/plugins/projectexplorer/kit.cpp index cc0ca3a39f..ddc4d00c7c 100644 --- a/src/plugins/projectexplorer/kit.cpp +++ b/src/plugins/projectexplorer/kit.cpp @@ -137,8 +137,6 @@ public: Kit::Kit(Id id) : d(std::make_unique<Internal::KitPrivate>(id, this)) { - for (KitAspect *aspect : KitManager::kitAspects()) - d->m_data.insert(aspect->id(), aspect->defaultValue(this)); } Kit::Kit(const QVariantMap &data) : |