aboutsummaryrefslogtreecommitdiffstats
path: root/sources/pyside6/libpyside/pysideslot.cpp
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2023-08-28 15:20:30 +0200
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2023-08-30 11:45:15 +0200
commite39a383766aa1c73e94d948d6e3a3bd20729f19b (patch)
treea77bbab4b9124ed23e7d6795cca8665766707684 /sources/pyside6/libpyside/pysideslot.cpp
parentf21dd80f7cab5ce6510336be3362166610d6932c (diff)
libpyside: Use a static string for the slot attribute attached to methods
Task-number: PYSIDE-748 Change-Id: Ieeeb2c1c392706a5c74bf29ff67ff4ddd8c4feaa Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysideslot.cpp')
-rw-r--r--sources/pyside6/libpyside/pysideslot.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/sources/pyside6/libpyside/pysideslot.cpp b/sources/pyside6/libpyside/pysideslot.cpp
index 9b0f1f4e0..32f629ade 100644
--- a/sources/pyside6/libpyside/pysideslot.cpp
+++ b/sources/pyside6/libpyside/pysideslot.cpp
@@ -3,6 +3,7 @@
#include "pysidesignal_p.h"
#include "pysideslot_p.h"
+#include "pysidestaticstrings.h"
#include <shiboken.h>
@@ -95,7 +96,6 @@ int slotTpInit(PyObject *self, PyObject *args, PyObject *kw)
PyObject *slotCall(PyObject *self, PyObject *args, PyObject * /* kw */)
{
- static PyObject *pySlotName = nullptr;
PyObject *callback = nullptr;
if (!PyArg_UnpackTuple(args, "Slot.__call__", 1, 1, &callback))
@@ -117,11 +117,9 @@ PyObject *slotCall(PyObject *self, PyObject *args, PyObject * /* kw */)
const QByteArray signature =
returnType + ' ' + data->slotData->name + '(' + data->slotData->args + ')';
- if (!pySlotName)
- pySlotName = String::fromCString(PYSIDE_SLOT_LIST_ATTR);
-
PyObject *pySignature = String::fromCString(signature);
PyObject *signatureList = nullptr;
+ PyObject *pySlotName = PySide::PySideMagicName::slot_list_attr();
if (PyObject_HasAttr(callback, pySlotName)) {
signatureList = PyObject_GetAttr(callback, pySlotName);
} else {