diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2023-06-22 14:58:11 +0200 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2023-06-23 09:51:54 +0000 |
| commit | cf6bd7e0124f31374f3a4abd05d14199d201961b (patch) | |
| tree | 90ce2081bdea0b7bece256bd00c0d0476171e00f /src/plugins/cppeditor/cppchecksymbols.cpp | |
| parent | ae33199d046902bb9877810df2dbc590b083ef3c (diff) | |
Fix occurrences of the contains/insert anti-pattern
Introduce and make use of Utils::insert() for QSet with a return value
that indicates whether insertion actually happened.
Change-Id: I655e4bc3553b74fea5ae8956205e4d8070118d63
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/cppeditor/cppchecksymbols.cpp')
| -rw-r--r-- | src/plugins/cppeditor/cppchecksymbols.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/plugins/cppeditor/cppchecksymbols.cpp b/src/plugins/cppeditor/cppchecksymbols.cpp index 7728ea308c..e9334b0db2 100644 --- a/src/plugins/cppeditor/cppchecksymbols.cpp +++ b/src/plugins/cppeditor/cppchecksymbols.cpp @@ -73,9 +73,7 @@ protected: { if (!doc) return; - if (!processed->contains(doc->globalNamespace())) { - processed->insert(doc->globalNamespace()); - + if (Utils::insert(*processed, doc->globalNamespace())) { const QList<Document::Include> includes = doc->resolvedIncludes(); for (const Document::Include &i : includes) process(_snapshot.document(i.resolvedFileName()), processed); @@ -806,8 +804,7 @@ bool CheckSymbols::hasVirtualDestructor(ClassOrNamespace *binding) const while (!todo.isEmpty()) { ClassOrNamespace *b = todo.takeFirst(); - if (b && !processed.contains(b)) { - processed.insert(b); + if (b && Utils::insert(processed, b)) { const QList<Symbol *> symbols = b->symbols(); for (Symbol *s : symbols) { if (Class *k = s->asClass()) { |