aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp
diff options
context:
space:
mode:
authorChristian Kandeler <christian.kandeler@qt.io>2021-05-28 13:12:00 +0200
committerChristian Kandeler <christian.kandeler@qt.io>2021-06-11 13:57:01 +0000
commit7275402ce9ac56d7a208aaea1fe1e99ca01c43a2 (patch)
tree1a6dbc325a219946a052d3153111ac3a200c9cbe /src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp
parented426f041d03dbecde512f3b51b3ce634d9c05a1 (diff)
ClangCodeModel: Fix links for virtual overrides
For some reason, clangd returns the declaration instead of the definition position in the "Goto Implementation" result, so we have to do another look-up for each override. Change-Id: I2a99eb0dacdea07d5882087445dc2b2d61b24e58 Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp')
-rw-r--r--src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp8
1 files changed, 1 insertions, 7 deletions
diff --git a/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp b/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp
index 32c0f27186..75f7049747 100644
--- a/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp
+++ b/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp
@@ -516,14 +516,8 @@ F2TestCase::F2TestCase(CppEditorAction action,
if (useClangd)
QEXPECT_FAIL("allOverrides from base declaration", "FIXME: check why this fails", Abort);
QCOMPARE(finalVirtualSymbolResults.size(), expectedVirtualFunctionProposal.size());
- if (useClangd) {
- QEXPECT_FAIL("allOverrides", "FIXME: clangd sometimes goes to decl instead of def", Abort);
- QEXPECT_FAIL("possibleOverrides1", "FIXME: clangd sometimes goes to decl instead of def",
- Abort);
- QEXPECT_FAIL("possibleOverrides2", "FIXME: clangd sometimes goes to decl instead of def",
- Abort);
+ if (useClangd)
QEXPECT_FAIL("itemOrder", "FIXME: sort items", Abort);
- }
QCOMPARE(finalVirtualSymbolResults, expectedVirtualFunctionProposal);
}