diff options
author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2020-06-17 23:34:16 +0300 |
---|---|---|
committer | Orgad Shaneh <orgads@gmail.com> | 2020-06-18 05:16:24 +0000 |
commit | e9df7825fa8a8714c3623154f1fc3cf13066a9a4 (patch) | |
tree | 93ab4d95bd6afd34df7e1f9112f8179d448b3b2f /src/plugins/mercurial | |
parent | 55f3764d08ac5684a9d6fa843f1bcc45289ee8d2 (diff) |
IVersionControl: Change vcsAnnotate return type to void
All implementations return true unconditionally, and the return
value is never read anyway.
+ Remove superfluous function with the same name in Perforce.
Change-Id: I83f361ec7fd8be3177cb4be52e6276e295cd4279
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/mercurial')
-rw-r--r-- | src/plugins/mercurial/mercurialplugin.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/plugins/mercurial/mercurialplugin.cpp b/src/plugins/mercurial/mercurialplugin.cpp index 533d08f4e9..9727167847 100644 --- a/src/plugins/mercurial/mercurialplugin.cpp +++ b/src/plugins/mercurial/mercurialplugin.cpp @@ -144,7 +144,7 @@ public: bool vcsDelete(const QString &filename) final; bool vcsMove(const QString &from, const QString &to) final; bool vcsCreateRepository(const QString &directory) final; - bool vcsAnnotate(const QString &file, int line) final; + void vcsAnnotate(const QString &file, int line) final; Core::ShellCommand *createInitialCheckoutCommand(const QString &url, const Utils::FilePath &baseDirectory, @@ -826,11 +826,10 @@ bool MercurialPluginPrivate::vcsCreateRepository(const QString &directory) return m_client.synchronousCreateRepository(directory); } -bool MercurialPluginPrivate::vcsAnnotate(const QString &file, int line) +void MercurialPluginPrivate::vcsAnnotate(const QString &file, int line) { const QFileInfo fi(file); m_client.annotate(fi.absolutePath(), fi.fileName(), QString(), line); - return true; } Core::ShellCommand *MercurialPluginPrivate::createInitialCheckoutCommand(const QString &url, |