diff options
| author | Ivan Donchevskii <ivan.donchevskii@qt.io> | 2018-07-11 08:25:07 +0200 |
|---|---|---|
| committer | Ivan Donchevskii <ivan.donchevskii@qt.io> | 2018-08-21 08:25:51 +0000 |
| commit | 2c0554c187adb4ef886affd193b8149afa199d13 (patch) | |
| tree | 8c484fc209db1c06e5eec942d1af9e1d0b566140 /src/plugins/projectexplorer/toolchain.h | |
| parent | 263cf4c6088d579a2cda05b3d5b795840e3e79fc (diff) | |
ProjectExplorer: Fix memory leaks in tree models
Fix widgets being leaked by the ToolChainOptionsPage.
This page created widgets and stored them in the tree node
and never deleted them.
The fix is to put all the widgets into one QStackedWidget, so
that this will clean up once the page is destroyed.
Change-Id: Ic02824a4c52771d8962dc594176077c2e139fb84
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Diffstat (limited to 'src/plugins/projectexplorer/toolchain.h')
| -rw-r--r-- | src/plugins/projectexplorer/toolchain.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/projectexplorer/toolchain.h b/src/plugins/projectexplorer/toolchain.h index 0f463bf801..7b41968d06 100644 --- a/src/plugins/projectexplorer/toolchain.h +++ b/src/plugins/projectexplorer/toolchain.h @@ -146,7 +146,7 @@ public: virtual bool operator ==(const ToolChain &) const; - virtual ToolChainConfigWidget *configurationWidget() = 0; + virtual std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() = 0; virtual bool canClone() const; virtual ToolChain *clone() const = 0; |