diff options
| author | Tobias Hunger <tobias.hunger@qt.io> | 2017-01-12 10:31:44 +0100 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@qt.io> | 2017-01-18 10:40:07 +0000 |
| commit | 54cf91b45b592fb5cd863747036abc438f09fb46 (patch) | |
| tree | 546883cc1d939a1fdc37ad4caec0670249d09e1c /src/plugins/qtsupport/qtversionmanager.h | |
| parent | 14edd0a0c273e59eac7b7747b9e1ca3fd40ca5bd (diff) | |
QtVersionManager: Remove QtVersionManager::versions(...)
This call used to return a sorted list of BaseQtVersion *, which is
expensive as sorting might imply running qmake for all Qt versions.
This also makes BaseQtVersion::validVersions(...) return an unsorted list,
so go over all usages of validVersions(...) and use
QtVersionManager::sortVersions(...) where that is necessary.
Change-Id: I8f5dda20fc0819134c64f6a1ca32512500f71710
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Diffstat (limited to 'src/plugins/qtsupport/qtversionmanager.h')
| -rw-r--r-- | src/plugins/qtsupport/qtversionmanager.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/plugins/qtsupport/qtversionmanager.h b/src/plugins/qtsupport/qtversionmanager.h index 38d26b3075..66fe047fbb 100644 --- a/src/plugins/qtsupport/qtversionmanager.h +++ b/src/plugins/qtsupport/qtversionmanager.h @@ -47,7 +47,6 @@ public: // This will *always* return at least one (Qt in Path), even if that is // unconfigured. // Sorting is slow due to needing to potentially run qmake --query for each version - static QList<BaseQtVersion *> versions(const BaseQtVersion::Predicate &predicate = BaseQtVersion::Predicate()); static QList<BaseQtVersion *> validVersions(const BaseQtVersion::Predicate &predicate = BaseQtVersion::Predicate()); static QList<BaseQtVersion *> unsortedVersions(const BaseQtVersion::Predicate &predicate = BaseQtVersion::Predicate()); |