summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2023-03-10 18:38:14 +0100
committerMarc Mutz <marc.mutz@qt.io>2023-03-14 15:55:48 +0100
commit6fd163f627f26e3c4fd1019772a4eafffb8f716f (patch)
treef142d47fac88964865872a52c7549172ef5a32bb
parent60c3aaa54f88729eab808966d2995c9a29c47006 (diff)
tracegen: fix inefficient loops
Take the loop variable by cref. Amends 83effb3a3f6bf73e682f7a9ccedebf4073ade776. Pick-to: 6.5 Coverity-Id: 404701 Change-Id: I1266dd1feb16b3842a93169e554a6563861f5a14 Reviewed-by: Antti Määttä <antti.maatta@qt.io>
-rw-r--r--src/tools/tracegen/helpers.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/tracegen/helpers.h b/src/tools/tracegen/helpers.h
index 11a1c809f3..00a1f99686 100644
--- a/src/tools/tracegen/helpers.h
+++ b/src/tools/tracegen/helpers.h
@@ -24,7 +24,7 @@ template <typename T>
static QString aggregateListValues(int value, const QList<T> &list)
{
QStringList values;
- for (auto l : list) {
+ for (const T &l : list) {
if (l.value == value)
values << l.name;
}