diff options
| author | Ismo Haataja <ismo.haataja@digia.com> | 2014-10-22 14:50:42 +0300 |
|---|---|---|
| committer | Ismo Haataja <ismo.haataja@digia.com> | 2015-01-13 14:10:45 +0100 |
| commit | f0d58169270d0947f8e048a59577549eda753fa2 (patch) | |
| tree | f7168c95bc604b789574d7a4c946e385882d7079 | |
| parent | a7124b38f54423d2a85b82e02dbb41564e2838ef (diff) | |
Remove incorrect information message when commenting an old patch set
Information message about dropped scores was incorrectly shown always
when commenting an old patch set. Size check of the score list added
to get message shown only when necessary.
Task-number: QTQAINFRA-874
Change-Id: I11b392b68b9fa0ab144c78ed7f6221997e83a96f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Ismo Haataja <ismo.haataja@digia.com>
| -rw-r--r-- | gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java index 9fb6b75477..2c8c93f81b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java @@ -185,7 +185,7 @@ public class PostReview implements RestModifyView<RevisionResource, Input> { Output output = new Output(); output.labels = input.labels; output.message = ""; - if (input.labels != null && input.changeReviewable) { + if (input.labels != null && !input.labels.isEmpty() && input.changeReviewable) { if (change.getStatus().isCI()) { output.message = "The change was staged while you were reviewing it. " + |