| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I8eea99a472cc597ff9864b570c90b28b79b3751e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling QWebEngineDownloadRequest::cancel() had no effect if the download
request was accepted by default. These downloads had no corresponding
internal DownloadItem yet, but we tried to cancel them using the
DownloadManager. The safest option is to always check if the DownloadItem
exists in Chromium.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: I8f92d45e00e088aea7d22d5b7271b5b09adf6cbb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Images and PDFs had to be explicitly accepted to download, even if a
filePath was given as argument of QWebEnginePage::save(). This behavior
was inconsistent with saving HTML pages (and the documentation).
Adjust the corresponding test case with verifying the download result
of an auto-accepted download, and add a new test case to make sure about
downloads are not accepted by default when there is no desired filePath.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: I90f4cfa485da2831327bcb25571a0b69499d9006
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the filePath argument of QWebEnginePage::save() is ignored
when the user tries to download anything but HTML; and the requested
download path is the Downloads folder of the OS.
Fix this and adjust the corresponding test case with checking path
and file name of the download request.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: Ia1d3afc898b1aad223aab772b775724a50e88bd3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Enable forcibly modifying content rendering to result in dark color scheme.
[ChangeLog][Settings] ForceDarkMode added, disabled by default.
Fixes: QTBUG-84484
Change-Id: I4b3512dc365c61da8f91d8dead0715dadce91f75
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsImpl::IsSavable() decides which file formats are saveable,
but it allows this only for text-based files. All other files will go
around on the code path of downloading. MHTML (multipart) and PDF files
are saved like this, which means they aren't marked as isSavePageDownload.
Just simply set this flag if the save was requested by the user even if
it was a download.
This fixes the flag for saving MHTML and PDF files from context menu,
and leaves the flag false when a PDF download was initiated by the
button of the web UI.
Pick-to: 6.6
Task-number: QTBUG-114859
Change-Id: Id65f26a96952c5a43876338ad37f40570e544f3a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
qmltests::WebEngineViewSingleFileUpload::test_acceptSingleFileSelection
and
tst_QWebEngineView::textSelectionOutOfInputField
Pick-to: 6.6
Change-Id: Ica3e91f109ae2a43bff9cd25e0da7d363823a762
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
We prefer to name settings with Enabled at the end.
From API review.
Pick-to: 6.6
Change-Id: I7aacc6dbb92d852fd21b067475d2fd9e7df56163
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- test_findTextInterruptedByLoad:
Remove whitespaces from the text as it takes lot
of time to render according to perf.
It should fix the timeout errors.
- loadStartedAfterInPageNavigation:
Remove the viewport meta tag from test.html.
The 2x scale is only applied in embedded builds,
it puts some elements out of the view.
- acceptNavigationRequestNavigationType:
Refresh the reload.html page only once.
On qemu it may reload multiple times messing up
the list of navigation types.
- horizontalScrollbarTest:
Skip instead of blacklist.
- tst_qtbug_110287:
Use an url that loads faster.
Pick-to: 6.6
Task-number: QTBUG-105342
Change-Id: Ifbd41885fee62b12f7022534f9b8bd5e20cbef01
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtPositioningHelper now uses the Qt Permissions API. Also fixup the
examples Simple Browser, Quick Nano Browser and Maps to use the right
key on macOS and sign the application as part of the build process
Moves the Geopermission auto tests to manual tests for webenginequick
and webenginewidgets on macOS.
Pick-to: 6.6
Fixes: QTBUG-114939
Change-Id: Id6771889f20c866d2fcdbb477dbbb7da30367043
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a WebView or WebEngineView gets a mouse or touch grab, we don't want
to give it up to any handlers that may be lurking on Items underneath.
WebView is opaque, so we don't know whether the user is trying to drag a
scrollbar or something else, but interactive items outside shouldn't
interfere, in general.
[ChangeLog][QtWebEngineQuick] WebEngineView (or WebView backed by Qt
WebEngine) no longer allows components outside to take over the mouse or
touch exclusive grab. For example if the user starts dragging a
scrollbar inside the web view, that continues until release, regardless
of any DragHandler, Flickable etc.
Fixes: QTBUG-103518
Pick-to: 6.5 6.6
Change-Id: I4352dc8482020f0efc7a0901e94ccf7fc147fa1b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Since 67d0c0821 in declarative strings are not longer converted
to QStringList in case of c++ calls. Be explicit now.
Fixes: QTBUG-114339
Pick-to: 6.6 6.5
Change-Id: I644a50eea6640d751d81a5a21f478577d4c999cb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
- disables reading from canvas.
Fixes: QTBUG-84486
Change-Id: I3e181bfa6e351dea8dfa61f8010bafb94ea8a77d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Add the convenience method QQuickWebEngineView::save for saving pages without
the need to explicitly handle download requests.
Task-number: QTBUG-56093
Change-Id: I67909fdca6472d1ea9b32e0f89c1ab90219bca3b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are three functions we use within file systems API, which
trigger dialogs:
* window.showSaveFilePicker
* window.showOpenFilePicker
* window.showDirectoryPicker
Only first one was tested with widgets, therefore add tests which cover
use of api, and also test cover the found issues in previous commits.
Note we have separate test to cover file system dialogs coming from
<input> html tags in tst_filePicker
Pick-to: 6.5 6.4
Change-Id: I4616efa84688ed471fb8c4566e49262bce945638
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Implement WebActions to temporarily change text direction directly from
context menu - like Chrome does. They only work for the selected input
field. Omit the "default" option since it is always grayed out in Chrome.
Task-number: QTWB-67
Change-Id: I4bacbd82c6bd7261ac465eec9da3776613f98074
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests use the middle pixel's value of an image to check if a
certain icon is loaded. The images are scaled on High DPI screens and the
pixel values are changed due to interpolation. It cannot be expected to
have the same pixel values for different device-pixel-ratio settings,
thus rather skip the test than maintaining a list of pixel values for
different scales.
Pick-to: 6.5
Change-Id: I8d142de0106167a5d16c540fa468003b36c95317
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Our implementation of QML file picker was outdated. Now directory picker
is a separate type of dialog and other file selection modes are set in
FileDialog.fileMode property.
Pick-to: 6.4 6.5
Change-Id: Icc62369539c56666e596e5ee6f1b3068a43acd81
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Provide the same values what are available from JavaScript.
Pick-to: 6.5
Change-Id: I9e047d749279934d0c8ccd45710571e8c7745859
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Change-Id: I2fe91c06ce91dfaace7825a0589b56ee375479b6
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our qwebenginecertificatestore unit test so far only tested
adding/removing custom certificates into the memory. However,
it never actually initialized certificate store and did
not test if ssl certificate client authentication really works.
Cover that case and client authentication test.
Note ca and client certificates in the test are self signed to
be able to run test without network connection, however
we ignore the errors.
Pick-to: 6.4
Change-Id: I4df4fdfabed5abd8f8bde7d4c0c79b5fd7f6f3a9
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a semantic patch using ClangTidyTransformator as in
qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8, but extended to
handle typedefs and accesses through pointers, too:
const std::string o = "object";
auto hasTypeIgnoringPointer = [](auto type) { return anyOf(hasType(type), hasType(pointsTo(type))); };
auto derivedFromAnyOfClasses = [&](ArrayRef<StringRef> classes) {
auto exprOfDeclaredType = [&](auto decl) {
return expr(hasTypeIgnoringPointer(hasUnqualifiedDesugaredType(recordType(hasDeclaration(decl))))).bind(o);
};
return exprOfDeclaredType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))));
};
auto renameMethod = [&] (ArrayRef<StringRef> classes,
StringRef from, StringRef to) {
return makeRule(cxxMemberCallExpr(on(derivedFromAnyOfClasses(classes)),
callee(cxxMethodDecl(hasName(from), parameterCountIs(0)))),
changeTo(cat(access(o, cat(to)), "()")),
cat("use '", to, "' instead of '", from, "'"));
};
renameMethod(<classes>, "count", "size");
renameMethod(<classes>, "length", "size");
a.k.a qt-port-to-std-compatible-api V4 with config Scope: 'Container'.
Change-Id: I3e6fef8eca212da0c4f0b464545ba96183b4476f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
test_runJavaScript() was badly written with a hardcoded wait of 100ms
this should make it both faster on normal machines and more reliable
on slower ones.
Fixes: QTBUG-106210
Pick-to: 6.4
Change-Id: I539e59dce6e3719661202e1a213277794a660bd3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-105718
Change-Id: I2ad190e5536cdbdc8d2656e61892545d66911a02
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
| |
Was missing from the CMake switch-over
Pick-to: 6.4
Change-Id: I0171d395f9e66c072e368b7019539fc29ff865b8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Trying to pass on qemu-arm64
Pick-to: 6.4
Task-number: QTBUG-105342
Change-Id: I5eca4ef2235d26b88207decd66b06c30b9f9972f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.4
Change-Id: I217c87657f544a2e868de7291353ff1143e20902
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Ammend 9b9d789fcb8f63a8998f1eefe44f2a1c8156c362 :
some files were still missing SPDX headers
Pick-to: 6.4
Task-number: QTBUG-67283
Task-number: QTBUG-104589
Change-Id: Ia4d2aae636bbdb1a99c422e3b8d3f097c3af34d6
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
CMakeLists.txt and .cmake files of significant size
(more than 2 lines according to our check in tst_license.pl)
now have the copyright and license header.
Existing copyright statements remain intact
Task-number: QTBUG-88621
Change-Id: I118bd63694cfe2c9a413af4a38828a31727f8e86
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
License files are organized under LICENSES directory.
Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I869ffda1080e283f231eb0dc4477b260f2054d99
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The datalist uses Chromium's autofill component to fetch and filter
predefined options in the list and autocomplete the field with the
selected option. Autofill component is added to build and bound to
WebEngine. All the unnecessary autofill features for datalist are
supposed to be disabled: payment/credit card support, password manager,
save profile data, store suggestions in database etc.
Custom popups for the dropdown are implemented for Widget and Quick.
Scrolling in dropdown is not implemented in this change.
Fixes: QTBUG-54433
Pick-to: 6.4
Change-Id: I155d02d6dbc9d88fbca4bc5f55b76c19d0ba7a9d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-103735
Pick-to: 6.3 6.4
Change-Id: Iee0c09cde16a825097b7c1c014655476989922c0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I607604f85a111a69da77ca949dddf3399b9721b3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
Fixes: QTBUG-96525
Change-Id: I39d6247c0dd0e55e4fb91b176f34e676eeabbcdd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit ce2d6a94ce99f8d6f82fbcbf45603f8eb7a92957)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds overlooked unit test to test collection API.
Note this test throws bunch of warnings
"Can't open user script ..." and it would require dummy js
files just to suppress those.
Pick-to: 6.3 6.2
Change-Id: Iddf8150c5fee7a29b3dba75066fa51070053d69b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This test started to fail in ci, however
c++ counterpart works fine.
Task-number: QTBUG-101215
Change-Id: Ic94409b6db06f285d11ab10295d5ebaa831c0fa5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 123394142c887e049131b823933de88f258152b0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
| |
Amends d0ff107c00. Ensure default values for profile settings match the
docs. Also fix doc's issues after off-the-record toggle to off by default.
Pick-to: 6.2 6.3
Change-Id: I558a77dbec82d7f2b335b1a2ceca74ab66a1a6e9
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If there is no QTWEBENGINE_CHROMIUM_FLAGS env export we pass all args to
Chromium as "command line". However passing "-type=1" to qt application
with webenigne ends will crash since this arg is used for
sub-process type handling.
Prevent any accidental user args which can affect chromium switches
and from now on pass only args explicitly stated after "--webEngineArgs" option.
[ChangeLog] Command line arguments meant for webengine has to be now
stated after "--webEngineArgs" option.
Fixes: QTBUG-68820
Change-Id: I57b3921d2250f75d445ee7173566dadc41e4ca93
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To create a javascript list on 'collection' method qml engine is needed
for a qml scope, but it's only available for objects, which are created
by the QML Engine itself. The only object in hierarchy of classes is an
actual WebEngineView, so get it from there on collection init.
Also implement delayed initialization of scripts collection for the
usage of default profile through WebEngine singleton, and for the reason
that it's not really needed until really asked by user code.
Pick-to: 6.2 6.3
Fixes: QTBUG-96597
Change-Id: I61e76652a5d0fd5609070fd541816503908f2dc8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Fix build noise as reported by clang for issues like api deprecation,
unused variables, sign/unsigned mismatch and other non critical issues.
Pick-to: 6.2
Change-Id: I4fba25406eea8170e3283c42e908ae86bd512e3a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Parameter "param" is not declared. Injection of parameters into
signal handlers is deprecated. Use JavaScript functions with formal
parameters instead.
Pick-to: 6.2
Change-Id: Iea3583feb10fc56424ebb070e9b19e605c252773
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.2
Task-number: QTBUG-97414
Change-Id: I6f899a5f62b1a37345281a9c6467ed3b059cd2bd
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
|
|
|
|
|
|
|
|
|
| |
QtTest's custome message handler routes it to the same place and
QTest::qWarn() is on its way to deprecation.
Change-Id: I467b2ba81c87b2430a66a9f88c9ef0375dbbff45
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.2
Change-Id: Ibad2e50d840a2eb0ccb9ac65158e512249a2bc79
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Match new api within the page API.
Pick-to: 6.2
Change-Id: Ib2af2f5270f368813cecab8f1c6b7366d3b7172f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-93666
Pick-to: 6.2
Change-Id: I502c240ba541c1c13505f0e78a4098e2aa229af8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Amends a2a9ea11f9. Actually reject certificate when it's considered to
be fatal. Adapt tests for possible regression but checking if load
really failed (due to missing internet access) or was just halted by
missing callback call internaly.
Pick-to: 6.2
Change-Id: I656525c353ce410f7bda8c55227a29fcd617bfdd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 3cdf6827de796b49fb49f94a18906303732bb93f.
Reason for revert: The test didn't work and was skipped due to real regression
Pick-to: 6.2
Change-Id: I6f3c87a0d1561a32465da61a811edc753e69c24b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Match naming with others and use accept/reject methods to handle request.
Also, allow to use request object after call scope in QML.
[ChangeLog][QWebEngineQuick][WebEngineNavigationRequest] setAction(action)
is deprecated in favor of new accept/reject methods
Pick-to: 6.2
Change-Id: I83252370e2e83017008f6951f98b7ecad119e232
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
- Moved TestInputContext and TestInputEvent APIs to tst_qmltests.
- Removed loadVisuallyCommitted and use Item.grabToImage to check if
page is rendered.
- Removed windowCloseRejected signal and use a hidden callback instead.
Pick-to: 6.2
Change-Id: Ica6e4c6017426e0171d738a6a59afa557c786698
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|